mbox series

[0/3] arm, mve: Fix DLSTP testism and issue after changes in codegen

Message ID 20241129103012.3477414-1-andre.simoesdiasvieira@arm.com
Headers
Series arm, mve: Fix DLSTP testism and issue after changes in codegen |

Message

Andre Vieira (lists) Nov. 29, 2024, 10:30 a.m. UTC 
  This patch series does not really need to be a patch series but just makes it
easier to send it all and has one common goal which is to clean up the DLSTP
implementation new to GCC 16 after some codegen changes. The first two patches
clean-up some testcases and the last fixes an actual issue that had gonne by
unnoticed until now.

Only tested on arm-none-eabi mve.exp=dlstp*. OK for trunk?

Andre Vieira (3):
  arm, mve: Fix scan-assembler for test7 in dlstp-compile-asm-2.c
  arm, mve: Pass -std=c99 to dlstp-loop-form.c to avoid new warning
  arm, mve: Detect uses of vctp_vpr_generated inside subregs

 gcc/config/arm/arm.cc                         |  3 ++-
 .../gcc.target/arm/mve/dlstp-compile-asm-2.c  |  1 +
 .../gcc.target/arm/mve/dlstp-invalid-asm.c    | 20 ++++++++++++++++++-
 .../gcc.target/arm/mve/dlstp-loop-form.c      |  2 +-
 4 files changed, 23 insertions(+), 3 deletions(-)

Comments

Christophe Lyon Nov. 29, 2024, 11:04 a.m. UTC | #1 
On 11/29/24 11:30, Andre Vieira wrote:
> This patch series does not really need to be a patch series but just makes it
> easier to send it all and has one common goal which is to clean up the DLSTP
> implementation new to GCC 16 after some codegen changes. The first two patches
> clean-up some testcases and the last fixes an actual issue that had gonne by
> unnoticed until now.
> 
> Only tested on arm-none-eabi mve.exp=dlstp*. OK for trunk?
> 
I OK'ed individual patches modulo an update in a comment in patch 3/3.

But I just realized that patches 1 and 3 fix some of the regressions 
reported in PR target/117814, so their ChangeLog entries should mention 
that.

Thanks,

Christophe

> Andre Vieira (3):
>    arm, mve: Fix scan-assembler for test7 in dlstp-compile-asm-2.c
>    arm, mve: Pass -std=c99 to dlstp-loop-form.c to avoid new warning
>    arm, mve: Detect uses of vctp_vpr_generated inside subregs
> 
>   gcc/config/arm/arm.cc                         |  3 ++-
>   .../gcc.target/arm/mve/dlstp-compile-asm-2.c  |  1 +
>   .../gcc.target/arm/mve/dlstp-invalid-asm.c    | 20 ++++++++++++++++++-
>   .../gcc.target/arm/mve/dlstp-loop-form.c      |  2 +-
>   4 files changed, 23 insertions(+), 3 deletions(-)
>