mbox series

[v10,0/2] Add support for AdvSIMD faminmax

Message ID 20240918152818.2345370-1-saurabh.jha@arm.com
Headers
Series Add support for AdvSIMD faminmax |

Message

Saurabh Jha Sept. 18, 2024, 3:28 p.m. UTC 
  From: Saurabh Jha <saurabh.jha@arm.com>

This is a revised version of this patch series:
https://gcc.gnu.org/pipermail/gcc-patches/2024-September/663204.html

The only new thing in both patches of this series are fixing directives
in test cases, replace /* { dg-do assemble} */ with
/* { dg-do compile } */. We need compile here to make the tests work.
Sorry for missing this review in my previous version.

No changes in code.

Both patches don't require further review as pointed out by Richard
Sandiford in replies to the two patches
* https://gcc.gnu.org/pipermail/gcc-patches/2024-September/663229.html
* https://gcc.gnu.org/pipermail/gcc-patches/2024-September/663230.html

I will request commit access to gcc after this patch is accepted.
Because I already have commit access to binutils, I will email the
overseers.

Saurabh Jha (2):
  aarch64: Add AdvSIMD faminmax intrinsics
  aarch64: Add codegen support for AdvSIMD faminmax

 gcc/config/aarch64/aarch64-builtins.cc        | 119 ++++++++
 .../aarch64/aarch64-option-extensions.def     |   2 +
 .../aarch64/aarch64-simd-pragma-builtins.def  |  23 ++
 gcc/config/aarch64/aarch64-simd.md            |  19 ++
 gcc/config/aarch64/aarch64.h                  |   4 +
 gcc/config/aarch64/iterators.md               |  12 +
 gcc/doc/invoke.texi                           |   2 +
 .../aarch64/simd/faminmax-builtins-no-flag.c  |  10 +
 .../aarch64/simd/faminmax-builtins.c          | 115 ++++++++
 .../aarch64/simd/faminmax-codegen-no-flag.c   | 217 ++++++++++++++
 .../aarch64/simd/faminmax-codegen.c           | 197 +++++++++++++
 .../aarch64/simd/faminmax-no-codegen.c        | 267 ++++++++++++++++++
 12 files changed, 987 insertions(+)
 create mode 100644 gcc/config/aarch64/aarch64-simd-pragma-builtins.def
 create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-builtins-no-flag.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-builtins.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-codegen-no-flag.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-codegen.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-no-codegen.c

Comments

Saurabh Jha Sept. 23, 2024, 4:36 p.m. UTC | #1 
On 9/18/2024 4:28 PM, saurabh.jha@arm.com wrote:
> From: Saurabh Jha <saurabh.jha@arm.com>
> 
> This is a revised version of this patch series:
> https://gcc.gnu.org/pipermail/gcc-patches/2024-September/663204.html
> 
> The only new thing in both patches of this series are fixing directives
> in test cases, replace /* { dg-do assemble} */ with
> /* { dg-do compile } */. We need compile here to make the tests work.
> Sorry for missing this review in my previous version.
> 
> No changes in code.
> 
> Both patches don't require further review as pointed out by Richard
> Sandiford in replies to the two patches
> * https://gcc.gnu.org/pipermail/gcc-patches/2024-September/663229.html
> * https://gcc.gnu.org/pipermail/gcc-patches/2024-September/663230.html
> 
> I will request commit access to gcc after this patch is accepted.
> Because I already have commit access to binutils, I will email the
> overseers.

Thanks for the reviews. I now have the commit access and have committed 
this patch series.
> 
> Saurabh Jha (2):
>    aarch64: Add AdvSIMD faminmax intrinsics
>    aarch64: Add codegen support for AdvSIMD faminmax
> 
>   gcc/config/aarch64/aarch64-builtins.cc        | 119 ++++++++
>   .../aarch64/aarch64-option-extensions.def     |   2 +
>   .../aarch64/aarch64-simd-pragma-builtins.def  |  23 ++
>   gcc/config/aarch64/aarch64-simd.md            |  19 ++
>   gcc/config/aarch64/aarch64.h                  |   4 +
>   gcc/config/aarch64/iterators.md               |  12 +
>   gcc/doc/invoke.texi                           |   2 +
>   .../aarch64/simd/faminmax-builtins-no-flag.c  |  10 +
>   .../aarch64/simd/faminmax-builtins.c          | 115 ++++++++
>   .../aarch64/simd/faminmax-codegen-no-flag.c   | 217 ++++++++++++++
>   .../aarch64/simd/faminmax-codegen.c           | 197 +++++++++++++
>   .../aarch64/simd/faminmax-no-codegen.c        | 267 ++++++++++++++++++
>   12 files changed, 987 insertions(+)
>   create mode 100644 gcc/config/aarch64/aarch64-simd-pragma-builtins.def
>   create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-builtins-no-flag.c
>   create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-builtins.c
>   create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-codegen-no-flag.c
>   create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-codegen.c
>   create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/faminmax-no-codegen.c
>