mbox series

[v1,0/2] Aarch64: addp NEON big-endian fix [PR114890]

Message ID 20240703101040.201174-1-alfie.richards@arm.com
Headers
Series Aarch64: addp NEON big-endian fix [PR114890] |

Message

Alfie Richards July 3, 2024, 10:10 a.m. UTC 
  From: Alfie Richards <alfie.richards@arm.com>

Hi All,

This fixes a case where the operands for the addp NEON intrinsic were erroneously swapped.

Regtested on aarch64-unknown-linux-gnu

Ok for master and GCC14.2?

Kind regards,
Alfie Richards

Alfie Richards (2):
  Aarch64: Add test for non-commutative SIMD intrinsic
  Aarch64, bugfix: Fix NEON bigendian addp intrinsic [PR114890]

 gcc/config/aarch64/aarch64-simd.md            |   2 -
 .../aarch64/vector_intrinsics_asm.c           | 371 ++++++++++++++++++
 2 files changed, 371 insertions(+), 2 deletions(-)
 create mode 100644 gcc/testsuite/gcc.target/aarch64/vector_intrinsics_asm.c

Comments

Kyrylo Tkachov July 3, 2024, 10:23 a.m. UTC | #1 
Hi Alfie,

> On 3 Jul 2024, at 12:10, alfie.richards@arm.com wrote:
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Alfie Richards <alfie.richards@arm.com>
> 
> Hi All,
> 
> This fixes a case where the operands for the addp NEON intrinsic were erroneously swapped.
> 
> Regtested on aarch64-unknown-linux-gnu
> 
> Ok for master and GCC14.2?

This is okay, though I would have done it as a single commit rather than splitting the test case separately and then updating it to remove the xfail.
But it’s okay as is anyway.
Do you need someone to commit it for you?
Thanks,
Kyrill

> 
> Kind regards,
> Alfie Richards
> 
> Alfie Richards (2):
>  Aarch64: Add test for non-commutative SIMD intrinsic
>  Aarch64, bugfix: Fix NEON bigendian addp intrinsic [PR114890]
> 
> gcc/config/aarch64/aarch64-simd.md            |   2 -
> .../aarch64/vector_intrinsics_asm.c           | 371 ++++++++++++++++++
> 2 files changed, 371 insertions(+), 2 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/aarch64/vector_intrinsics_asm.c
> 
> --
> 2.34.1
>
Alfie Richards July 3, 2024, 10:50 a.m. UTC | #2 
Hi Kyrill,

Okay noted for future!
Yes happy someone to commit this.

Kind regards,
Alfie

Sent from Outlook for iOS<https://aka.ms/o0ukef>
Kyrylo Tkachov July 4, 2024, 7:11 a.m. UTC | #3 
> On 3 Jul 2024, at 12:50, Alfie Richards <Alfie.Richards@arm.com> wrote:
> 
> External email: Use caution opening links or attachments 
> Hi Kyrill,
> 
> Okay noted for future!
> Yes happy someone to commit this.
> 

Ok, I’ve pushed the two patches to mainline for you.
Thanks!
Kyrill

> Kind regards,
> Alfie
> 
> Sent from Outlook for iOS
> From: Kyrylo Tkachov <ktkachov@nvidia.com>
> Sent: Wednesday, July 3, 2024 11:23:37 AM
> To: Alfie Richards <Alfie.Richards@arm.com>
> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
> Subject: Re: [PATCH v1 0/2] Aarch64: addp NEON big-endian fix [PR114890]   Hi Alfie,
> 
> > On 3 Jul 2024, at 12:10, alfie.richards@arm.com wrote:
> > 
> > External email: Use caution opening links or attachments
> > 
> > 
> > From: Alfie Richards <alfie.richards@arm.com>
> > 
> > Hi All,
> > 
> > This fixes a case where the operands for the addp NEON intrinsic were erroneously swapped.
> > 
> > Regtested on aarch64-unknown-linux-gnu
> > 
> > Ok for master and GCC14.2?
> 
> This is okay, though I would have done it as a single commit rather than splitting the test case separately and then updating it to remove the xfail.
> But it’s okay as is anyway.
> Do you need someone to commit it for you?
> Thanks,
> Kyrill
> 
> > 
> > Kind regards,
> > Alfie Richards
> > 
> > Alfie Richards (2):
> >  Aarch64: Add test for non-commutative SIMD intrinsic
> >  Aarch64, bugfix: Fix NEON bigendian addp intrinsic [PR114890]
> > 
> > gcc/config/aarch64/aarch64-simd.md            |   2 -
> > .../aarch64/vector_intrinsics_asm.c           | 371 ++++++++++++++++++
> > 2 files changed, 371 insertions(+), 2 deletions(-)
> > create mode 100644 gcc/testsuite/gcc.target/aarch64/vector_intrinsics_asm.c
> > 
> > --
> > 2.34.1
> > 
>