From patchwork Wed Mar 30 23:31:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 52487 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 228343853809 for ; Wed, 30 Mar 2022 23:32:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 228343853809 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1648683141; bh=0LAxR466NghfiqSOp1LJXzVqV7rIbvgGtTDd4jSEfgQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=QzinqSTeye/utwbrGnFIwT0pNuk5fIJbM9CCQ70v2yw7oSkMH4mMCjdQtSmQONAy8 gqR6o+2vHL/L/zGBXXTzrrptvGhDKJb4UQOA6DfPosiXg3RsWtZW2rPK9+CvPS0QLe GatvAU38WneNxchy5HMxT8TY1pLmw/gMLFnNxDt0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 2EB173858C2D for ; Wed, 30 Mar 2022 23:31:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2EB173858C2D Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22UM93qG029851 for ; Wed, 30 Mar 2022 23:31:49 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com with ESMTP id 3f1tqbaq91-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Mar 2022 23:31:48 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 22UNMbIQ007313 for ; Wed, 30 Mar 2022 23:31:47 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3f1s979708-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Mar 2022 23:31:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m2THcA2YtZT0P2BgMTM+MRaJJs/CgCaVMbkkfHOoGf6KCVNZFENaYpUAabBDykx8ATcU8ig7Q8Dpz+Z8Xfu6Uye+kCV99VKKAQdJ9cCgX7io9krdRMnqndICozkHvh6QMjVRSU/GQkiJIXRsnGWzruN9YGm8wEvsRxfauoZgX+cwFif+UWa8RJTMZpbPfpL0VWgXNtXm/lVIws+9alJ+d1Wb9TLTxamMm1GfT3ehUC7wW0CFdbwxNPYitJM/Z4A/xLygeue4K2JjBVRfjIm3s/eAVuTvCoahgcnOrBBGJeABUSnYVcuLo0Eq0N/PYo8nl/9KkKU8eq9pDdTdiqWWfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0LAxR466NghfiqSOp1LJXzVqV7rIbvgGtTDd4jSEfgQ=; b=NFX3lqhPHbOl6zl7Zr6CVflz5QvGw7STjjgQwqkmg3wqMta6uJAONb31jwGbNZNl2lI2zEIR40wV2kHjON1POU92/SWbw33NZlwaaNPTeHJWd8dsn32OvWmhDluFQln2qzhtH8CUKE+ry5/PEObqbHvs5MOLgihoohlu6yXvRNOiMyRfc0FCHp1u8dGnL1hFYPWeHm3bieL9Z9RJa1qV9iFfuQyZnYIpQ+WCcvGqe6Dx3mo5Mi18mUqSNNl9rfg1PTB3p/kVFnLupH3k/TJTsMiR/7SGSzBg6m7sT3htWnionyqZFdC/JuKRPIyNPoptu9BIiiCYBegvm94G0rmwew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CO6PR10MB5538.namprd10.prod.outlook.com (2603:10b6:303:135::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.20; Wed, 30 Mar 2022 23:31:45 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::b1f2:a803:163b:aad5]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::b1f2:a803:163b:aad5%4]) with mapi id 15.20.5102.022; Wed, 30 Mar 2022 23:31:44 +0000 To: gcc-patches@gcc.gnu.org Subject: [PATCH 0/3] Fix PR debug/105089 Date: Wed, 30 Mar 2022 16:31:32 -0700 Message-Id: <20220330233135.1762317-1-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: MW4PR03CA0205.namprd03.prod.outlook.com (2603:10b6:303:b8::30) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18f8f2d7-a5b0-4562-7e23-08da12a573b9 X-MS-TrafficTypeDiagnostic: CO6PR10MB5538:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LmURYLryqmsnXP0eUjMc9xmuLKutibdV23b+N94ksbqxF869k+5UFTpcA81JPA56Ovib/WH8IGMN/G8ALVMxZbDH0fEbTb/jQ37oKgH7d9tQ/YWCsY1RD/niEWWEnopR0F5OlvKtdQqJ0HvOafirkeLCsKgUZbPOL43Dj9XrFIY1wkvqgKLbzJUozayzPWYhTMcZw82O1alAenuXqCNU0XqFi+znnMJEas39d3LxvcyUy1qCsP4haQ0tSKfX3We0oppFTPFplqmGSWTq7QSn0krL077GxappPzqkrr0kb78LLvlZALccfePLrydifRIqS9yrOYJbUkZVF8f7R/eSRPBoK3I4AghRlv3ZB7LRC7SHtMjNLeN0nbgKK63Jy4EBuKj4bakREJNyfvIeHLtnEtVxqD0Uh2KI1Ctwwwn10st46JArKgRHCZSdaAgaqJWTuRvszmaEWEJHQAyoy+3ZKbt7um/0xFd1NygB9tp7M2+hAM1q/ilCtrHJcQdCxBq/r++c6lkkDFU8CzsBf1biRpqRIgOxm2o0n1JDa+jDTUnF90+qEkXm4Ahh2xKaij1iWAOhtT8nTQnZ5lUofcS7x5upwgCS8vAswDxsz5qF/yfOJliX+wzHvCKQaYKbABEo1wNHdGxCb3jfg7k0r/8qGMcpdPJFdE2NSVZN5thL2t83SmQEba88k+nZC2grf/qivO2nOlq1foI5+gLi9/Q+kQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(316002)(52116002)(6506007)(186003)(1076003)(36756003)(6666004)(83380400001)(86362001)(26005)(2906002)(6916009)(38350700002)(2616005)(44832011)(508600001)(6486002)(5660300002)(66476007)(66946007)(66556008)(8676002)(38100700002)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NWsE82T7I2JsXbwcylwFLEOFIEfGlFYgjcEkEO1ZtWCWSWHXR9mtWiwMdvNkqcJB6/Ed3XjZ04DsOlPbN74NH+nQX6g48dDd0hzsc2eL3Fsmf6MaS56+blHVgiwGnKZgIAfLrJ6/RaTrz9JQ/YtkCq+wdShJTuMINsCdxuWrIqPffgRh4mymdB1rbFKIqj4gRCURk9NCSzxJksKB8j9BxADl9WImuKjGf+bc/GOoHJEG2R70LXUKigqs//UeorIN+Dv4fkgES6b+dWorpRkGOBs+Rgn2IUE0SIBERtNA4s4XDN3PtEgrvn5jQNfzH0xPD0WlAUekOdBQcZFwLU7BmXtFeuBZIAeIAuWblSxnbF6vx9KMeNZul0tssvgH7K2rB/I4lTjtBxqbkkA4w7jQerRyVoQDbuNM1u0LTVExksB8NKdPpP5ytS502NGgZ3fy+rMfmCW+2qzP/AbwqayIa5sRtRsDWgQ35IDqYC3XS0T8ave5iBdd7CaebZhL8Lwcd11c0j351xFdAh9apHCoLkdIWd4wyGNWx8B3jbo+qw1qtIgamWuDDJ/uRxJPhqOvz/zjpzUebDTlfyAa777TLwxho9gY4CWC0l13/0+ZxpmDazQK3uc0tWZlerLWgKJXOevf0PuJZTGXV2akvJEFl6/22rxCqkDMHv6SwKs3nDOLui253kqHHQaB1bGNixclElKKPxH4T9JN8wU8CB951mHGur2Lr2kTDqA1ieVELKLrvF9jFi1iaIVeAn0FOtzUlxjWAkOuLd1c2paaIaG1qdmVEkO50XPijMI69nYSS8379SjsTAAFf6gfYvteJOKL2ys/EcQnvX0JLblmaJiibYyNCaoXZXlxol8EWoCgOtfwDSvuFOubePS/PGhMMvBDGiCYSnH0KJLIdW8yCgEKM+qZdizlRxf/Vf0+ceAosopfy55nBcp1tfcuZDfV6RwV47I6Cxy3PGhYNX6osnc/fZ4Z5nXITEeY2fFgpUIZmZn9SeIN/w/cFWsum/kI2j31+rkJQ+PYBxpaoGmNtCac09GdFDMtLgu8qY8cW0Rl8Orq/lAaKxpPkQUqA7LkcR1RDnCNAqiaZLkMyTi882h9MWYFDI48os5zYlkKBl2dCcDGyhAmwQ4iIoTaSmcftq5BdYRKOkIOG3f6q+6YKRB9IZ0qGtFc0VwgQPKOOVWHPzQG6TN8DdDvDr83QBkb8uLCsu08RDOwDYbiu/1TYvxPlnbw9+/DA50BlpO4vQktovuihkAjZRYpsDZPCkq7XfV8PKz90UGWJ8zvgSQjRcP8EIPXHlGL/IExz/NTLUUDU1WF6YZTk5aaS+bBAywo2G4Vfjkp5jrkO97sEZtIPxlrSBlWHBx4+i9yEXYVAf6cleY8NoQ+u1mai3C08vBiEJJscBzw8gWjkZfSUuvRKNeGEdDuyffgJU3Xt6M4ngsf2rkggTJLDETiQdLFQkwhaNBfKGZVPJcjYw9Vo1bgTe66oTlG1pdJlDXpDR8z8CTvCFz9Xf3uHshnqgNkQ1QDbU0VptpURxA2rITD0pbWiQPVw9bejF+B1HnM2hKDPFkQqVr9uJBc1QVQc4ksKxgXBtDsxBY51VyRPAs1G3g9rmF7rBe4lm8/dQS6xtocrK9pVSux97YQ+DwwlAOACxtVP6CycLUFzJnPhiUV4IvjYahGfB5qRxpm87wJNlM4XifaTJ9rzCbKrouesiFgBnTOVV4OMRFyr2uLPAseIs0ZKZ7rPg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18f8f2d7-a5b0-4562-7e23-08da12a573b9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 23:31:44.8817 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vkGzsvrW5oiCfBWLNYreZSIQeqha1HRxLDvHq7CtZU07tnjzCkCr04JtV4pIL/caw/taZvslr/53H1u2WCxYZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5538 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.850 definitions=2022-03-30_06:2022-03-29, 2022-03-30 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 phishscore=0 mlxlogscore=963 spamscore=0 mlxscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203300112 X-Proofpoint-GUID: Fn1tJfAGUq4ZqfquRZKI5zVtkLjbRQ5Y X-Proofpoint-ORIG-GUID: Fn1tJfAGUq4ZqfquRZKI5zVtkLjbRQ5Y X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Gcc-patches From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hello, This patch set fixes PR debug/105089. [PS: The first patch in the series "ctfc: get rid of the static variable in ctf_list_add_ctf_vars" is unrelated to the PR and is combined here only for ease of review.] As noted in the PR debug/105089, gcc is emitting two CTF variable records where it sees an extern variable with declaration and definition in the same compilation unit. The CTF format format does not distinguish between the non-defining decl vs. the defining decl, so the correct behaviour wrt the compiler generating the type for such extern variables is to simply emit the type of the defining declaration. Testing Notes: -- bootstrapped and reg tested on x86_64 and aarch64 -- built binutils package with -gctf (with CTF-capable linker) on x86_64, no CTF errors reported. Thanks, Indu Bhagat (3): ctfc: get rid of the static variable in ctf_list_add_ctf_vars () CTF for extern variable fix [PR105089] Refactor and update CTF testcases [PR105089] gcc/ctfc.cc | 62 ++++++++++++++++++- gcc/ctfc.h | 8 ++- gcc/ctfout.cc | 28 ++++++--- gcc/dwarf2ctf.cc | 18 +++++- gcc/testsuite/gcc.dg/debug/ctf/ctf-array-2.c | 22 +++---- gcc/testsuite/gcc.dg/debug/ctf/ctf-array-5.c | 17 +++++ .../gcc.dg/debug/ctf/ctf-variables-3.c | 22 +++++++ 7 files changed, 147 insertions(+), 30 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/debug/ctf/ctf-array-5.c create mode 100644 gcc/testsuite/gcc.dg/debug/ctf/ctf-variables-3.c