Missing newline for: elfcompress -t zlib-gnu a.out -force

Message ID e28f24ad-cedb-9995-df35-27be3a31e4af@suse.cz
State Committed
Headers
Series Missing newline for: elfcompress -t zlib-gnu a.out -force |

Commit Message

Martin Liška Nov. 28, 2022, 1:03 p.m. UTC
  Hey.

Fixes:
./src/elfcompress -t zlib-gnu a.out -force
[28] .zdebug_aranges unchanged, already GNU compressed[29] .zdebug_info unchanged, already GNU compressed[30] .zdebug_abbrev unchanged, already GNU compressed[31] .zdebug_line unchanged, already GNU compressed[32] .zdebug_str unchanged, already GNU compressed[33] .zdebug_line_str unchanged, already GNU compressed[34] .zdebug_rnglists unchanged, already GNU compressed

to:
./src/elfcompress -t zlib-gnu a.out -force
[28] .zdebug_aranges unchanged, already GNU compressed
[29] .zdebug_info unchanged, already GNU compressed
[30] .zdebug_abbrev unchanged, already GNU compressed
[31] .zdebug_line unchanged, already GNU compressed
[32] .zdebug_str unchanged, already GNU compressed
[33] .zdebug_line_str unchanged, already GNU compressed
[34] .zdebug_rnglists unchanged, already GNU compressed

I'm going to push it as obvious, hope it's fine?

Thanks,
Martin

src/ChangeLog:

	* elfcompress.c (process_file): Add missing newline.
---
  src/elfcompress.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Mark Wielaard Nov. 28, 2022, 2:43 p.m. UTC | #1
Hi Martin,

On Mon, 2022-11-28 at 14:03 +0100, Martin Liška wrote:
> Fixes:
> ./src/elfcompress -t zlib-gnu a.out -force
> [28] .zdebug_aranges unchanged, already GNU compressed[29]
> .zdebug_info unchanged, already GNU compressed[30] .zdebug_abbrev
> unchanged, already GNU compressed[31] .zdebug_line unchanged, already
> GNU compressed[32] .zdebug_str unchanged, already GNU compressed[33]
> .zdebug_line_str unchanged, already GNU compressed[34]
> .zdebug_rnglists unchanged, already GNU compressed
> 
> to:
> ./src/elfcompress -t zlib-gnu a.out -force
> [28] .zdebug_aranges unchanged, already GNU compressed
> [29] .zdebug_info unchanged, already GNU compressed
> [30] .zdebug_abbrev unchanged, already GNU compressed
> [31] .zdebug_line unchanged, already GNU compressed
> [32] .zdebug_str unchanged, already GNU compressed
> [33] .zdebug_line_str unchanged, already GNU compressed
> [34] .zdebug_rnglists unchanged, already GNU compressed
> 
> I'm going to push it as obvious, hope it's fine?

Yes, obvious typo. Thanks for fixing it.

Also the buildbot arm32 failure on run-debuginfod-federation-metrics.sh 
was clearly unrelated. Another Fatal error in GNU libmicrohttpd
daemon.c:3239: Failed to remove FD from epoll set. Grmbl.
Undeterministic tests :{

Cheers,

Mark
  

Patch

diff --git a/src/elfcompress.c b/src/elfcompress.c
index 6f18e47d..51ff69d2 100644
--- a/src/elfcompress.c
+++ b/src/elfcompress.c
@@ -765,7 +765,7 @@  process_file (const char *fname)
  	      else if (verbose >= 0)
  		{
  		  if (startswith (sname, ".zdebug"))
-		    printf ("[%zd] %s unchanged, already GNU compressed",
+		    printf ("[%zd] %s unchanged, already GNU compressed\n",
  			    ndx, sname);
  		  else
  		    printf ("[%zd] %s cannot GNU compress section not starting with .debug\n",