testsuite: Avoid C99 compatibility issues in run-native-test.sh

Message ID 87jzy33dzu.fsf@oldenburg.str.redhat.com
State Committed
Headers
Series testsuite: Avoid C99 compatibility issues in run-native-test.sh |

Commit Message

Florian Weimer April 22, 2023, 7:37 p.m. UTC
  Include <unistd.h> for the pause function, and add the return type
of main.  Avoids an implicit function declaration and implicit int.

Signed-off-by: Florian Weimer <fweimer@redhat.com>

---
Related to:

  <https://fedoraproject.org/wiki/Changes/PortingToModernC>
  <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>

 tests/run-native-test.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


base-commit: 4d8de4b2fa05495d69d09e1a3d335f24d6bf33ee
  

Comments

Mark Wielaard April 22, 2023, 7:56 p.m. UTC | #1
Hi Florian,

On Sat, Apr 22, 2023 at 09:37:09PM +0200, Florian Weimer via Elfutils-devel wrote:
> Include <unistd.h> for the pause function, and add the return type
> of main.  Avoids an implicit function declaration and implicit int.

Thanks, pushed.

Cheers,

Mark
  

Patch

diff --git a/tests/run-native-test.sh b/tests/run-native-test.sh
index d19007f2..042a51c6 100755
--- a/tests/run-native-test.sh
+++ b/tests/run-native-test.sh
@@ -27,7 +27,8 @@ 
 # in all builds.
 
 tempfiles native.c native
-echo 'main () { while (1) pause (); }' > native.c
+printf '#include <unistd.h>\nint main (void) { while (1) pause (); }\n' \
+  > native.c
 
 native=0
 kill_native()