From patchwork Thu Dec 9 14:23:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Wielaard X-Patchwork-Id: 48713 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8827F3858002 for ; Thu, 9 Dec 2021 14:23:34 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id C7EC43858016 for ; Thu, 9 Dec 2021 14:23:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C7EC43858016 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id E77E43000ED0 for ; Thu, 9 Dec 2021 15:23:25 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 0437E413CC9A; Thu, 9 Dec 2021 15:23:24 +0100 (CET) Message-ID: <5f72e895306b8f742bd41d1020ad49e64aa5a958.camel@klomp.org> Subject: right, trying --enable-sanitizer-address on armv7l From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Thu, 09 Dec 2021 15:23:24 +0100 X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org Sender: "Elfutils-devel" Hi, I was trying the new --enable-sanitizer-address on our armv7l buildbot worker and it almost works as is, except for... debuginfod.cxx:3472:12: runtime error: reference binding to misaligned address 0x00561ec9 for type '', which requires 2 byte alignment 0x00561ec9: note: pointer points here 12 0a 00 2d e9 f0 4f 85 b0 00 af f8 60 df f8 bc e1 fe 44 f8 68 fa 68 00 2a 04 d0 00 f0 03 0c bc ^ And indeed removing 'right' here: << (sqlite3_column_text(ps_query, 1) ?: (const unsigned char*) "NULL") << endl; Makes everything PASS. But I don't understand why. It might be a bug in gcc/libasan (this is gcc 8.3.0 Debian 10.11 - Buster). I can try upgrading the machine to Debian 11 - Bullseye this weekend to see if that helps. Also, do we really want to right align the log here? We don't seem to align the log text anywhere else. Cheers, Mark diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx index 35424e47..6fad331a 100644 --- a/debuginfod/debuginfod.cxx +++ b/debuginfod/debuginfod.cxx @@ -3469,7 +3469,7 @@ database_stats_report() throw sqlite_exception(rc, "step"); obatched(clog) - << right << setw(20) << ((const char*) sqlite3_column_text(ps_query, 0) ?: (const char*) "NULL") + << setw(20) << ((const char*) sqlite3_column_text(ps_query, 0) ?: (const char*) "NULL") << " "