Message ID | 20250120032041.280173-9-amerey@redhat.com |
---|---|
State | Dropped |
Delegated to: | Mark Wielaard |
Headers |
Return-Path: <elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1BF533858CD1 for <patchwork@sourceware.org>; Mon, 20 Jan 2025 03:23:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1BF533858CD1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PkwP7pwV X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 9D5FC3858CDA for <elfutils-devel@sourceware.org>; Mon, 20 Jan 2025 03:20:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D5FC3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D5FC3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737343255; cv=none; b=S6cyX3kpDG6eebshZEQ9wdyjwry6WtLHXH3XdWacHQNcj22pJ+y4ZmtaRxVeih5NinsQkaJxB5IF2gdmzjV5YZMLMEKOuRow4nFY8gVRgygSA7dgwO8usfIRdPHLDzecQXRKk6SSsJfezRF8H/hDaRMEaAoVt24Wxoum82qJ4Mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737343255; c=relaxed/simple; bh=XTI32zh/7UtQNdWlmGjTAOCqWHKxGYqRlmDGMm5BcgU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bA/orT9JiXtfVnilxbSA35hx/IUg0MHxxXRg2oHjxfCGmzzCX9rbADBSJBoZNlsErdOxaU+NwQ8f368Gxj/WBuSHSJYLLc+ZaKU6iPXjIuyfBOv0TiNuy74cBtgb36YTbdmg8uYbLjc/m9ZVjQGdsqzM2xZd3VX6Fzl5I9f7GIE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D5FC3858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737343255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lRssHVOJeZpL5OyzLtfi2Jup9MOqIPFoc4GJ45pa9Iw=; b=PkwP7pwV9mjPMtoqTXjra2IbYa2wvzc5gq8iitrNqXsrYroAzzmksPlXFpT2eyvwLSXlGa r3I9CYhao6mPDRKt49e4ZyNw1YqgLT5FfMfXSUyjvq08et65O3DMQag1Y/qN2Wh6wU4VO0 FWnROwgf9xX7uK0F+BULZS8e0QNAJEA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-IT_lTjlvOjqVz31quRjm3Q-1; Sun, 19 Jan 2025 22:20:53 -0500 X-MC-Unique: IT_lTjlvOjqVz31quRjm3Q-1 X-Mimecast-MFC-AGG-ID: IT_lTjlvOjqVz31quRjm3Q Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F17E219560B3 for <elfutils-devel@sourceware.org>; Mon, 20 Jan 2025 03:20:52 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.80.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 48AE01956094; Mon, 20 Jan 2025 03:20:52 +0000 (UTC) From: Aaron Merey <amerey@redhat.com> To: elfutils-devel@sourceware.org Cc: Aaron Merey <amerey@redhat.com> Subject: [PATCH 09/15] dwarf_onesrcline.c: Add locking Date: Sun, 19 Jan 2025 22:20:35 -0500 Message-ID: <20250120032041.280173-9-amerey@redhat.com> In-Reply-To: <20250120032041.280173-1-amerey@redhat.com> References: <20250120032041.280173-1-amerey@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vNVtMnCNtJRZZR199nGBtLjXDZU7RhX-d2tt9RO9WTk_1737343253 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org |
Series |
[01/15] Add eu_search_tree_init
|
|
Commit Message
Aaron Merey
Jan. 20, 2025, 3:20 a.m. UTC
* libdw/dwarf_onesrcline.c (dwarf_onesrcline): Use dwarf_lock.
Signed-off-by: Aaron Merey <amerey@redhat.com>
---
libdw/dwarf_onesrcline.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Comments
Hi Aaron, On Sun, Jan 19, 2025 at 10:20:35PM -0500, Aaron Merey wrote: > * libdw/dwarf_onesrcline.c (dwarf_onesrcline): Use dwarf_lock. Is this really necessary? When the user calls dwarf_onesrcline wouldn't they already have a fully setup Dwarf_Lines? Can it still change concurrently? > Signed-off-by: Aaron Merey <amerey@redhat.com> > > --- > libdw/dwarf_onesrcline.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libdw/dwarf_onesrcline.c b/libdw/dwarf_onesrcline.c > index 5d3c3ded..1a16269a 100644 > --- a/libdw/dwarf_onesrcline.c > +++ b/libdw/dwarf_onesrcline.c > @@ -40,11 +40,16 @@ dwarf_onesrcline (Dwarf_Lines *lines, size_t idx) > if (lines == NULL) > return NULL; > > + mutex_lock (lines->dbg->dwarf_lock); > + > if (idx >= lines->nlines) > { > __libdw_seterrno (DWARF_E_INVALID_LINE_IDX); > return NULL; > } > > - return &lines->info[idx]; > + Dwarf_Line *result = &lines->info[idx]; > + mutex_unlock (lines->dbg->dwarf_lock); > + > + return result; > } > -- > 2.47.1 >
Hi Mark, On Wed, Jan 22, 2025 at 7:15 PM Mark Wielaard <mark@klomp.org> wrote: > > On Sun, Jan 19, 2025 at 10:20:35PM -0500, Aaron Merey wrote: > > * libdw/dwarf_onesrcline.c (dwarf_onesrcline): Use dwarf_lock. > > Is this really necessary? When the user calls dwarf_onesrcline > wouldn't they already have a fully setup Dwarf_Lines? Can it still > change concurrently? Hmm as with dwarf_lineaddr, I had previously seen helgrind flag dwarf_onesrcline during testing but I am unable to reproduce an error with these locks commented out. I'm not sure why this is. I'll drop this patch until I can prove there is a need for it. Aaron
diff --git a/libdw/dwarf_onesrcline.c b/libdw/dwarf_onesrcline.c index 5d3c3ded..1a16269a 100644 --- a/libdw/dwarf_onesrcline.c +++ b/libdw/dwarf_onesrcline.c @@ -40,11 +40,16 @@ dwarf_onesrcline (Dwarf_Lines *lines, size_t idx) if (lines == NULL) return NULL; + mutex_lock (lines->dbg->dwarf_lock); + if (idx >= lines->nlines) { __libdw_seterrno (DWARF_E_INVALID_LINE_IDX); return NULL; } - return &lines->info[idx]; + Dwarf_Line *result = &lines->info[idx]; + mutex_unlock (lines->dbg->dwarf_lock); + + return result; }