Message ID | 20250120032041.280173-7-amerey@redhat.com |
---|---|
State | Dropped |
Delegated to: | Mark Wielaard |
Headers |
Return-Path: <elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32E6F3858406 for <patchwork@sourceware.org>; Mon, 20 Jan 2025 03:24:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32E6F3858406 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OOGHemCc X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 8FD4A3858C35 for <elfutils-devel@sourceware.org>; Mon, 20 Jan 2025 03:20:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FD4A3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FD4A3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737343253; cv=none; b=TFjs4XMoOCRVj2NG3ilyNMrUTh+6J8dmJsOXY3hfCKgVDqe2ZbpEBoYwAWC3OX7cmcyuJUsu61sSfq94ay53glCFVU33aeC8Mw/zVoXx54GhR7sxT5IOYgYGgKnefk4YUfXP/2abBPlPs7YaFQPdMY5ct10OhkW67pHZ3rpL07k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737343253; c=relaxed/simple; bh=GSPBZgQ+GwV50dVV8QaxI++wYYCg09YEkFswKo4i980=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eBMJYhBTVZyDEPtbnx35D31R+qtNTEhd5bRwKCxgFTR/NxxWhlx1qttG4X/Aff8+xzQDBqbWkqITPCdwLMP9VYXkErKwwSghM8GSPSVGWxrrt6WHhEN8syKb9zv6TuVV/DotSvFloaETNeLYRy6f6lv921gDL8R2GilExrbOgkU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FD4A3858C35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737343253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ikck9WEa8Zt/PR/5KyGD80jPNGk2y9/tZS2CAKgLegY=; b=OOGHemCctsVxNbHGPaBxhYD+jI23r+vkv00ZB6U1VjrZMRdohmG+PDofuvsikYVeyhWp4j 1ofGeJ+ue3dSBq42dZeQgC9QzvPBncQqtbgbAjRxuq7VefUh83pwpgYR0ztf1TgaPxY7Ot Ine0DYpuebaeqJr13IMZYMJH8bzLmKc= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-yAmryPdJPNiEnlyPObfOvw-1; Sun, 19 Jan 2025 22:20:51 -0500 X-MC-Unique: yAmryPdJPNiEnlyPObfOvw-1 X-Mimecast-MFC-AGG-ID: yAmryPdJPNiEnlyPObfOvw Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1BA1A19560BB for <elfutils-devel@sourceware.org>; Mon, 20 Jan 2025 03:20:51 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.80.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3679E1956094; Mon, 20 Jan 2025 03:20:50 +0000 (UTC) From: Aaron Merey <amerey@redhat.com> To: elfutils-devel@sourceware.org Cc: Aaron Merey <amerey@redhat.com> Subject: [PATCH 07/15] dwarf_lineaddr.c: Add locking Date: Sun, 19 Jan 2025 22:20:33 -0500 Message-ID: <20250120032041.280173-7-amerey@redhat.com> In-Reply-To: <20250120032041.280173-1-amerey@redhat.com> References: <20250120032041.280173-1-amerey@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wAUrWEbjoIojKL2cZ0S_8PPfKRR3IyWDntmR_3kWOsM_1737343251 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org |
Series |
[01/15] Add eu_search_tree_init
|
|
Commit Message
Aaron Merey
Jan. 20, 2025, 3:20 a.m. UTC
* libdw/dwarf_lineaddr.c (dwarf_lineaddr): Use dwarf_lock.
Signed-off-by: Aaron Merey <amerey@redhat.com>
---
libdw/dwarf_lineaddr.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi Aaron, On Sun, Jan 19, 2025 at 10:20:33PM -0500, Aaron Merey wrote: > * libdw/dwarf_lineaddr.c (dwarf_lineaddr): Use dwarf_lock. Why is this necessary? It seems this function can only be called with a known/setup Dwarf_Line. Can it be concurrently changes at this point? > Signed-off-by: Aaron Merey <amerey@redhat.com> > > --- > libdw/dwarf_lineaddr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libdw/dwarf_lineaddr.c b/libdw/dwarf_lineaddr.c > index 4e1952d3..bf81966c 100644 > --- a/libdw/dwarf_lineaddr.c > +++ b/libdw/dwarf_lineaddr.c > @@ -40,7 +40,9 @@ dwarf_lineaddr (Dwarf_Line *line, Dwarf_Addr *addrp) > if (line == NULL) > return -1; > > + mutex_lock (line->files->dbg->dwarf_lock); > *addrp = line->addr; > + mutex_unlock (line->files->dbg->dwarf_lock); > > return 0; > } > -- > 2.47.1 >
Hi Mark, On Wed, Jan 22, 2025 at 7:08 PM Mark Wielaard <mark@klomp.org> wrote: > > On Sun, Jan 19, 2025 at 10:20:33PM -0500, Aaron Merey wrote: > > * libdw/dwarf_lineaddr.c (dwarf_lineaddr): Use dwarf_lock. > > Why is this necessary? It seems this function can only be called with a known/setup Dwarf_Line. Can it be concurrently changes at this point? I previously saw dwarf_lineaddr get flagged by helgrind but currently I'm unable to reproduce the error even when commenting out the lock. Let's drop this patch until the concurrent changes are known to occur. Aaron
diff --git a/libdw/dwarf_lineaddr.c b/libdw/dwarf_lineaddr.c index 4e1952d3..bf81966c 100644 --- a/libdw/dwarf_lineaddr.c +++ b/libdw/dwarf_lineaddr.c @@ -40,7 +40,9 @@ dwarf_lineaddr (Dwarf_Line *line, Dwarf_Addr *addrp) if (line == NULL) return -1; + mutex_lock (line->files->dbg->dwarf_lock); *addrp = line->addr; + mutex_unlock (line->files->dbg->dwarf_lock); return 0; }