Message ID | 20250120032041.280173-1-amerey@redhat.com |
---|---|
State | Committed |
Delegated to: | Mark Wielaard |
Headers |
Return-Path: <elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EEA8F3858C5F for <patchwork@sourceware.org>; Mon, 20 Jan 2025 03:21:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEA8F3858C5F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eXMLhBmQ X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 59BFC3858D28 for <elfutils-devel@sourceware.org>; Mon, 20 Jan 2025 03:20:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59BFC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 59BFC3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737343247; cv=none; b=h2Rmhqs5Of91a9j0ZqEE330h3rGj6fFq1R7ehRvvusI0Tnl2KfnaQ9ct7V8uGBmwtfDInmTnVqhXcqQHup0gD92G9mnRu4e2lwQDC7ONfAFXMKA6GpcgYJtQoFaj+ygDX0N68xcDcQIWce8QgjCy7ka6Gagd7PRMoWM5taJPMZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737343247; c=relaxed/simple; bh=smUljLOUcVYEp+HL49/UQcm/3kXPNrnN2Gg0orfPSrI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FJB7Ri0j1qRA9XqeK/ksLQ4LJfk8uTHHU78dGFn8Lg6sCekW1DZeTKX7bGS4oiptCO0hiY8r26TGbOU41dDZystGTSTFgb7LSlPVIbgfRaKoscwQr7pv+tKpGfJ1ckTgCeI5gfvagBQXMbNGC/ilekO/Z0hAvPkry/OVQ+cA9qE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 59BFC3858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737343247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p4F3S67bwWIRMgGaGQxsWkep6YI/+H2EAxdwzzQG7Jc=; b=eXMLhBmQsmcUYU6YZmwYe7PWucpHRTaGeYrPQh3NTa+ndDhA/6vl3H4fS6x9wF3ElezECW 0PPH8NcV3dQZpccCHNMtX3Ii4v2m0YQ2+EYYhMnQBTXpkqdpXZCYIDdLkSk/Mr7V/Hdc1F L0niVJ9e1044JYeXG2gldXpyktb2q1A= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-VUxDFfh8N6inAkTteFJW-g-1; Sun, 19 Jan 2025 22:20:45 -0500 X-MC-Unique: VUxDFfh8N6inAkTteFJW-g-1 X-Mimecast-MFC-AGG-ID: VUxDFfh8N6inAkTteFJW-g Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F093219560AB for <elfutils-devel@sourceware.org>; Mon, 20 Jan 2025 03:20:44 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.80.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 02147195608A; Mon, 20 Jan 2025 03:20:43 +0000 (UTC) From: Aaron Merey <amerey@redhat.com> To: elfutils-devel@sourceware.org Cc: Aaron Merey <amerey@redhat.com> Subject: [PATCH 01/15] Add eu_search_tree_init Date: Sun, 19 Jan 2025 22:20:27 -0500 Message-ID: <20250120032041.280173-1-amerey@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EZD3jQtILNT1-au4O8pa_wwxdC6z7m0EZZefv3qfDD8_1737343245 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org |
Series |
[01/15] Add eu_search_tree_init
|
|
Commit Message
Aaron Merey
Jan. 20, 2025, 3:20 a.m. UTC
* libdw/dwarf_begin_elf.c (dwarf_begin_elf): Initialize
eu_search_trees.
Signed-off-by: Aaron Merey <amerey@redhat.com>
---
libdw/dwarf_begin_elf.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
Hi Aaron, On Sun, 2025-01-19 at 22:20 -0500, Aaron Merey wrote: > * libdw/dwarf_begin_elf.c (dwarf_begin_elf): Initialize > eu_search_trees. I see the same are already eu_search_tree_fini in dwarf_end. So my only question is how this worked before? Whatever the answer is though, this looks good. Thanks, Mark > Signed-off-by: Aaron Merey <amerey@redhat.com> > > --- > libdw/dwarf_begin_elf.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libdw/dwarf_begin_elf.c b/libdw/dwarf_begin_elf.c > index e4826dda..c8292913 100644 > --- a/libdw/dwarf_begin_elf.c > +++ b/libdw/dwarf_begin_elf.c > @@ -580,6 +580,12 @@ dwarf_begin_elf (Elf *elf, Dwarf_Cmd cmd, Elf_Scn *scngrp) > return NULL; > } > rwlock_init (result->dwarf_lock); > + eu_search_tree_init (&result->cu_tree); > + eu_search_tree_init (&result->tu_tree); > + eu_search_tree_init (&result->split_tree); > + eu_search_tree_init (&result->macro_ops_tree); > + eu_search_tree_init (&result->files_lines_tree); > + > result->mem_stacks = 0; > result->mem_tails = NULL; >
Hi Mark, On Wed, Jan 22, 2025 at 10:23 AM Mark Wielaard <mark@klomp.org> wrote: > On Sun, 2025-01-19 at 22:20 -0500, Aaron Merey wrote: > > * libdw/dwarf_begin_elf.c (dwarf_begin_elf): Initialize > > eu_search_trees. > > I see the same are already eu_search_tree_fini in dwarf_end. So my only > question is how this worked before? I commented out these inits and re-ran the testsuite with thread safety and valgrind enabled (I did a run with memcheck and a run with helgrind). All tests passed, including the thread safety ones. I'm not sure what's going on but I have seen at least one test failure due to these missing inits. Possibly rwlock and tsearch/tfind have a chance to work on certain uninitialized values, e.g. if they happen to be 0? Aaron
diff --git a/libdw/dwarf_begin_elf.c b/libdw/dwarf_begin_elf.c index e4826dda..c8292913 100644 --- a/libdw/dwarf_begin_elf.c +++ b/libdw/dwarf_begin_elf.c @@ -580,6 +580,12 @@ dwarf_begin_elf (Elf *elf, Dwarf_Cmd cmd, Elf_Scn *scngrp) return NULL; } rwlock_init (result->dwarf_lock); + eu_search_tree_init (&result->cu_tree); + eu_search_tree_init (&result->tu_tree); + eu_search_tree_init (&result->split_tree); + eu_search_tree_init (&result->macro_ops_tree); + eu_search_tree_init (&result->files_lines_tree); + result->mem_stacks = 0; result->mem_tails = NULL;