Message ID | 20241106151639.90144-1-ant.v.moryakov@gmail.com |
---|---|
State | Rejected |
Headers |
Return-Path: <elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9553B3858D39 for <patchwork@sourceware.org>; Wed, 6 Nov 2024 15:16:58 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id E647F3858D20 for <elfutils-devel@sourceware.org>; Wed, 6 Nov 2024 15:16:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E647F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E647F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730906209; cv=none; b=Rc1q5kE1uftHQkLQj3GjYAx7MboeAqAMeyYRZ8W6Ipo2boPx6zIUODXezP8QjHK7xGQOOhEDdmlO8OHtNpUQldkUNppbgvgAraEz5CaS5cBhMs96icENeIvHYckdlnjfeliGGmX9fwgOEiO3b/rXYv9zCsiDzq0hznGhZU/GCJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730906209; c=relaxed/simple; bh=hDp3/+6zK7e3LMv2F5LWUYPGys2GTQvZNfsl57j1gOo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=W3rNfNNTf6W1Ed5VvkNgmXVFrQ2yF2ZQPAnNrw7Jmvs3sXu9PDMz/zNu4HN2JxPDqWGajOIFn7P2lT0SjxKHxsjrndzcf8CUQ9NC6DPYC0EtjdeC4qpIBziZLIYLLp6FOARCtOfAZemR2sC61FnxWsd6QrY1eyymWIGs0UDpYnk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-539f2b95775so7954499e87.1 for <elfutils-devel@sourceware.org>; Wed, 06 Nov 2024 07:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730906205; x=1731511005; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a69aUo3zwM64o4gDrg93S4qE9jsF5hQPh1Utxsv1RlI=; b=Ff/6AeaBSbmuiYzpqAw8AqzlQHUsu1YcGZgN4ZF0WVFjjcPJPjeAEPbts+SzbTCgJ0 7Pawkzr1ljayxx7VrD0c+xHcsfaEIcOjWywl3JSWnsIw/JsAAJh9EkHEciEov986qTdy iEgBg3an3en80LCVkfanihor+V28DTDrpnyQyIcRZfgqPiYLihvGbDXUgPChaSXgGAER X/vwONikfm3f5LofqrXnSFyR1Bld9fL6oeqrBQ6jjreo1wcaQFSo+u2L3ndoTaSfFyam JLZyQqTo4QeQYwreklf7iD5GXQhl6RJbHV+y5KZqVrYMgKCs8X3rTn+bw1rr7yp2b6Oh iHXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730906205; x=1731511005; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a69aUo3zwM64o4gDrg93S4qE9jsF5hQPh1Utxsv1RlI=; b=GUE3xvoHRQaxFtwsPIfH4mbp3VIWGWfymg6ehP3kpDYzbp0DTpz69pIhzc5yP7KHRC Jc3U7zYffooaRtLc9PS2LTiHQkcFVVp622LmAukAlS5HiQ28O6UCvokKZCdPaebqf9PU uwTQ6hcWP+iolTEHI2j7ovKTZvGo/3fgyx9K1UlmcSKgAurm1Tjf5PMBaIQflNMGvufE 5V6QncIbLXDKXR3fqaeH97LnGTYI/HptPNBmL5nt/qbuywP05nK9dZaOjeaRCTwcOGTb ZIyNnTPRuhdqWApT5pMpSHyOXGf1Z8nShdeK409xi8hXyX33I4eb7vF+VDKuRmAbwxr0 FbLg== X-Gm-Message-State: AOJu0YwWIdFVHfbgV6Gbe8IyEohv/RxWjw0uw1DcQTtLXefckCuJth2m CT0EyaFm/BHqSs+2tHAjDWB84C/o/i1BU2PYgj2xtg82WSKw+9zlQl3K4Lp8 X-Google-Smtp-Source: AGHT+IH51DAgzNG7L9nql0SZUASdrMNnl8gBJaAWf2FtLV+vJ4QBVgOttk/d6hWkpODgwSc2QuLN3w== X-Received: by 2002:a05:6512:3da8:b0:538:9e1e:b06f with SMTP id 2adb3069b0e04-53d65df23b5mr15743574e87.27.1730906204919; Wed, 06 Nov 2024 07:16:44 -0800 (PST) Received: from astra-student.rasu.local (109-252-122-202.nat.spd-mgts.ru. [109.252.122.202]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53c7bc9bde6sm2525527e87.70.2024.11.06.07.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 07:16:44 -0800 (PST) From: Anton Moryakov <ant.v.moryakov@gmail.com> To: elfutils-devel@sourceware.org Cc: Anton Moryakov <ant.v.moryakov@gmail.com> Subject: [PATCH] FIX #74: DEREF_OF_NULL.RET.STAT in ar.c Date: Wed, 6 Nov 2024 18:16:39 +0300 Message-Id: <20241106151639.90144-1-ant.v.moryakov@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org |
Series |
FIX #74: DEREF_OF_NULL.RET.STAT in ar.c
|
|
Commit Message
Anton Moryakov
Nov. 6, 2024, 3:16 p.m. UTC
Report of the static analyzer:
Pointer, returned from function 'elf_getarhdr'
at ar.c:498, may be NULL and is dereferenced at ar.c:500.
Corrections explained:
The issue is that the pointer returned by elf_getarhdr(subelf) may be NULL,
but it is directly dereferenced without a NULL check.
This fix adds a NULL check before using arhdr, preventing a potential null dereference.
This check ensures that the code safely handles cases when elf_getarhdr returns NULL,
avoiding unexpected crashes.
Found by RASU JSC.
Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
---
elfutils/src/ar.c | 6 ++++++
1 file changed, 6 insertions(+)
--
2.30.2
diff --git a/elfutils/src/ar.c b/elfutils/src/ar.c index d70f1f4..6ffd1eb 100644 --- a/elfutils/src/ar.c +++ b/elfutils/src/ar.c @@ -497,6 +497,11 @@ do_oper_extract (int oper, const char *arfname, char **argv, int argc, { Elf_Arhdr *arhdr = elf_getarhdr (subelf); + if (arhdr == NULL) + { + goto next; + } + if (strcmp (arhdr->ar_name, "/") == 0) { index_off = elf_getaroff (subelf);