Message ID | 20241101184936.48267-1-ant.v.moryakov@gmail.com |
---|---|
State | Rejected |
Headers |
Return-Path: <elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5E2B3858414 for <patchwork@sourceware.org>; Fri, 1 Nov 2024 18:49:58 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id CB85A3858D29 for <elfutils-devel@sourceware.org>; Fri, 1 Nov 2024 18:49:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB85A3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB85A3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730486990; cv=none; b=Y/3In0X4b3sAW4CWXCNKmTt+FhAmcU6ZCLLlcYBuZfycT7Q9rFryrH1d+Uewj/gwQcAYaaRTmQfqM3YJkvpUsRzfJi7hClYxu3L/5GJhLBmn4maLpCNp0PFTYDEdVvOs4l1yshhfYWxhNta5Jr3R7xh4UCPo6mXwm4PfQtXi4fo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730486990; c=relaxed/simple; bh=UxdnleCYbIh/JMzWKIMq5s8adSfxkrOkP1TY+fERrps=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=EL/OljB1W0VeeWHKFG80YX2bT5gqZMEwBnzrt5Wu8+dcnnePqgelwW4sOCEaPq7VTItTuEBonMCcWhy44oByhbzJ8pr3PLmaDSw2mrTcPVxMqk1ZWP/2TsDF4tFBHkqXYjIBe6TqF4csoMEE6+u6IY0pRKFozhLAdncjfTrvtKU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-539f84907caso2498680e87.3 for <elfutils-devel@sourceware.org>; Fri, 01 Nov 2024 11:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730486987; x=1731091787; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ONX0CWh+BmFsov5k0jmKckMvxrf1V+hd6yUwtgGD20s=; b=HSp5JEU3lriWQDAcxn63cBndL9ZFj6qIoq9zBmpZjRp1Du0n5FbyMM+W0/ZMhE7RJN yNSPtydQviNhYh23b49l+nPz5SxXFabf2zEZQ4lBDgad1H4asJchG35hK1LRcQ6j25ev JNwF3uLrNPFMK3tNSFvp/pTBc/qIujVzTRwn4q0t+BOwa8Ay5mgZlrgOJqj5YpFLBY1J NL8M6fzeEkh+hmGtWc8K9icQMINP6N+dnEaCtWeng3ObhsjvRgNcUvcLFwYK9tTOtNaP SSbwKjYNHKGyGHWDOnaf26WssBLx/Ae3zcXTAVQiHth1qjx+tzGzI2Jg/+8Ju3r8nmTh J+1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730486987; x=1731091787; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ONX0CWh+BmFsov5k0jmKckMvxrf1V+hd6yUwtgGD20s=; b=MTaA58Qg0K7RiQXtSuwE0z5JoSJwAIuNs7gF6r2wEFFxShakjUC01DgZprr9r4X7wc beNUfCfUIodisp7sU0aVM7TyS6RREXI00J2HEMoAgni6+Oc7mEU6zY1MKbV5ChBCxB2Q Y9y6MEtGPhhOUxrD1CAJzd121370fUaX+fMx657WGCaFB6MeDMAwIJBdZc/QGlpEpyV8 di+Y3cGySif8etB63oQy0x3AG1juEnQWXDCyu7pKW+UX+/3qSulwRapR/hRiRRFkfbbV HB9Gg0F9HZ2Oj29C6wgNFNndZfNGgVRJIXTHxajV+hMrAzCqNyh/lF8K0MvWN3NUjEAh id3w== X-Gm-Message-State: AOJu0YzWpxNfHqPEmIxQ2FSqE5zdkonnEkqIZ+nKQFrSn1Z6VMMcM9ww Dz+3M0o+GmnkvNKX+Vvf1RB+tYSJ3uuvuEAaIvsi02mycne9GCJ1mFIsTyiYJwU= X-Google-Smtp-Source: AGHT+IHROHz4WajRvNzilOlYrPiHNjf9dbAd+jZLiI6BfKV30QKUloUHh8Qa0+5gBzEMGlsrmxV2eg== X-Received: by 2002:a05:6512:3e14:b0:539:8ad5:5093 with SMTP id 2adb3069b0e04-53b34a1943amr10186109e87.35.1730486986508; Fri, 01 Nov 2024 11:49:46 -0700 (PDT) Received: from astra-student.rasu.local (109-252-122-202.nat.spd-mgts.ru. [109.252.122.202]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53c7bde3ac2sm636376e87.294.2024.11.01.11.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 11:49:46 -0700 (PDT) From: Anton Moryakov <ant.v.moryakov@gmail.com> To: elfutils-devel@sourceware.org Cc: Anton Moryakov <ant.v.moryakov@gmail.com> Subject: [PATCH] Fix potential handle leak by ensuring dlclose is always called on debuginfod_so Date: Fri, 1 Nov 2024 21:49:36 +0300 Message-Id: <20241101184936.48267-1-ant.v.moryakov@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org |
Series |
Fix potential handle leak by ensuring dlclose is always called on debuginfod_so
|
|
Commit Message
Anton Moryakov
Nov. 1, 2024, 6:49 p.m. UTC
first report
HANDLE_LEAK.EX The handle 'debuginfod_so' is created at debuginfod-client.c:104 by calling function 'dlopen' and lost at debuginfod-client.c:129.
second report
HANDLE_LEAK.EX The handle 'debuginfod_so' is created at debuginfod-client.c:107 by calling function 'dlopen' and lost at debuginfod-client.c:129.
In __libdwfl_debuginfod_init, added dlclose(debuginfod_so) after symbol loading,
ensuring that the handle is released whether symbols are successfully loaded or not.
This prevents potential handle leak reported by static analysis.
Found by RASU JSC.
Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
---
elfutils/libdwfl/debuginfod-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi - > first report > HANDLE_LEAK.EX The handle 'debuginfod_so' is created at debuginfod-client.c:104 by calling function 'dlopen' and lost at debuginfod-client.c:129. > second report > HANDLE_LEAK.EX The handle 'debuginfod_so' is created at debuginfod-client.c:107 by calling function 'dlopen' and lost at debuginfod-client.c:129. > [...] > This prevents potential handle leak reported by static analysis. > > Found by RASU JSC. > > Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com> NO. The shared library handle is held deliberately, so that subsequent dlsym'd function calls can work. Please stop sending junk patches. - FChE
diff --git a/elfutils/libdwfl/debuginfod-client.c b/elfutils/libdwfl/debuginfod-client.c index ee604ad..b29c455 100644 --- a/elfutils/libdwfl/debuginfod-client.c +++ b/elfutils/libdwfl/debuginfod-client.c @@ -125,7 +125,7 @@ __libdwfl_debuginfod_init (void) fp_debuginfod_find_executable = NULL; fp_debuginfod_find_debuginfo = NULL; fp_debuginfod_end = NULL; - dlclose (debuginfod_so); } + dlclose (debuginfod_so); } }