tests: run-debuginfod-seekable.sh depends on LZMA and DEBUGINFOD

Message ID 20241022114822.1647565-1-mark@klomp.org
State Committed
Headers
Series tests: run-debuginfod-seekable.sh depends on LZMA and DEBUGINFOD |

Commit Message

Mark Wielaard Oct. 22, 2024, 11:48 a.m. UTC
  The run-debuginfod-seekable.sh test would run (and fail) if lzma
support was enabled, but debuginfod wasn't build. Only run it when
both are available.

     * tests/Makefile.am (TESTS): Add run-debuginfod-seekable.sh if
     DEBUGINFOD and LZMA.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 tests/Makefile.am | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
  

Comments

Aaron Merey Oct. 22, 2024, 1:19 p.m. UTC | #1
On Tue, Oct 22, 2024 at 7:48 AM Mark Wielaard <mark@klomp.org> wrote:
>
> The run-debuginfod-seekable.sh test would run (and fail) if lzma
> support was enabled, but debuginfod wasn't build. Only run it when
> both are available.
>
>      * tests/Makefile.am (TESTS): Add run-debuginfod-seekable.sh if
>      DEBUGINFOD and LZMA.
>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
>  tests/Makefile.am | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 76f1682fa952..6dc255a9b4d0 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -228,7 +228,7 @@ export ELFUTILS_DISABLE_DEMANGLE = 1
>  endif
>
>  if LZMA
> -TESTS += run-readelf-s.sh run-dwflsyms.sh run-debuginfod-seekable.sh
> +TESTS += run-readelf-s.sh run-dwflsyms.sh
>  endif
>
>  if HAVE_ZSTD
> @@ -277,6 +277,9 @@ TESTS += run-srcfiles-self.sh \
>          run-debuginfod-client-profile.sh \
>          run-debuginfod-find-metadata.sh \
>          run-debuginfod-longsource.sh
> +if LZMA
> +TESTS += run-debuginfod-seekable.sh
> +endif
>  endif
>  if !OLD_LIBMICROHTTPD
>  # Will crash on too old libmicrohttpd
> --
> 2.47.0
>

Thanks Mark, LGTM.

Aaron
  
Mark Wielaard Oct. 23, 2024, 10:08 p.m. UTC | #2
Hi Aaron,

On Tue, Oct 22, 2024 at 09:19:26AM -0400, Aaron Merey wrote:
> On Tue, Oct 22, 2024 at 7:48 AM Mark Wielaard <mark@klomp.org> wrote:
> >
> > The run-debuginfod-seekable.sh test would run (and fail) if lzma
> > support was enabled, but debuginfod wasn't build. Only run it when
> > both are available.
> >
> >      * tests/Makefile.am (TESTS): Add run-debuginfod-seekable.sh if
> >      DEBUGINFOD and LZMA.
> 
> Thanks Mark, LGTM.

Pushed,

Mark
  

Patch

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 76f1682fa952..6dc255a9b4d0 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -228,7 +228,7 @@  export ELFUTILS_DISABLE_DEMANGLE = 1
 endif
 
 if LZMA
-TESTS += run-readelf-s.sh run-dwflsyms.sh run-debuginfod-seekable.sh
+TESTS += run-readelf-s.sh run-dwflsyms.sh
 endif
 
 if HAVE_ZSTD
@@ -277,6 +277,9 @@  TESTS += run-srcfiles-self.sh \
 	 run-debuginfod-client-profile.sh \
 	 run-debuginfod-find-metadata.sh \
 	 run-debuginfod-longsource.sh
+if LZMA
+TESTS += run-debuginfod-seekable.sh
+endif
 endif
 if !OLD_LIBMICROHTTPD
 # Will crash on too old libmicrohttpd