Message ID | 20241010102559.9162-2-mcpratt@pm.me |
---|---|
State | Committed |
Headers |
Return-Path: <elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DA4D3857341 for <patchwork@sourceware.org>; Thu, 10 Oct 2024 10:27:37 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by sourceware.org (Postfix) with ESMTPS id B9C783857C7A for <elfutils-devel@sourceware.org>; Thu, 10 Oct 2024 10:27:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9C783857C7A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pm.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9C783857C7A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.70.40.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728556024; cv=none; b=xIrsWj542vO7jp7aLXIqFb50MlT92G2f1tjD7bU4GZ17GQcuObpwoIQ4Ik3fYyg/RpD6HXibMwcYICFOt7MdKMolNvUMIa+wh/vmpYEKOHdnkAZdTpZUkRRTlieen+ozQKVMF/XcBrDBFiKdsZgJ+UxiNR5PU4mehluJ32RUJWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728556024; c=relaxed/simple; bh=8CU0dczp7yNtYZ2gmicGYM29f/tY+JqhZN9/8v2GtNE=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=uyF+6wNVffv60vPdZ6HUt+PlKIosxDM6SiyKndam35KbsPkWszMC1vr3zp03uj75gBnKs/yQJYrpptudf/0R1DxQZY6/yvKua9K1ycSiAC21QRXHL8GFz17mY0q4yH1k2L5ks0mjrOWSaCNTLXrg+XO2IgYE/kVr+szLdaK7Tx8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1728556020; x=1728815220; bh=Nh0/ur/MPT+DHbcpsVX4a+J8K/JeDBLKxpKz2Amxuo8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=SpUkA1XToR2fGJWyencRPLXPrtXLvJP2GeVAgpiaSSgApmuTPkqHXYx3hk4ONZKlo 3gZQqfB0zbIz30EwVly2jRAIShOvXwVrHPEKnnuukszE9s2UYKL1/vJtAYJjCq7ded 8vKRvBUvIqnFK55WGel7K9QCONiFO80w2WFaOvXJe6XNCc/Yeih1vDho9FHEuK25JT qgaWrJwY1GKXtCFeZIznOYvXB+ebS06x/5YYeoNt8ikFFotHjMvo8y6E1E0GTWIg9u L14z72NRyo+rIAEgIifoZfuw0Hz34EOsc13mUvsQXIx4e3Qzs/UJjS5LY9A0WUgrjV 2Foi5S7BiDoIw== Date: Thu, 10 Oct 2024 10:26:54 +0000 To: elfutils-devel@sourceware.org From: Michael Pratt <mcpratt@pm.me> Cc: Michael Pratt <mcpratt@pm.me> Subject: [PATCH 1/6] lib: Add missing config.h include to next_prime.c Message-ID: <20241010102559.9162-2-mcpratt@pm.me> In-Reply-To: <20241010102559.9162-1-mcpratt@pm.me> References: <20241010102559.9162-1-mcpratt@pm.me> Feedback-ID: 27397442:user:proton X-Pm-Message-ID: c97f19b3e7bf38a14fdb14911afc9a1c5535cfbc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_INFOUSMEBIZ, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org |
Series |
Various portability fixes and organization
|
|
Commit Message
Michael Pratt
Oct. 10, 2024, 10:26 a.m. UTC
This is the last remaining C source file as of this commit
without the standard conditional inclusion of config.h
as the very first header.
* lib/next_prime.c: add missing config.h header.
Signed-off-by: Michael Pratt <mcpratt@pm.me>
---
lib/next_prime.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
Hi Michael, On Thu, Oct 10, 2024 at 10:26:54AM +0000, Michael Pratt wrote: > This is the last remaining C source file as of this commit > without the standard conditional inclusion of config.h > as the very first header. > > * lib/next_prime.c: add missing config.h header. Looks good and is more consistent. Pushed. There isn't much code in this file. What kind of build issue are you seeing without this? Does config.h contain some construct that affects the build of this file? Thanks, Mark
Hi Mark, On Monday, October 14th, 2024 at 16:38, Mark Wielaard <mark@klomp.org> wrote: > > > There isn't much code in this file. What kind of build issue are you > seeing without this? Does config.h contain some construct that affects > the build of this file? Like I mentioned in the cover letter, we incorporate gnulib to the build, so the build simply fails due to their strict requirements of including config.h before including any other header that gnulib provides. I'm not familiar with the exact reason for this requirement, but I'm sure it could potentially cause a problem if one overrides it. -- MCP
diff --git a/lib/next_prime.c b/lib/next_prime.c index f2c921e3..97c425e1 100644 --- a/lib/next_prime.c +++ b/lib/next_prime.c @@ -27,6 +27,10 @@ the GNU Lesser General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. */ +#ifdef HAVE_CONFIG_H +# include <config.h> +#endif + #include <stddef.h>