Message ID | 20240918085807.79806-1-maks.mishinFZ@gmail.com |
---|---|
State | Committed |
Headers |
Return-Path: <elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83DD43858C33 for <patchwork@sourceware.org>; Wed, 18 Sep 2024 08:58:26 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 438743858D26 for <elfutils-devel@sourceware.org>; Wed, 18 Sep 2024 08:58:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 438743858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 438743858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726649896; cv=none; b=qE41m+y1VRo+GpLeA3vOOYPlxikRbRABOyfbK00V1w/WmNZ5k4hgZ8QRo6f9Y0u0bskfk/5U5lvG0pPbyU0mFRVkGZjt7M2yZ1Um9y15riRf4PujrI1A0InqoiuJN/i31UPXC4EB8M9qsUW4Rw0IvlSb7En/2fsLeAWn+f4G6ls= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726649896; c=relaxed/simple; bh=gNoFeGEloU23lmdkdROzKnt7ga2hpyG7bSEyAUzzmew=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=mN3VPQzX695y8gGI+b7+jKDaUbrP1YnDcLtgB5iBZxbH88gMo9nDlRykJPwJ0e/DMDuhrwQaWXNf4Mej51wF4G0nw6kOAm1MZWKrWqpoln8FKMfmvMFRDuHuCLnLB3BWqQgvtZ208bLShEg6MVpv+SMGgMozB7g0/1zxO4I/GBk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-5365a9574b6so8107122e87.1 for <elfutils-devel@sourceware.org>; Wed, 18 Sep 2024 01:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726649893; x=1727254693; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0CaMgIynEoJ+LHjpDwRBF/b77+iHA3BZdYTUYea/8q0=; b=A8W9p5SsgI1XX7ryR4rnq9/+6cLVfHR1xEJbv6qIZ0RiZWCitZRVBZC3Iau72K5uqH K/OuHIRr9GmksTV4IpvR4U20BLgcJFaxawwXxt1TATf6mo1k7X/D27mZGz7IH4P9qLuq jUd6WCHLlhdknI66no/HvGdMxZgZgvXq3hsceYvj7hA9r6QxsBfGSd/R9NnBaOx6aZ4r dW9SSoNp2zcIdfwklGo4PKcpdzBm53JYh7Nw7wbpejufnwXlGaxsz/4DQKfTbsJLPaso qvk/LKQNPx1zdRbT2cSYjybdg0A2LxdYPx8hFr3NQl2uzfyFkhQKdX6TmVNrWCq+Jj9z BPVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726649893; x=1727254693; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0CaMgIynEoJ+LHjpDwRBF/b77+iHA3BZdYTUYea/8q0=; b=bGzbgncOHL0cUE95xZ4ZG5ZGYdBFerpgf0ZesGykZ9q3PRXIC5PSRcrJeAoHobf7Xz 7/GdIPDFJDiK6qY4svPSimTixdRqSNYSNcJYht8ROxIQOUU7uiD1NEZzXEuelOgQ3dV7 BVjCT6Z9J/QX+alJCTXp3GLai6QBcah1a2/VmcG6xVLlTE92+KucwydMLTrb30FitpWW ERxgIaQsCMFhAilPbT3VGdTnKW3U2zJM+wk8dAzpj7oqBp6laL+jFYabPkIt96wVFH+9 o5Cxw8RlNKkGRzOWs9ApYKe8oagAraHlX/KLyDrBR9wU0I60bE8CPhH9BOB5kVIacPru btIw== X-Gm-Message-State: AOJu0YwOZl3/FXzFe64h6uaHvXpWzAkkGWhnS5jfDITD7Y1vxWhIHpiK ZSeCAyZTBY5d7ohWMqTAXLfcKhSP6WLVtfNbeqXZp8cYAXdJ1Wx/2CRRVw== X-Google-Smtp-Source: AGHT+IG4QDpcLBkyvkyOGu74UHj5T6RLqmcrc+yzcXL2UnnNFAjSezGL6qKwBdvy5BWBkpmS3OMXYA== X-Received: by 2002:a05:6512:3189:b0:533:4785:82ab with SMTP id 2adb3069b0e04-5367feb9598mr12996419e87.1.1726649892947; Wed, 18 Sep 2024 01:58:12 -0700 (PDT) Received: from dev.rasu.local ([212.22.67.162]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5368704db16sm1462828e87.107.2024.09.18.01.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 01:58:11 -0700 (PDT) From: Maks Mishin <maks.mishinfz@gmail.com> X-Google-Original-From: Maks Mishin <maks.mishinFZ@gmail.com> To: elfutils-devel@sourceware.org Cc: Maks Mishin <maks.mishinFZ@gmail.com> Subject: [PATCH] elflint: Fix memory leak in check_gnu_hash function Date: Wed, 18 Sep 2024 11:58:07 +0300 Message-Id: <20240918085807.79806-1-maks.mishinFZ@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces~patchwork=sourceware.org@sourceware.org |
Series |
elflint: Fix memory leak in check_gnu_hash function
|
|
Commit Message
Maks Mishin
Sept. 18, 2024, 8:58 a.m. UTC
Dynamic memory, referenced by 'collected', is allocated at elflint.c:2235
and lost at elflint.c:2296.
Found by RASU JSC with SVACE.
Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
src/elflint.c | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Maks, On Wed, Sep 18, 2024 at 4:58 AM Maks Mishin <maks.mishinfz@gmail.com> wrote: > > Dynamic memory, referenced by 'collected', is allocated at elflint.c:2235 > and lost at elflint.c:2296. > > Found by RASU JSC with SVACE. > > Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com> > --- > src/elflint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/elflint.c b/src/elflint.c > index e56e1465..cdc6108d 100644 > --- a/src/elflint.c > +++ b/src/elflint.c > @@ -2293,6 +2293,7 @@ section [%2d] '%s': hash value for symbol %u in chain for bucket %zu wrong\n"), > section [%2d] '%s': mask index for symbol %u in chain for bucket %zu wrong\n"), > idx, section_name (ebl, idx), symidx, > cnt - (4 + bitmask_words)); > + free (collected.p32); > return; > } > if (classbits == 32) > -- > 2.34.1 > Thanks, merged as commit b47bdee08a1607 Aaron
Thanks for the feedback! пт, 20 сент. 2024 г. в 19:07, Aaron Merey <amerey@redhat.com>: > Hi Maks, > > On Wed, Sep 18, 2024 at 4:58 AM Maks Mishin <maks.mishinfz@gmail.com> > wrote: > > > > Dynamic memory, referenced by 'collected', is allocated at elflint.c:2235 > > and lost at elflint.c:2296. > > > > Found by RASU JSC with SVACE. > > > > Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com> > > --- > > src/elflint.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/elflint.c b/src/elflint.c > > index e56e1465..cdc6108d 100644 > > --- a/src/elflint.c > > +++ b/src/elflint.c > > @@ -2293,6 +2293,7 @@ section [%2d] '%s': hash value for symbol %u in > chain for bucket %zu wrong\n"), > > section [%2d] '%s': mask index for symbol %u in chain for bucket %zu > wrong\n"), > > idx, section_name (ebl, idx), symidx, > > cnt - (4 + bitmask_words)); > > + free (collected.p32); > > return; > > } > > if (classbits == 32) > > -- > > 2.34.1 > > > > Thanks, merged as commit b47bdee08a1607 > > Aaron > > -- С уважением, Мишин Максим Александрович +7 (915) 958-41-07 maks.mishinFZ@gmail.com
diff --git a/src/elflint.c b/src/elflint.c index e56e1465..cdc6108d 100644 --- a/src/elflint.c +++ b/src/elflint.c @@ -2293,6 +2293,7 @@ section [%2d] '%s': hash value for symbol %u in chain for bucket %zu wrong\n"), section [%2d] '%s': mask index for symbol %u in chain for bucket %zu wrong\n"), idx, section_name (ebl, idx), symidx, cnt - (4 + bitmask_words)); + free (collected.p32); return; } if (classbits == 32)