diff mbox series

segment: Fix memory leak in insert()

Message ID 20240402203250.11772-1-maks.mishinFZ@gmail.com
State Rejected
Headers
Series segment: Fix memory leak in insert() |

Commit Message

Maks Mishin April 2, 2024, 8:32 p.m. UTC 
  Dynamic memory, referenced by 'naddr', is allocated at segment.c:66
by calling function 'realloc' and lost at segment.c:92.

Found by RASU JSC.

Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
 libdwfl/segment.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Wielaard April 3, 2024, 8:34 p.m. UTC | #1 
On Tue, Apr 02, 2024 at 11:32:50PM +0300, Maks Mishin wrote:
> Dynamic memory, referenced by 'naddr', is allocated at segment.c:66
> by calling function 'realloc' and lost at segment.c:92.

It isn't lost, it is assigned to dwfl->lookup_addr at segment.c:77

> 
> Found by RASU JSC.
> 
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
>  libdwfl/segment.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libdwfl/segment.c b/libdwfl/segment.c
> index f6a3e84e..618c14e6 100644
> --- a/libdwfl/segment.c
> +++ b/libdwfl/segment.c
> @@ -89,6 +89,7 @@ insert (Dwfl *dwfl, size_t i, GElf_Addr start, GElf_Addr end, int segndx)
>  	      return true;
>  	    }
>  	}
> +	    free (naddr);
>      }
>  
>    if (unlikely (i < dwfl->lookup_elts))
> -- 
> 2.30.2
>
diff mbox series

Patch

diff --git a/libdwfl/segment.c b/libdwfl/segment.c
index f6a3e84e..618c14e6 100644
--- a/libdwfl/segment.c
+++ b/libdwfl/segment.c
@@ -89,6 +89,7 @@  insert (Dwfl *dwfl, size_t i, GElf_Addr start, GElf_Addr end, int segndx)
 	      return true;
 	    }
 	}
+	    free (naddr);
     }
 
   if (unlikely (i < dwfl->lookup_elts))