From patchwork Mon Apr 1 17:25:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maks Mishin X-Patchwork-Id: 87892 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1BC853858C35 for ; Mon, 1 Apr 2024 17:25:32 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 8FC823858D20 for ; Mon, 1 Apr 2024 17:25:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FC823858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FC823858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711992322; cv=none; b=gmioCy1Q/D3X+2FWR5HQxobtk87+pvX8BRYFpaGGiDek0hWUPeT8YPllDDHnp2j1nLsHWRRgaEdnrzHiwc2zUyS9WKMUEO/T9lF7xQFraoqLJyWxkbS527IY6TUD3agWnX3d2+ztN7XtZ8J9D2ShINauS6pMg0rsTrXDF9KJ8/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711992322; c=relaxed/simple; bh=VWeN2PWk8iBuoitBTiXkngz+D3iWKOIx96Mpak6S24A=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=lrpT3TSL4w6PmT+LhTDVlbixIp2CQDw+rRS8dKqmcGSRNIxKO2VEL0oyz90FyXyDrTWTHz0Tvh9hbuMVNh+5wHwZYeziPS2rDj+nfdWtfiszCxfmnUH2Z645u9AZi37JBMYE6pdbT8kyCLtQ96jbu0baK6wMSIHHd5AffKARBko= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-513cf9bacf1so5328061e87.0 for ; Mon, 01 Apr 2024 10:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711992319; x=1712597119; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/GtfVFnShGGLmIrtns5Ml7Awy0N7miehLNbp98XPt5M=; b=isaCyYmTbhYIc1dfdBoNYrX4rF78a0dYk+0xc+94X5liubqGtdif//UDqsaukif93T ogOcy15HxGirU4Fg38HRnlB6CVG1S8GKs/zEIHbVbhdgFm8/uJpjDRY9bytgE6Jn0TR+ cTbS3bXpF1hKdWwaiVdLFFNUw16C3lszGekMVyrvFAsA6HliD65KqnyhjGSt/Pbn+n/n N7u6FKCR+Hwo+L9ZL1SzpX0NtnEBkiwGkwAe8ncvem4U92RKpc/9s4w0zFVsYkWNj4DB fqcqFPlhikO+GUeYV6cjtpTRzChYcrbo/dSbKSyXAYGCdn2BlG++Fgrx2ts1Du7J/LYF gVnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711992319; x=1712597119; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/GtfVFnShGGLmIrtns5Ml7Awy0N7miehLNbp98XPt5M=; b=YUbpzNMkccJ0z0imzE8GbX5v5Jd0+HRXu42bDt+niKH0NOyVosF7DgEwRWEpNzvCAZ 4PlHdFE2r5uFOFvNJ1N5txNNTOP1NAx269TntJUQwlTO62SSB8e6UVqKgoSrEAZQc3Cz oZ/3he8NqpXZJ8rsyfk3E//F0y6mvHqynovkexDdfwH7CfrqKH0R9HhnLsiBL2k9Ql6r PbpYet8NjmtU9PA7VljcIlUW0ZdfdJMLAL9f99UYA0A91/np3x0pFwySx3IjW5oMC9kD KfmaOidcsLw8Gs7Iv4hcjxGVeVU+cnQKpwQm9mONJygA+ARgaO2QnLp/udbzujpQ0mqm 7CZQ== X-Gm-Message-State: AOJu0YzNTtlO9C1Fdq1OQGNVYpAvK4CcoOsuVWgP2KRM5V+FA1nINasG 63LwmTGdtQIeDpTcvv1vor7w9rwMDYGYjQfXVeTM1YWZosm6PDSldImR9g3W X-Google-Smtp-Source: AGHT+IEcUkI5LjWvTrFgOzLZX+HR+X5ODo8QC4EKF88ND2H+fz/SLGMqnNdcv//MsYOQ7KF4Sbzj3Q== X-Received: by 2002:ac2:5f72:0:b0:515:cb72:4c0c with SMTP id c18-20020ac25f72000000b00515cb724c0cmr5228390lfc.43.1711992318399; Mon, 01 Apr 2024 10:25:18 -0700 (PDT) Received: from mishin.sarov.local (95-37-71-41.dynamic.mts-nn.ru. [95.37.71.41]) by smtp.gmail.com with ESMTPSA id o15-20020a198c0f000000b00515ac340c4asm1488935lfd.179.2024.04.01.10.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 10:25:17 -0700 (PDT) From: Maks Mishin X-Google-Original-From: Maks Mishin To: elfutils-devel@sourceware.org Cc: Maks Mishin Subject: [PATCH] segment: Fix memory leak in insert() Date: Mon, 1 Apr 2024 20:25:13 +0300 Message-Id: <20240401172513.4212-1-maks.mishinFZ@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org Dynamic memory, referenced by 'naddr', is allocated at segment.c:66 by calling function 'realloc' and lost at segment.c:92. Found by RASU JSC. Signed-off-by: Maks Mishin --- libdwfl/segment.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libdwfl/segment.c b/libdwfl/segment.c index f6a3e84e..5d6053e4 100644 --- a/libdwfl/segment.c +++ b/libdwfl/segment.c @@ -89,6 +89,8 @@ insert (Dwfl *dwfl, size_t i, GElf_Addr start, GElf_Addr end, int segndx) return true; } } + if (naddr != NULL) + free(naddr); } if (unlikely (i < dwfl->lookup_elts))