srcfiles: fix unused variable BUFFER_SIZE

Message ID 20240319103433.51386-1-jose.quaresma@foundries.io
State Committed
Headers
Series srcfiles: fix unused variable BUFFER_SIZE |

Commit Message

Jose Quaresma March 19, 2024, 10:34 a.m. UTC
  The const variable BUFFER_SIZE is used only on the zip_files
function witch is only available with LIBARCHIVE.

| ../../elfutils-0.191/src/srcfiles.cxx:81:18: error: unused variable 'BUFFER_SIZE' [-Werror,-Wunused-const-variable]
|    81 | constexpr size_t BUFFER_SIZE = 8192;
|       |                  ^~~~~~~~~~~

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
---
 src/srcfiles.cxx | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Frank Ch. Eigler March 19, 2024, 11:07 a.m. UTC | #1
Hi -

> The const variable BUFFER_SIZE is used only on the zip_files
> function witch is only available with LIBARCHIVE.

Thanks, merged as obvious.

- FChE
  

Patch

diff --git a/src/srcfiles.cxx b/src/srcfiles.cxx
index 892737cc..09d50f8d 100644
--- a/src/srcfiles.cxx
+++ b/src/srcfiles.cxx
@@ -78,7 +78,9 @@  ARGP_PROGRAM_VERSION_HOOK_DEF = print_version;
 /* Bug report address.  */
 ARGP_PROGRAM_BUG_ADDRESS_DEF = PACKAGE_BUGREPORT;
 
+#ifdef HAVE_LIBARCHIVE
 constexpr size_t BUFFER_SIZE = 8192;
+#endif
 
 /* Definitions of arguments for argp functions.  */
 static const struct argp_option options[] =