Message ID | 20240319103433.51386-1-jose.quaresma@foundries.io |
---|---|
State | Committed |
Headers |
Return-Path: <elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1B423858402 for <patchwork@sourceware.org>; Tue, 19 Mar 2024 10:35:07 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 3A7073858CD1 for <elfutils-devel@sourceware.org>; Tue, 19 Mar 2024 10:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A7073858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A7073858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710844498; cv=none; b=fF6soqxlsf6p+V8SSZ9a8x+PhYBjw0M8r01XlTzOTIggBzqERLwjbAKSRBAwEKzF0K0xpE/VAWqpUtuR149hqckTrbqfMscnFcu9aLYNDCEQz4HJRG0RlWWrxl2jgNtqimJaehz7ZTxzEl5aHLBnB0PEJnSKQCLf9xatvBVHMQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710844498; c=relaxed/simple; bh=aorflexpaeNJceFRaTR2vAIHoLiS72pZe/4VcQ5GZUU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=I2aIQguggFjSOkR88G877U119tiD72BsnKvDOakglC0EG/eJLCUFo5Jynv9bYqeZ2VZbwXYLRqxOYJLTKqokIcLtoC8idLAwHHHdYgCU39S0KR3BjzuZdimQ/g3FHPUjtuodl9n5BUiYRvpvEkdF1EWfOytq8XhBTnUImGj008c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-41462295004so6140855e9.0 for <elfutils-devel@sourceware.org>; Tue, 19 Mar 2024 03:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710844486; x=1711449286; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7E5b6KAMFyGTTPH3wzgfmfWG7zAQUV5oBLlR+n+2ly4=; b=OGDO3Z3+E4MTT3+ZPvrSTxolVBBqimWQCcnYMcKpnmIJxe42MeUe1MVCxiu9oU2V9c IQa9WpOmlSpeTVRVXxdJGcpa4K8ZAMPzcTphoeALYQON4nJvLxWZtdOHXD8AFgaroyvI 8YJjGvZeOFy/yzSdcxeXnKBBGdyAqmG96WjSyXV9Aw9yCKHmLfJFBClaMDgj4u1IoB82 PNe3sFbirPIY1Ts+1CCXYk6FKZgAE8+QPVZ3cPaly5myF/upoXo9FaXGBVtH3TeiiYTb 00X4gYoHqWrpxkeSjgSeiJtlgp3EVLJBSKF4aMEB1twsI6H1iMZISA9IFsczz5/MhMvb SEGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710844486; x=1711449286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7E5b6KAMFyGTTPH3wzgfmfWG7zAQUV5oBLlR+n+2ly4=; b=rK0/W1u6IK4T+BJ1I/anIUaKExNSsG5Mx1BwBFNINvvKaxliM2vEKiMrhJvufhHbUr 8k0aedbrvB4VvdtSDch5wi40x4cyV/ARC3USWnCG04vb4P59ILQLjnE0yom5kEa8t7cj oye3NkEXD/03Mlud7Yu/j/Q/gY01ew4dmK0jy4/4x1gV1W7H1P9imekPyiok6VP0JLjl 7HCDMt/MPfkHETM8He61i4XPbJF0m/3ewd+Hx18eXLKMVK7F/eRfy/uk3d0HuxpUuj94 tEg8377NgauHMp0XfYG61o+j2utStVCCcA9JB45uhQNkx9GrZDMehQ1AXcYOd3TmfaQP kn8Q== X-Gm-Message-State: AOJu0Yz0rSfrLzf11t2/4VmFLHbL4KHP7Ah/qtaZrdqLVGm6MejJvTLh mMHUPF69wl5woJBb+Dms06Z3z8Bg2Uj96iRFboVdGONNl1LUO3S3GYNZ5JNd X-Google-Smtp-Source: AGHT+IGe6C4NTCKtE865/JShzaKkLo+or+aTGFgoNRvJt7hfWfeTxaobrPRWJ4u/yUv1KMJN4xEjkg== X-Received: by 2002:a05:600c:4ec7:b0:413:ca0:5cd1 with SMTP id g7-20020a05600c4ec700b004130ca05cd1mr11016308wmq.39.1710844486410; Tue, 19 Mar 2024 03:34:46 -0700 (PDT) Received: from fio.lan (bl15-243-112.dsl.telepac.pt. [188.80.243.112]) by smtp.gmail.com with ESMTPSA id n20-20020a05600c501400b00414112a6159sm5842179wmr.44.2024.03.19.03.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 03:34:45 -0700 (PDT) From: Jose Quaresma <quaresma.jose@gmail.com> X-Google-Original-From: Jose Quaresma <jose.quaresma@foundries.io> To: elfutils-devel@sourceware.org Cc: Jose Quaresma <jose.quaresma@foundries.io> Subject: [PATCH] srcfiles: fix unused variable BUFFER_SIZE Date: Tue, 19 Mar 2024 10:34:33 +0000 Message-ID: <20240319103433.51386-1-jose.quaresma@foundries.io> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Post: <mailto:elfutils-devel@sourceware.org> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org |
Series |
srcfiles: fix unused variable BUFFER_SIZE
|
|
Commit Message
Jose Quaresma
March 19, 2024, 10:34 a.m. UTC
The const variable BUFFER_SIZE is used only on the zip_files
function witch is only available with LIBARCHIVE.
| ../../elfutils-0.191/src/srcfiles.cxx:81:18: error: unused variable 'BUFFER_SIZE' [-Werror,-Wunused-const-variable]
| 81 | constexpr size_t BUFFER_SIZE = 8192;
| | ^~~~~~~~~~~
Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
---
src/srcfiles.cxx | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi - > The const variable BUFFER_SIZE is used only on the zip_files > function witch is only available with LIBARCHIVE. Thanks, merged as obvious. - FChE
diff --git a/src/srcfiles.cxx b/src/srcfiles.cxx index 892737cc..09d50f8d 100644 --- a/src/srcfiles.cxx +++ b/src/srcfiles.cxx @@ -78,7 +78,9 @@ ARGP_PROGRAM_VERSION_HOOK_DEF = print_version; /* Bug report address. */ ARGP_PROGRAM_BUG_ADDRESS_DEF = PACKAGE_BUGREPORT; +#ifdef HAVE_LIBARCHIVE constexpr size_t BUFFER_SIZE = 8192; +#endif /* Definitions of arguments for argp functions. */ static const struct argp_option options[] =