Message ID | 20230206222513.1773039-11-iii@linux.ibm.com |
---|---|
State | Superseded |
Headers |
Return-Path: <elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62B6A3857803 for <patchwork@sourceware.org>; Mon, 6 Feb 2023 22:25:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62B6A3857803 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675722359; bh=/WhICV/E/mQZtubDzVZ1SsPkX6as62GPQCpUi1nTuG8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Help:List-Subscribe:From: Reply-To:From; b=rTdkfCus9c+3UEcyjJCMDTBOspb63DL2AtKsrsoi6+NoNvwoKXO8bHQsQcNqYE20V 1DiEma75Dll2uzaxJ0PKBFqr6b1t3yUv2C+F/pOO8XMsIDBEYIwqbi7dws92ZxSZrf EIkUsgqnJZ5Ee8RZ1KeBkJiT+dzGyuRHeXzzZNd0= X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 97646385B50F for <elfutils-devel@sourceware.org>; Mon, 6 Feb 2023 22:25:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97646385B50F Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 316Ljswb019220 for <elfutils-devel@sourceware.org>; Mon, 6 Feb 2023 22:25:41 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nk9rhrwd3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <elfutils-devel@sourceware.org>; Mon, 06 Feb 2023 22:25:41 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 316HchI9020939 for <elfutils-devel@sourceware.org>; Mon, 6 Feb 2023 22:25:39 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3nhemfjv67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <elfutils-devel@sourceware.org>; Mon, 06 Feb 2023 22:25:38 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 316MPZ7W49283490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Feb 2023 22:25:35 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 58ED120075; Mon, 6 Feb 2023 22:25:35 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0DA3F20074; Mon, 6 Feb 2023 22:25:35 +0000 (GMT) Received: from heavy.lan (unknown [9.179.9.231]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Feb 2023 22:25:34 +0000 (GMT) To: elfutils-devel@sourceware.org Cc: Ilya Leoshkevich <iii@linux.ibm.com> Subject: [PATCH RFC 10/11] configure: Add --disable-demangle Date: Mon, 6 Feb 2023 23:25:12 +0100 Message-Id: <20230206222513.1773039-11-iii@linux.ibm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230206222513.1773039-1-iii@linux.ibm.com> References: <20230206222513.1773039-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Cmo0jitZyph85ez8j1iJ04zAVHcQ0byc X-Proofpoint-ORIG-GUID: Cmo0jitZyph85ez8j1iJ04zAVHcQ0byc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_07,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 malwarescore=0 clxscore=1015 mlxlogscore=665 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302060191 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> From: Ilya Leoshkevich via Elfutils-devel <elfutils-devel@sourceware.org> Reply-To: Ilya Leoshkevich <iii@linux.ibm.com> Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org Sender: "Elfutils-devel" <elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Add Memory Sanitizer support
|
|
Commit Message
Ilya Leoshkevich
Feb. 6, 2023, 10:25 p.m. UTC
__cxa_demangle is normally implemented in the C++ runtime library,
instrumenting which for MSan is a hassle. Add a knob for disabling it.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
configure.ac | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Comments
Hi Ilya, On Mon, 2023-02-06 at 23:25 +0100, Ilya Leoshkevich via Elfutils-devel wrote: > __cxa_demangle is normally implemented in the C++ runtime library, > instrumenting which for MSan is a hassle. Add a knob for disabling it. > > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > --- > configure.ac | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 7dc9be63..6a5c38af 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -466,11 +466,17 @@ CFLAGS="$CFLAGS -D_GNU_SOURCE" > AC_FUNC_STRERROR_R() > CFLAGS="$old_CFLAGS" > > +AC_ARG_ENABLE([demangler], > +AS_HELP_STRING([--disable-demangle], > + [Disable libstdc++ demangle support])) Typo [--disable-demangler] (missing r). Also we want to enable demangler support by default if the enable option isn't given, so you need to add [], [enable_demangler=yes] at the end. AC_ARG_ENABLE (feature, help-string, [action-if-given], [action-if-not- given]) So the action-if-not-given is to enable the feature. Note that otherwise the summary at the end will have nothing for: libstdc++ demangle support : Should be either yes or no, even when --enable-demangler or --disable- demangler isn't given. Cheers, Mark > +AS_IF([test "x$enable_demangler" == xyes], > AC_CHECK_LIB([stdc++], [__cxa_demangle], [dnl > AC_DEFINE([USE_DEMANGLE], [1], [Defined if demangling is enabled])]) > AM_CONDITIONAL(DEMANGLE, test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes") > AS_IF([test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes"], > - [enable_demangler=yes],[enable_demangler=no]) > + [enable_demangler=yes],[enable_demangler=no]), > +AM_CONDITIONAL(DEMANGLE, false)) > > AC_ARG_ENABLE([textrelcheck], > AS_HELP_STRING([--disable-textrelcheck],
diff --git a/configure.ac b/configure.ac index 7dc9be63..6a5c38af 100644 --- a/configure.ac +++ b/configure.ac @@ -466,11 +466,17 @@ CFLAGS="$CFLAGS -D_GNU_SOURCE" AC_FUNC_STRERROR_R() CFLAGS="$old_CFLAGS" +AC_ARG_ENABLE([demangler], +AS_HELP_STRING([--disable-demangle], + [Disable libstdc++ demangle support])) + +AS_IF([test "x$enable_demangler" == xyes], AC_CHECK_LIB([stdc++], [__cxa_demangle], [dnl AC_DEFINE([USE_DEMANGLE], [1], [Defined if demangling is enabled])]) AM_CONDITIONAL(DEMANGLE, test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes") AS_IF([test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes"], - [enable_demangler=yes],[enable_demangler=no]) + [enable_demangler=yes],[enable_demangler=no]), +AM_CONDITIONAL(DEMANGLE, false)) AC_ARG_ENABLE([textrelcheck], AS_HELP_STRING([--disable-textrelcheck],