diff mbox series

backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files

Message ID 20230119221138.291056-1-mark@klomp.org
State Committed
Headers
Series backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files |

Commit Message

Mark Wielaard Jan. 19, 2023, 10:11 p.m. UTC 
  Using the NONE relocation doesn't do anything, but is harmless.

This fixes several (self) tests on sparc that use elflint to
check files are valid ELF.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 backends/ChangeLog       | 4 ++++
 backends/sparc_reloc.def | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comments

Jose E. Marchesi Jan. 19, 2023, 10:17 p.m. UTC | #1 
> Using the NONE relocation doesn't do anything, but is harmless.
>
> This fixes several (self) tests on sparc that use elflint to
> check files are valid ELF.

FWIW looks good to me.

>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
>  backends/ChangeLog       | 4 ++++
>  backends/sparc_reloc.def | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/backends/ChangeLog b/backends/ChangeLog
> index f28ab89b..40ec7c0c 100644
> --- a/backends/ChangeLog
> +++ b/backends/ChangeLog
> @@ -1,3 +1,7 @@
> +2023-01-19  Mark Wielaard  <mark@klomp.org>
> +
> +	* sparc_reloc.def (NONE): Add EXEC and DYN.
> +
>  2022-12-21  Shahab Vahedi  <shahab@synopsys.email>
>  
>  	* Makefile.am (modules): Add arc.
> diff --git a/backends/sparc_reloc.def b/backends/sparc_reloc.def
> index 7cd5ce96..f0eeb5c6 100644
> --- a/backends/sparc_reloc.def
> +++ b/backends/sparc_reloc.def
> @@ -28,7 +28,7 @@
>  
>  /* 	    NAME,		REL|EXEC|DYN	*/
>  
> -RELOC_TYPE (NONE,               REL)
> +RELOC_TYPE (NONE,               REL|EXEC|DYN)
>  RELOC_TYPE (8,                  REL)
>  RELOC_TYPE (16,                 REL)
>  RELOC_TYPE (32,                 REL|DYN)
Mark Wielaard Jan. 19, 2023, 10:44 p.m. UTC | #2 
Hi Jose,

On Thu, Jan 19, 2023 at 11:17:13PM +0100, Jose E. Marchesi wrote:
> > Using the NONE relocation doesn't do anything, but is harmless.
> >
> > This fixes several (self) tests on sparc that use elflint to
> > check files are valid ELF.
> 
> FWIW looks good to me.

Thanks, pushed.

Cheers,

Mark
diff mbox series

Patch

diff --git a/backends/ChangeLog b/backends/ChangeLog
index f28ab89b..40ec7c0c 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,7 @@ 
+2023-01-19  Mark Wielaard  <mark@klomp.org>
+
+	* sparc_reloc.def (NONE): Add EXEC and DYN.
+
 2022-12-21  Shahab Vahedi  <shahab@synopsys.email>
 
 	* Makefile.am (modules): Add arc.
diff --git a/backends/sparc_reloc.def b/backends/sparc_reloc.def
index 7cd5ce96..f0eeb5c6 100644
--- a/backends/sparc_reloc.def
+++ b/backends/sparc_reloc.def
@@ -28,7 +28,7 @@ 
 
 /* 	    NAME,		REL|EXEC|DYN	*/
 
-RELOC_TYPE (NONE,               REL)
+RELOC_TYPE (NONE,               REL|EXEC|DYN)
 RELOC_TYPE (8,                  REL)
 RELOC_TYPE (16,                 REL)
 RELOC_TYPE (32,                 REL|DYN)