From patchwork Wed Dec 21 15:43:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Wielaard X-Patchwork-Id: 62232 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3F5DF385703F for ; Wed, 21 Dec 2022 15:43:17 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 2A637385842C for ; Wed, 21 Dec 2022 15:43:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A637385842C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id DC6B7300071A; Wed, 21 Dec 2022 16:43:08 +0100 (CET) Received: by reform (Postfix, from userid 1000) id 63F482E80CE6; Wed, 21 Dec 2022 16:43:08 +0100 (CET) From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: Mark Wielaard Subject: [PATCH] libdwfl: Don't undef _ Date: Wed, 21 Dec 2022 16:43:05 +0100 Message-Id: <20221221154305.884830-1-mark@klomp.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-3038.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org Sender: "Elfutils-devel" A couple of files undefined _, which is defined in lib/eu-config.h as gettext helper macro. This seems unnecessary and arbitrary. Signed-off-by: Mark Wielaard --- libdwfl/ChangeLog | 7 +++++++ libdwfl/core-file.c | 1 - libdwfl/dwfl_segment_report_module.c | 1 - libdwfl/elf-from-memory.c | 1 - libdwfl/open.c | 1 - 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index 1b465e48..9cd2f03c 100644 --- a/libdwfl/ChangeLog +++ b/libdwfl/ChangeLog @@ -1,3 +1,10 @@ +2022-12-21 Mark Wielaard + + * core-file.c: Don't undef _. + * dwfl_segment_report_module.c: Likewise. + * elf-from-memory.c: Likewise. + * open.c: Likewise. + 2022-12-20 Mark Wielaard * Makefile.am (AM_CPPFLAGS): debuginfod.h is in builddir. diff --git a/libdwfl/core-file.c b/libdwfl/core-file.c index 1ddf0f18..87c940cb 100644 --- a/libdwfl/core-file.c +++ b/libdwfl/core-file.c @@ -29,7 +29,6 @@ #include #include "libelfP.h" /* For NOTE_ALIGN. */ -#undef _ #include "libdwflP.h" #include diff --git a/libdwfl/dwfl_segment_report_module.c b/libdwfl/dwfl_segment_report_module.c index 41285103..3ef62a7d 100644 --- a/libdwfl/dwfl_segment_report_module.c +++ b/libdwfl/dwfl_segment_report_module.c @@ -29,7 +29,6 @@ #include #include "libelfP.h" /* For NOTE_ALIGN4 and NOTE_ALIGN8. */ -#undef _ #include "libdwflP.h" #include "common.h" diff --git a/libdwfl/elf-from-memory.c b/libdwfl/elf-from-memory.c index f7fb3ab7..e9b330fd 100644 --- a/libdwfl/elf-from-memory.c +++ b/libdwfl/elf-from-memory.c @@ -28,7 +28,6 @@ #include #include "libelfP.h" -#undef _ #include "libdwflP.h" diff --git a/libdwfl/open.c b/libdwfl/open.c index 32bd7ff8..fcb7f8ea 100644 --- a/libdwfl/open.c +++ b/libdwfl/open.c @@ -32,7 +32,6 @@ #endif #include "libelfP.h" -#undef _ #include "libdwflP.h" #if !USE_BZLIB