[04/25] libelf/libdwfl: Remove "#define LIB_SYSTEM_H 1" in libelf_crc32.c and libdwfl_crc32.c
Message ID | 20221020182603.815-5-luoyonggang@gmail.com |
---|---|
State | Committed |
Headers |
Return-Path: <elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C0DE384B126 for <patchwork@sourceware.org>; Thu, 20 Oct 2022 18:26:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C0DE384B126 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666290406; bh=YvggxQ5bqpOZ456EtJDrAoFkZtwF0WEgtwQpIjMcG54=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=k1FvQZGx8qzZ097NQg5VAxst3Q2uRpwHrDbEa07U6ed2Wz1qUj6YtJfk1Ec0cq/OW K3EdxEBDCijRDkMKH6ZBMVre8KUYjxQWoy3uWdvCVw32kzAAH+xsL5kyuMsfQFJepB QG9VOzZ8iCaHD5GCPGN/6xqgDTbc5jGm+trKFFB4= X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 18A843865C23 for <elfutils-devel@sourceware.org>; Thu, 20 Oct 2022 18:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18A843865C23 Received: by mail-pj1-x102e.google.com with SMTP id f8-20020a17090a664800b00212464cd49fso406144pjm.4 for <elfutils-devel@sourceware.org>; Thu, 20 Oct 2022 11:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YvggxQ5bqpOZ456EtJDrAoFkZtwF0WEgtwQpIjMcG54=; b=HChr/43LaDXvrzhhP4kwwjnPcvH95RbO21TeuHJsNczDlI7cBhI9atRUXfvJJaGdFs gCrS8rOtX4xABhupb12Hu9HrSNJnb/STlx+xMCN9BIxHec7eeQOrffsicZLrTJ7LDxvg LSMNQ7jCeFVMYvUMy+0BuR1GbIJWL9jYuZ+rhsqjmfrtZYEBB/yfE06nyuHcbwtC6nS/ 8DlIrzA+rVUCQdQtVmgCnLwkU3TRQaCOSaxooasxqDX43rCFw9evd8H7JtPPbMoUB0oR /dvvWJqEPoeGrEVzUCjdhlIvMYwK4Oo78JHSF0H1Q9Q15uNi5CX1mi1gqjTSD1OxyS+K 9GPg== X-Gm-Message-State: ACrzQf2qXJayoCiC9ECuf1zm5wBR5fSM9Gwe8erVbYg0u15l1rWCksjd md1ByFMvWQ3wpVFpsTK54VzhGTPtXUhsPg== X-Google-Smtp-Source: AMsMyM7Z3MRZuBl36ZkRwozS6lXW8ceX/S9hz8NMFT16pHHjS/SEHXOWUeFD8M749KsUrO94efYJtw== X-Received: by 2002:a17:903:18b:b0:185:43e6:20df with SMTP id z11-20020a170903018b00b0018543e620dfmr14907931plg.4.1666290388740; Thu, 20 Oct 2022 11:26:28 -0700 (PDT) Received: from localhost.localdomain ([103.94.185.75]) by smtp.googlemail.com with ESMTPSA id w15-20020a17090a460f00b00202fbd9c21dsm115067pjg.48.2022.10.20.11.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 11:26:27 -0700 (PDT) To: elfutils-devel@sourceware.org Subject: [PATCH 04/25] libelf/libdwfl: Remove "#define LIB_SYSTEM_H 1" in libelf_crc32.c and libdwfl_crc32.c Date: Fri, 21 Oct 2022 02:25:43 +0800 Message-Id: <20221020182603.815-5-luoyonggang@gmail.com> X-Mailer: git-send-email 2.36.1.windows.1 In-Reply-To: <20221020182603.815-1-luoyonggang@gmail.com> References: <20221020182603.815-1-luoyonggang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/elfutils-devel/> List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>, <mailto:elfutils-devel-request@sourceware.org?subject=subscribe> From: Yonggang Luo via Elfutils-devel <elfutils-devel@sourceware.org> Reply-To: Yonggang Luo <luoyonggang@gmail.com> Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org Sender: "Elfutils-devel" <elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Patches for building with mingw/gcc msvc/clang-cl
|
|
Commit Message
Yonggang Luo
Oct. 20, 2022, 6:25 p.m. UTC
rationale: https://sourceware.org/bugzilla/show_bug.cgi?id=21001
If we don't remove this macro, when try #include <system.h> in libdw/memory-access.h
wont' take effect because "#define LIB_SYSTEM_H 1"
The compile error:
./../libdw/memory-access.h:390:12: error: implicit declaration of function ‘bswap_32’ [-Werror=implicit-function-declaration]
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
libdwfl/libdwfl_crc32.c | 1 -
libelf/libelf_crc32.c | 1 -
2 files changed, 2 deletions(-)
Comments
On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > rationale: https://sourceware.org/bugzilla/show_bug.cgi?id=21001 > > If we don't remove this macro, when try #include <system.h> in > libdw/memory-access.h > wont' take effect because "#define LIB_SYSTEM_H 1" > The compile error: > ./../libdw/memory-access.h:390:12: error: implicit declaration of > function ‘bswap_32’ [-Werror=implicit-function-declaration] Thanks, makes sense. Added ChangeLog entries and tweaked the commit message a bit to not exceed 72 chars lines. Pushed, Mark
diff --git a/libdwfl/libdwfl_crc32.c b/libdwfl/libdwfl_crc32.c index b89d0d36..5bc7a4ad 100644 --- a/libdwfl/libdwfl_crc32.c +++ b/libdwfl/libdwfl_crc32.c @@ -30,6 +30,5 @@ #endif #define crc32 attribute_hidden __libdwfl_crc32 -#define LIB_SYSTEM_H 1 #include <libdwflP.h> #include "../lib/crc32.c" diff --git a/libelf/libelf_crc32.c b/libelf/libelf_crc32.c index 1426faf1..f1cf4868 100644 --- a/libelf/libelf_crc32.c +++ b/libelf/libelf_crc32.c @@ -30,6 +30,5 @@ #endif #define crc32 attribute_hidden __libelf_crc32 -#define LIB_SYSTEM_H 1 #include <libelf.h> #include "../lib/crc32.c"