diff mbox series

[02/25] ignore build directory

Message ID	20221020182603.815-3-luoyonggang@gmail.com
State	Superseded
Headers	DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB839384D156 To: elfutils-devel@sourceware.org Subject: [PATCH 02/25] ignore build directory Date: Fri, 21 Oct 2022 02:25:41 +0800 Message-Id: <20221020182603.815-3-luoyonggang@gmail.com> In-Reply-To: <20221020182603.815-1-luoyonggang@gmail.com> References: <20221020182603.815-1-luoyonggang@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Yonggang Luo via Elfutils-devel <elfutils-devel@sourceware.org> Reply-To: Yonggang Luo <luoyonggang@gmail.com> Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org Sender: "Elfutils-devel" <elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org>
Series	Patches for building with mingw/gcc msvc/clang-cl \| [00/25] Patches for building with mingw/gcc msvc/clang-cl [01/25] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec' [02/25] ignore build directory [03/25] libebl: There is no need #include <dlfcn.h> in eblclosebackend.c and eblopenbackend.c [04/25] libelf/libdwfl: Remove "#define LIB_SYSTEM_H 1" in libelf_crc32.c and libdwfl_crc32.c [05/25] use #include <system.h> instead platform depended header <endian.h> in libdw/memory-access.h [06/25] move platform depended include into system.h of libebl [07/25] move platform depended include into system.h of libasm, libcpu, libdw, libdwfl and libdwelf [08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h [09/25] include libgen.h in system.h [10/25] libcpu: Remove the need of NMNES by using enum [11/25] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc [12/25] libcpu: Use "#define FCT_mod$64r_m FCT_mod$r_m" is enough and can be recognized by clang-cl… [13/25] libdw: typeof -> __typeof that can be recognized by both clang-cl and gcc [14/25] libdw: check __OPTIMIZE__ in dwarf_whatattr.c and dwarf_whatform.c to match the header [15/25] lib: Implement error properly even when not HAVE_ERR_H [16/25] libeu: Move the implementation of pwrite_retry, write_retry and pread_retry from header to … [17/25] libelf: uid_t, gid_t and mode_t are not comes with msvcrt, so using long/unsigned long inst… [18/25] lib: Use NOT_HAVE_LIBINTL to guard #include <libintl.h> [19/25] libelf: F_GETFD may not predefined with msvc/mingw, guard the usage of it [20/25] Add function sys_get_page_size to replace platform dependent sysconf (_SC_PAGESIZE) [21/25] libasm: stdio_ext.h are not present on win32 [22/25] libebl/libdwelf: define ssize_t and pid_t for MSVC within installed header libdwelf.h and l… [23/25] libasm/debuginfod: fchmod doesn't present on win32 [24/25] lib: isatty is not available on windows

Commit Message

Yonggang Luo Oct. 20, 2022, 6:25 p.m. UTC

  Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Wielaard Oct. 27, 2022, 1:03 p.m. UTC | #1

On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel
wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 8bcd88d7..ca06dddd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -21,6 +21,7 @@ Makefile.in
>  /INSTALL
>  /aclocal.m4
>  /autom4te.*
> +/build
>  /config.cache
>  /config.h
>  /config.h.in

Why is this necessary?

Thanks,

Mark

lilydjwg--- via Elfutils-devel Dec. 16, 2022, 9:14 p.m. UTC | #2

It's a common step to configure and make under build directory, so that the
IDE won't affect by it

On Thu, Oct 27, 2022 at 9:03 PM Mark Wielaard <mark@klomp.org> wrote:

> On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel
> wrote:
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 8bcd88d7..ca06dddd 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -21,6 +21,7 @@ Makefile.in
> >  /INSTALL
> >  /aclocal.m4
> >  /autom4te.*
> > +/build
> >  /config.cache
> >  /config.h
> >  /config.h.in
>
> Why is this necessary?
>
> Thanks,
>
> Mark
>

Mark Wielaard Dec. 20, 2022, 12:35 p.m. UTC | #3

On Sat, 2022-12-17 at 05:14 +0800, 罗勇刚(Yonggang Luo) wrote:
> It's a common step to configure and make under build directory, so
> that the
> IDE won't affect by it

I rather not just ignore a random directory name, unless it clearly is
a default for the build system.

diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index 8bcd88d7..ca06dddd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -21,6 +21,7 @@  Makefile.in
 /INSTALL
 /aclocal.m4
 /autom4te.*
+/build
 /config.cache
 /config.h
 /config.h.in