diff mbox series

debuginfod, elfclassify: remove unnecessary header inclusion

Message ID 20210820182120.2841876-1-abdulras@google.com
State Committed
Headers
Series debuginfod, elfclassify: remove unnecessary header inclusion |

Commit Message

Saleem Abdulrasool Aug. 20, 2021, 6:21 p.m. UTC 
  `error.h`'s inclusion was centralised into the `system.h` header.  As
the implementation currently includes `system.h` already, the inclusion
of `error.h` is unnecessary.  This prepares for a future portability
change to allow elfutil to build with alternate libc implementations.

Signed-off-by: Saleem Abdulrasool <abdulras@google.com>
---
 debuginfod/debuginfod.cxx | 1 -
 src/elfclassify.c         | 1 -
 2 files changed, 2 deletions(-)

Comments

Mark Wielaard Aug. 27, 2021, 3:19 p.m. UTC | #1 
Hi Saleem,

On Fri, 2021-08-20 at 18:21 +0000, Saleem Abdulrasool via Elfutils-devel wrote:
> `error.h`'s inclusion was centralised into the `system.h` header.  As
> the implementation currently includes `system.h` already, the inclusion
> of `error.h` is unnecessary.  This prepares for a future portability
> change to allow elfutil to build with alternate libc implementations.
> 
> Signed-off-by: Saleem Abdulrasool <abdulras@google.com>

Thanks. Added ChangeLog entries and pushed.

Cheers,

Mark
diff mbox series

Patch

diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index fca07f61..b560fdcb 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -46,7 +46,6 @@  extern "C" {
 
 #include <unistd.h>
 #include <stdlib.h>
-#include <error.h>
 #include <libintl.h>
 #include <locale.h>
 #include <pthread.h>
diff --git a/src/elfclassify.c b/src/elfclassify.c
index fe7eeeed..2f70b29a 100644
--- a/src/elfclassify.c
+++ b/src/elfclassify.c
@@ -19,7 +19,6 @@ 
 #include <system.h>
 
 #include <argp.h>
-#include <error.h>
 #include <fcntl.h>
 #include <gelf.h>
 #include <stdbool.h>