mbox series

[0/3] aarch64: add some core note types name

Message ID 20240814085134.109500-1-kuan-ying.lee@canonical.com
Headers
Series aarch64: add some core note types name |

Message

Kuan-Ying Lee Aug. 14, 2024, 8:51 a.m. UTC 
  Patch 1:
 - Add MTE related regset in core note
Patch 2:
 - Add PAC related regset in core note
Patch 3:
 - Add some core note types name

Kuan-Ying Lee (3):
  aarch64: Add NT_ARM_TAGGED_ADDR_CTRL regset
  aarch64: Add NT_ARM_PAC_* regset
  aarch64: add some new core note types name

 backends/aarch64_corenote.c  | 33 ++++++++++++++++++++++++++++++++-
 libebl/eblcorenotetypename.c |  6 ++++++
 libelf/elf.h                 |  2 ++
 3 files changed, 40 insertions(+), 1 deletion(-)

Comments

Mark Wielaard Aug. 16, 2024, 10:47 p.m. UTC | #1 
Hi,

On Wed, Aug 14, 2024 at 04:51:17PM +0800, Kuan-Ying Lee wrote:
> Patch 1:
>  - Add MTE related regset in core note
> Patch 2:
>  - Add PAC related regset in core note
> Patch 3:
>  - Add some core note types name

This look good. Thanks.  For elf.h we try to keep it in sync with the
glibc elf/elf.h.  Since they recently added the same (and more)
NT_ARM_* constants I'll sync that file seperately before incorporating
your patch.

Did you test the output on a core file that has these new regsets and
core notes with eu-readelf to see if it looks correct?

Thanks,

Mark
Kuan-Ying Lee Aug. 19, 2024, 9:24 a.m. UTC | #2 
On Sat, Aug 17, 2024 at 12:47:03AM +0200, Mark Wielaard wrote:
> Hi,
> 
> On Wed, Aug 14, 2024 at 04:51:17PM +0800, Kuan-Ying Lee wrote:
> > Patch 1:
> >  - Add MTE related regset in core note
> > Patch 2:
> >  - Add PAC related regset in core note
> > Patch 3:
> >  - Add some core note types name
> 
> This look good. Thanks.  For elf.h we try to keep it in sync with the
> glibc elf/elf.h.  Since they recently added the same (and more)
> NT_ARM_* constants I'll sync that file seperately before incorporating
> your patch.
> 
> Did you test the output on a core file that has these new regsets and
> core notes with eu-readelf to see if it looks correct?
> 

Thank you for the review.

Yes, I have tested the output on a core file that has these new regsets.

Output is as following:
...
  LINUX                544  ARM_SVE
  LINUX                544  ARM_SSVE
  LINUX                 16  ARM_ZA
  LINUX                 16  ARM_PAC_MASK
    pauth_dmask: 0x007f800000000000, pauth_cmask: 0x007f800000000000
  LINUX                  8  ARM_PAC_ENABLED_KEYS
    enabled_keys: 0x000000000000000f
  LINUX                  8  ARM_TAGGED_ADDR_CTRL
    tag_ctrl: 0x000000000007fff3

Thank you,
Kuan-Ying Lee

> Thanks,
> 
> Mark