Wherever blanks are permissible in input, tabs ought to be permissible,
too. This is particularly relevant when -f is passed to gas (alongside
appropriate input).
---
v2: New.
On Mon, 2025-01-27 17:42:54 +0100, Jan Beulich <jbeulich@suse.com> wrote:
> Wherever blanks are permissible in input, tabs ought to be permissible,
> too. This is particularly relevant when -f is passed to gas (alongside
> appropriate input).
> ---
> v2: New.
>
> --- a/gas/config/tc-vax.c
> +++ b/gas/config/tc-vax.c
> @@ -1278,13 +1278,13 @@ vip_op (char *optext, struct vop *vopP)
>
> p = optext;
>
> - if (*p == ' ') /* Expect all whitespace reduced to ' '. */
> + if (is_whitespace (*p))
[...]
Thanks a lot, please go for it!
MfG, JBG
--
@@ -1278,13 +1278,13 @@ vip_op (char *optext, struct vop *vopP)
p = optext;
- if (*p == ' ') /* Expect all whitespace reduced to ' '. */
+ if (is_whitespace (*p))
p++; /* skip over whitespace */
if ((at = INDIRECTP (*p)) != 0)
{ /* 1 if *p=='@'(or '*' for Un*x) */
p++; /* at is determined */
- if (*p == ' ') /* Expect all whitespace reduced to ' '. */
+ if (is_whitespace (*p))
p++; /* skip over whitespace */
}
@@ -1302,7 +1302,7 @@ vip_op (char *optext, struct vop *vopP)
len = ' '; /* Len is determined. */
}
- if (*p == ' ') /* Expect all whitespace reduced to ' '. */
+ if (is_whitespace (*p))
p++;
if ((hash = IMMEDIATEP (*p)) != 0) /* 1 if *p=='#' ('$' for Un*x) */
@@ -1318,7 +1318,7 @@ vip_op (char *optext, struct vop *vopP)
;
q--; /* Now q points at last char of text. */
- if (*q == ' ' && q >= p) /* Expect all whitespace reduced to ' '. */
+ if (is_whitespace (*q) && q >= p)
q--;
/* Reverse over whitespace, but don't. */
@@ -1368,7 +1368,7 @@ vip_op (char *optext, struct vop *vopP)
Otherwise ndx == -1 if there was no "[...]".
Otherwise, ndx is index register number, and q points before "[...]". */
- if (*q == ' ' && q >= p) /* Expect all whitespace reduced to ' '. */
+ if (is_whitespace (*q) && q >= p)
q--;
/* Reverse over whitespace, but don't. */
/* Run back over *p. */
@@ -1454,7 +1454,7 @@ vip_op (char *optext, struct vop *vopP)
We remember to save q, in case we didn't want "Rn" anyway. */
if (!paren)
{
- if (*q == ' ' && q >= p) /* Expect all whitespace reduced to ' '. */
+ if (is_whitespace (*q) && q >= p)
q--;
/* Reverse over whitespace, but don't. */
/* Run back over *p. */
@@ -1860,11 +1860,11 @@ vip (struct vit *vitP, /* We build an e
/* Op-code of this instruction. */
vax_opcodeT oc;
- if (*instring == ' ')
+ if (is_whitespace (*instring))
++instring;
/* MUST end in end-of-string or exactly 1 space. */
- for (p = instring; *p && *p != ' '; p++)
+ for (p = instring; *p && !is_whitespace (*p); p++)
;
/* Scanned up to end of operation-code. */
@@ -1939,7 +1939,7 @@ vip (struct vit *vitP, /* We build an e
}
if (!*alloperr)
{
- if (*instring == ' ')
+ if (is_whitespace (*instring))
instring++;
if (*instring)
alloperr = _("Too many operands");