gas: drop unnecessary use of tc_comment_chars
Checks
| Context |
Check |
Description |
| linaro-tcwg-bot/tcwg_binutils_build--master-arm |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 |
success
|
Test passed
|
| linaro-tcwg-bot/tcwg_binutils_check--master-arm |
success
|
Test passed
|
Commit Message
The override is necessary only when a target needs other than an array
of const char.
For cris drop redundant sibling declarations at the same time.
Comments
On Fri, 26 Jul 2024, Jan Beulich wrote:
> The override is necessary only when a target needs other than an array
> of const char.
>
> For cris drop redundant sibling declarations at the same time.
Assuming this builds and regtests for mmix, cris-elf and
cris-linux, all ok.
brgds, H-P
@@ -211,7 +211,7 @@ static int warn_for_branch_expansion = 0
static int err_for_dangerous_mul_placement
= (XCONCAT2 (arch_,DEFAULT_CRIS_ARCH) != arch_crisv32);
-const char cris_comment_chars[] = ";";
+const char comment_chars[] = ";";
/* This array holds the chars that only start a comment at the beginning of
a line. If the line seems to have the form '# 123 filename'
@@ -50,11 +50,6 @@ extern size_t md_longopts_size;
extern const pseudo_typeS md_pseudo_table[];
-#define tc_comment_chars cris_comment_chars
-extern const char cris_comment_chars[];
-extern const char line_comment_chars[];
-extern const char line_separator_chars[];
-
/* This should be optional, since it is ignored as an escape (assumed to
be itself) if it is not recognized. */
#define ONLY_STANDARD_ESCAPES
@@ -382,7 +382,7 @@ const pseudo_typeS md_pseudo_table[] =
{NULL, 0, 0}
};
-const char mmix_comment_chars[] = "%!";
+const char comment_chars[] = "%!";
/* A ':' is a valid symbol character in mmixal. It's the prefix
delimiter, but other than that, it works like a symbol character,
@@ -26,9 +26,6 @@
#define TARGET_ARCH bfd_arch_mmix
#define TARGET_BYTES_BIG_ENDIAN 1
-extern const char mmix_comment_chars[];
-#define tc_comment_chars mmix_comment_chars
-
extern const char mmix_symbol_chars[];
#define tc_symbol_chars mmix_symbol_chars
@@ -49,7 +49,7 @@ typedef struct
}
or1k_insn;
-const char comment_chars[] = "#";
+const char comment_chars[] = ";#";
const char line_comment_chars[] = "#";
const char line_separator_chars[] = ";";
const char EXP_CHARS[] = "eE";
@@ -90,8 +90,6 @@ s_nodelay (int val ATTRIBUTE_UNUSED)
nodelay = true;
}
-const char or1k_comment_chars [] = ";#";
-
/* The target specific pseudo-ops which we support. */
const pseudo_typeS md_pseudo_table[] =
{
@@ -29,9 +29,6 @@ extern unsigned long or1k_machine;
#define TARGET_FORMAT "elf32-or1k"
#define TARGET_BYTES_BIG_ENDIAN 1
-extern const char or1k_comment_chars [];
-#define tc_comment_chars or1k_comment_chars
-
/* Permit temporary numeric labels. */
#define LOCAL_LABELS_FB 1
@@ -53,9 +53,8 @@
/* This string holds the chars that always start a comment. If the
- pre-processor is disabled, these aren't very useful. The macro
- tc_comment_chars points to this. */
-const char *visium_comment_chars = "!;";
+ pre-processor is disabled, these aren't very useful. */
+const char comment_chars[] = "!;";
/* This array holds the chars that only start a comment at the beginning
of a line. If the line seems to have the form '# 123 filename' .line
@@ -63,9 +63,6 @@ extern long visium_pcrel_from_section (s
#define md_operand(x)
-#define tc_comment_chars visium_comment_chars
-extern const char *visium_comment_chars;
-
#define TARGET_USE_CFIPOP 1
#define tc_cfi_frame_initial_instructions visium_cfi_frame_initial_instructions