From patchwork Tue Apr 21 11:56:43 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 133472 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 993A84BAD154 for ; Tue, 21 Apr 2026 11:57:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 993A84BAD154 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Wiheuioi X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id AB3BD4BAD160 for ; Tue, 21 Apr 2026 11:56:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB3BD4BAD160 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB3BD4BAD160 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::332 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776772605; cv=none; b=FcnvTA4sfUPIKkUq/1jUcIJ6oxjyCIzzZKJCpDS13SeFQ5+DEthcS2Yb+9SVgU609C3U98qBn7GNTReiTqZLpfazC7bg/AKwmZ0aW0PZMWIfp+2xHCuckP+2sjnlVmnol96+3hz7aZrWhBRs9n+mTl5jehQFWHN0ypp1d7toPAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776772605; c=relaxed/simple; bh=B7mOkeCdiaUbKXIhW/W/OpjulYzp/I8D/J3dDK0TzF8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=w4hvh8GG69GLEb/ywpw1S2/JxITozBMkrx/bq39IM8ycQZqU27Fve5OYM7TkyOD7B2PR1cjz7r12Sm0kXRrApEMod5M7Y4fIzEcWajp9uxYwDueXmMJoy7ib14hc1ux/hxkfSUiX4QcDAO4K69R0oiYqBUwdUV+XxLypMaPSo+Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB3BD4BAD160 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4893940bb5eso11380545e9.3 for ; Tue, 21 Apr 2026 04:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1776772605; x=1777377405; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=S2ipe3areTRa2gGAkohj9ThGDLWN3bhMF/G+qDBma/s=; b=WiheuioikZ75kBpVCRyP9dBspDQSTIlLCmr39lIyDuF3xLkJMOPJyNS/Dz7iCISkBf mgy2vq25NxXIOAlLwP6c+1/zV+PzaZGrZAQns9F+Au8AE605LSmSQ6GKP0ltftj+wXcI x9Io1xK4EXtvRkb/75OYTiY6JSgUgnN1R5eJEJS+8nfWbsDyA1dqztoBw8tpeJgKuQPC GcCkv2yuC7q1n4o5siPgVmrmb5In6vV9iJfSz85ajTAwXCLgcolrKsZGgbLMBhn1xvVL NqSTrLn82DSzeg0Zz7qZTJWsSoP4/Y8uBjtu5NS9qrVhgoFY0KLwI1OL04p2ugArWIJd /cHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776772605; x=1777377405; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S2ipe3areTRa2gGAkohj9ThGDLWN3bhMF/G+qDBma/s=; b=jb+58ViJR/FouvUdjaRqDdypWFDUa51RDOnGyC0PNli+MeGlLpm3FQ6mItqWiE7WbT TrMb2UdNY1MvsFNotnq+StneThv4I9vPmptyROOL8opZ5FdUMPNw6A1fqyTPMd6ztuY3 1Mv8TyGZVWe3PEHkAUT5h9eKAc+09w98kwwwIOKU2+WAPQ+0b5TKH+00rGpDe+CAb1cQ AwOwfc4HEcC3HhtQJlGN04Z83BBTZCTnRgMeODVS26aBGqr9WbipeeHEQrXDg+tUvaVj 3e8/sG6OwTgd6KNdPHDKnjizxL9TTa45cu6W6rGGOSrMdrywXiAKUMKmvjanRG+laIoz qOWw== X-Gm-Message-State: AOJu0YwTkGx7y8pGYFbqo2NgxwSdugCaum89EV0V4pzd3yDB18o/dgPk /9QGaxPHkI39E2MNPc2TKiHO/z8kC/hVHewoqBLjgbETtyY3SdrmBoaTJyO3Gi3WNo+YwDcc9E6 5Pb6pTg== X-Gm-Gg: AeBDiesgln5c2H4bqJR21nrOu95u8WcL8QCnILGRxopX3hmw/NdP9kGmxEn+9nk/GlZ eQ2GJKcY89HGRaDHRvLbJBHza6Fk0/yU+mB+mlGegSxkyRBhWXjdhm1Em+AmxdNF7dekk0uW6wU TPXPYiwvbAPt/Hm7JiCMyiHDYWwbo69Pvq2TklD5+XNGHh1S+uObOZcJqP4Fwsw2wDAOJ++EvR3 rqE5epMgtI1iVUKq75BIDaFd3S03M1935/kpINC9OfNC11DqwfrVd1T3c+iOuRxZAT6AE0U+RVK wZuN4VUXC7b4OJ7j4yIdX7q/t/H6doe8nB0ti78a323x+s8wM1ZmGmWX8CwIzvVnZ+hG593IoRE saspILWfUs7N4+HyWExwAiphhIRydU8+vryVruhgSEWl+7MsdWAoKUGGdFtSEQvdh0TYM1+A9zu bTNHI0rUWxIDARAKNjcpi0fTXouTVsR9NLgEW9P5Nc4opBM2nqWER+lbzS2LWMHLU4eBqYvulj0 3qKfTY6XfpfdR0YRSXHqLFnvg== X-Received: by 2002:a05:600d:b:b0:48a:56de:d63c with SMTP id 5b1f17b1804b1-48a56dedadfmr18482465e9.27.1776772604530; Tue, 21 Apr 2026 04:56:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb755938sm150988355e9.3.2026.04.21.04.56.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2026 04:56:44 -0700 (PDT) Message-ID: Date: Tue, 21 Apr 2026 13:56:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 17/19] RISC-V: drop dead code from subset parsing From: Jan Beulich To: Binutils Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu References: <620231e0-67d0-4bd0-b593-38f32b01a6d8@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <620231e0-67d0-4bd0-b593-38f32b01a6d8@suse.com> X-Spam-Status: No, score=-3016.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org In riscv_update_subset1(), when explicit_subset is NULL, errmsg_internal is the empty string. There's no need then to pass this as an extra argument to the error handler. riscv_parsing_subset_version() can't return NULL. Dropping the respective checks clarifies that there is no issue with a missing error message (gas would rely on one being emitted when parsing fails). --- a/bfd/elfxx-riscv.c +++ b/bfd/elfxx-riscv.c @@ -2141,11 +2141,6 @@ riscv_parse_extensions (riscv_parse_subs end_of_version = riscv_parsing_subset_version (q, &major_version, &minor_version); *q = '\0'; - if (end_of_version == NULL) - { - free (subset); - return NULL; - } /* Check if the prefixed extension name is well-formed. */ if (class != RV_ISA_CLASS_SINGLE @@ -2700,11 +2695,6 @@ riscv_update_subset1 (riscv_parse_subset end_of_version = riscv_parsing_subset_version (q, &major_version, &minor_version); *q = '\0'; - if (end_of_version == NULL) - { - free (subset); - return false; - } if (strlen (subset) == 0 || (strlen (subset) == 1 @@ -2725,8 +2715,8 @@ riscv_update_subset1 (riscv_parse_subset if (removed) { rps->error_handler - (_("%sdeprecated - extension `%s' in %s `%s'"), - errmsg_internal, subset, errmsg_caller, implicit_exts); + (_("deprecated - extension `%s' in %s `%s'"), + subset, errmsg_caller, implicit_exts); free (subset); return false; } @@ -2735,8 +2725,8 @@ riscv_update_subset1 (riscv_parse_subset || strcmp (subset, "g") == 0) { rps->error_handler - (_("%scannot + base extension `%s' in %s `%s'"), - errmsg_internal, subset, errmsg_caller, implicit_exts); + (_("cannot + base extension `%s' in %s `%s'"), + subset, errmsg_caller, implicit_exts); free (subset); return false; }