From patchwork Mon Jan 27 16:25:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 105497 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FC8C385843B for ; Mon, 27 Jan 2025 16:55:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5FC8C385843B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Z/o+yUjC X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id DF9B2385801B for ; Mon, 27 Jan 2025 16:25:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF9B2385801B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF9B2385801B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995139; cv=none; b=rlvblSnjUuv59O4HyrQ2sVKEqOcjfCMOT5RoetmswDmQHcYZk4ABL5WyWAwcv12QG2K6laksJ1Rbhav0GCtXmmYYV6w3E3X+FRFK7WSUYwuBNP3seLq0D9Z7vZZL0bMd6ey80fjYRHAOD4iQPyQvnwYSjqtr2xcQdV6W0JCGU0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737995139; c=relaxed/simple; bh=sEjyuwMt6b+/XN76rKoCSK0QXVCzFgVFz9Ats20Yh1c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=l8rFl4eyq+gcFuofSNSPwQUY4FC6FpkynzZHZSFbiCvdIh10jEiRsmp/1xX8oQysH+M90uf7ZDUqLcHsY9Om7Grm9103xAMrAnDSuA9BFcWF7O6Whvjfl81OGyjxISLhWkp8sTTy7B5uZ/i4KLFFkLLWLEd5F6cwvf5JbHyy4TM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF9B2385801B Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-aaef00ab172so739563666b.3 for ; Mon, 27 Jan 2025 08:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737995137; x=1738599937; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PMVo6cSJr3N9wQZr9Whdqf/5ljShrwwTP8GwQ4eVN4A=; b=Z/o+yUjCXH6WyZ3Rgo/CB+ukfo/CBO9LijOhXp7OSZOQIUD4b+SEvb7UjgrCpVLYwm JzNKZMdjCGT4W5ne4GBkrHhWVAs5oMwHlyhoUaR/MdzOwSFVqDDTADActr7pBnBGpJEI KbBPPbTZA7HYUlsD7qfkpNWSa0Wn+tS6BktwBTVT2ytNGQ2GHPwFE+w0hUTc+C2xQ2wr mg7YrCc+NfixK1RR7K1j5wUPg5atJKvLRzzignVjQNJqLGif+5y88YcmYQkj2rU4o81T ZncRUfKvbHZ0SLmU93sGG1PYx1Knj4HjJVLr9O1TQ1Z0AJVGSc3YpYZQdwlN4eQq4DV/ Zv3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737995137; x=1738599937; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PMVo6cSJr3N9wQZr9Whdqf/5ljShrwwTP8GwQ4eVN4A=; b=gha/pkpuFoljiyTwt4alWE9Dhx7NESWngDF39YD2SOpXTPCGCReC/eHGQZA3Midvpy R2YWN3ibfNzFHQpUUHlIeuQVd5jBav2XLoAaUUqOXHMZWkQfxOeOFHN4oQy8mSiqR4Ez jotZVQN2RLm7CmlTO1/MFikWDuucyM4JjE9hNxKl7ObARuMXiMZZp3mr7PDsYiASH8RZ 1p/okaSl53szP7JKj/nLzrv3ywlY2rqxkAyXRNH4RPKvvSoDTMXnc7UHWkDsqVOn1GF8 KmBzxYz09F6bBAibKRpBUdu71vsqm1/orTMcDm0e77+s2kF9keLF9mYnY+57L2nxZCus s4kw== X-Gm-Message-State: AOJu0Ywv6QhJdDqBnZKSMbkO0iHK/Inq34oCFYJKjREd50HNA4XeslpL WtfqDEjKKxHXMXM8mMDJ+2QY0UNB3ais+06/cJy+F6+86MkY4tnINT7Vl0JUPtjDkLSWRexlrrM = X-Gm-Gg: ASbGncumVk+gGBbmsq++haA2vqzIu4tlyq/rvCeyNwapYsplRTp/F0752XEck11nNVY v39K4ExZ/7pCK4YCHNNpMzEaGucmJwBPvaCDeiIkwcvcai7rqC46kQ9sw+Vo/eEpVu3jR1SO4sh pqCHed4YGIaLX9PTdNLmqC61EHJpwdbQBCEBAkhoMFzFxyGwm4FCEcCznklfqSK1BAEteLPXM+J ZL4zoUG2Vq9+jqZJW2Q41MDhd4Ac0syVJjAZjMWM83paCEAqMI8ubbyGuQEPSkEJ3NnQdePbXKr nxSzVKXhPcWpWkoIFZq+I28vgVczkQgKeOJbFFEF6uvNmg/HTksCiS2HTci7ckr7kw== X-Google-Smtp-Source: AGHT+IHpZiv381zMPm4+gEypayMqITLEtHK0hQAV+IusGTBfBgNlIhm404i8BgGJGF0V4GjD5Fq01g== X-Received: by 2002:a05:6402:3587:b0:5dc:100c:1560 with SMTP id 4fb4d7f45d1cf-5dc100c1768mr44236065a12.18.1737995137395; Mon, 27 Jan 2025 08:25:37 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e66aedsm611421166b.65.2025.01.27.08.25.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 08:25:37 -0800 (PST) Message-ID: Date: Mon, 27 Jan 2025 17:25:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 28/65] M*Core: use is_whitespace() From: Jan Beulich To: Binutils References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Wherever blanks are permissible in input, tabs ought to be permissible, too. This is particularly relevant when -f is passed to gas (alongside appropriate input). Also convert ISSPACE() uses. At the same time use is_end_of_stmt() instead of an open-coded check in adjacent code. --- v2: New. --- a/gas/config/tc-mcore.c +++ b/gas/config/tc-mcore.c @@ -358,11 +358,11 @@ mcore_s_section (int ignore) pool. */ char * ilp = input_line_pointer; - while (*ilp != 0 && ISSPACE (*ilp)) + while (is_whitespace (*ilp)) ++ ilp; if (startswith (ilp, ".line") - && (ISSPACE (ilp[5]) || *ilp == '\n' || *ilp == '\r')) + && (is_whitespace (ilp[5]) || *ilp == '\n' || *ilp == '\r')) ; else dump_literals (0); @@ -493,7 +493,7 @@ static char * parse_reg (char * s, unsigned * reg) { /* Strip leading whitespace. */ - while (ISSPACE (* s)) + while (is_whitespace (* s)) ++ s; if (TOLOWER (s[0]) == 'r') @@ -551,7 +551,7 @@ parse_creg (char * s, unsigned * reg) int i; /* Strip leading whitespace. */ - while (ISSPACE (* s)) + while (is_whitespace (* s)) ++s; if ((TOLOWER (s[0]) == 'c' && TOLOWER (s[1]) == 'r')) @@ -650,7 +650,7 @@ parse_exp (char * s, expressionS * e) char * new_pointer; /* Skip whitespace. */ - while (ISSPACE (* s)) + while (is_whitespace (* s)) ++ s; save = input_line_pointer; @@ -797,14 +797,14 @@ parse_mem (char * s, { * off = 0; - while (ISSPACE (* s)) + while (is_whitespace (* s)) ++ s; if (* s == '(') { s = parse_reg (s + 1, reg); - while (ISSPACE (* s)) + while (is_whitespace (* s)) ++ s; if (* s == ',') @@ -830,7 +830,7 @@ parse_mem (char * s, } } - while (ISSPACE (* s)) + while (is_whitespace (* s)) ++ s; if (* s == ')') @@ -862,12 +862,12 @@ md_assemble (char * str) char name[21]; /* Drop leading whitespace. */ - while (ISSPACE (* str)) + while (is_whitespace (* str)) str ++; /* Find the op code end. */ for (op_start = op_end = str; - nlen < 20 && !is_end_of_line [(unsigned char) *op_end] && *op_end != ' '; + nlen < 20 && !is_end_of_stmt (*op_end) && !is_whitespace (*op_end); op_end++) { name[nlen] = op_start[nlen]; @@ -962,7 +962,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (*op_end == ',') @@ -986,7 +986,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1005,7 +1005,7 @@ md_assemble (char * str) op_end = parse_reg (op_end + 1, & reg); /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') /* xtrb- r1,rx. */ @@ -1025,7 +1025,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1045,7 +1045,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1064,7 +1064,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1084,7 +1084,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1113,7 +1113,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1140,7 +1140,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1179,7 +1179,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1212,7 +1212,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1231,7 +1231,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1250,7 +1250,7 @@ md_assemble (char * str) inst |= reg << 8; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1288,7 +1288,7 @@ md_assemble (char * str) inst |= (reg << 8); /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1319,7 +1319,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == '-') @@ -1330,7 +1330,7 @@ md_assemble (char * str) as_bad (_("ending register must be r15")); /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; } @@ -1339,7 +1339,7 @@ md_assemble (char * str) op_end ++; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == '(') @@ -1368,7 +1368,7 @@ md_assemble (char * str) as_fatal (_("first register must be r4")); /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == '-') @@ -1379,7 +1379,7 @@ md_assemble (char * str) as_fatal (_("last register must be r7")); /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1387,7 +1387,7 @@ md_assemble (char * str) op_end ++; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == '(') @@ -1400,7 +1400,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ')') @@ -1433,7 +1433,7 @@ md_assemble (char * str) inst |= reg << 4; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1494,7 +1494,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1516,7 +1516,7 @@ md_assemble (char * str) inst |= reg << 4; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1537,7 +1537,7 @@ md_assemble (char * str) inst |= reg; /* Skip whitespace. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) ++ op_end; if (* op_end == ',') @@ -1589,7 +1589,7 @@ md_assemble (char * str) } /* Drop whitespace after all the operands have been parsed. */ - while (ISSPACE (* op_end)) + while (is_whitespace (* op_end)) op_end ++; /* Give warning message if the insn has more operands than required. */