diff mbox series

[v2,34/65] mn10300: use is_whitespace()

Message ID	bc9e5604-bc21-466d-81dd-1c0d40b88039@suse.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 16447385843B Message-ID: <bc9e5604-bc21-466d-81dd-1c0d40b88039@suse.com> Date: Mon, 27 Jan 2025 17:29:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 34/65] mn10300: use is_whitespace() From: Jan Beulich <jbeulich@suse.com> To: Binutils <binutils@sourceware.org> References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US Cc: Alexandre Oliva <aoliva@sourceware.org> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org
Series	gas: whitespace handling \| [v2,00/65] gas: whitespace handling [v2,01/65] gas: consolidate whitespace recognition [v2,02/65] gas/obj-.c: use is_whitespace() [v2,03/65] Alpha/EVAX: use is_whitespace() / is_end_of_stmt() [v2,04/65] arc: use is_whitespace() [v2,05/65] Arm: use is_whitespace() [v2,06/65] aarch64: use is_whitespace() [v2,07/65] avr: use is_whitespace() [v2,08/65] bfin: use is_whitespace() [v2,09/65] bpf: use is_whitespace() [v2,10/65] CR16: use is_whitespace() [v2,11/65] cris: use is_whitespace() [v2,12/65] CRx: use is_whitespace() [v2,13/65] C-Sky: use is_whitespace() [v2,14/65] d10v: use is_whitespace() [v2,15/65] d30v: use is_whitespace() [v2,16/65] dlx: use is_whitespace() [v2,17/65] Epiphany: use is_whitespace() [v2,18/65] fr30: use is_whitespace() [v2,19/65] ft32: use is_whitespace() [v2,20/65] H8/300: use is_whitespace() [v2,21/65] HP-PA: use is_whitespace() [v2,22/65] kvx: use is_whitespace() [v2,23/65] LoongArch: use is_whitespace() [v2,24/65] m32c: use is_whitespace() [v2,25/65] m32r: use is_whitespace() [v2,26/65] M68HC1x: use is_whitespace() [v2,27/65] M68k: use is_whitespace() [v2,28/65] MCore: use is_whitespace() [v2,29/65] metag: use is_whitespace() [v2,30/65] MicroBlaze: use is_whitespace() [v2,31/65] MIPS: use is_whitespace() [v2,32/65] MMIX: use is_whitespace() [v2,33/65] mn10200: use is_whitespace() [v2,34/65] mn10300: use is_whitespace() [v2,35/65] Moxie: use is_whitespace() [v2,36/65] msp430: use is_whitespace() [v2,37/65] nds32: use is_whitespace() [v2,38/65] NS32k: use is_whitespace() [v2,39/65] PDP11: use is_whitespace() [v2,40/65] PicoJava: use is_whitespace() [v2,41/65] PPC: use is_whitespace() [v2,42/65] pru: use is_whitespace() [v2,43/65] RISC-V: use is_whitespace() [v2,44/65] rl78: use is_whitespace() [v2,45/65] rx: use is_whitespace() [v2,46/65] s12z: use is_whitespace() [v2,47/65] S/390: use is_whitespace() [v2,48/65] Score: use is_whitespace() [v2,49/65] SH: use is_whitespace() [v2,50/65] Sparc: use is_whitespace() [v2,51/65] spu: use is_whitespace() [v2,52/65] C30: use is_whitespace() [v2,53/65] C4x: use is_whitespace() [v2,54/65] C54x: use is_whitespace() [v2,55/65] C6x: use is_whitespace() [v2,56/65] v850: use is_whitespace() [v2,57/65] VAX: use is_whitespace() [v2,58/65] Visium: use is_whitespace() [v2,59/65] wasm32: use is_whitespace() [v2,60/65] x86: use is_whitespace() [v2,61/65] xgate: use is_whitespace() [v2,62/65] Xtensa: use is_whitespace() [v2,63/65] Z80: use is_whitespace() [v2,64/65] Z8k: use is_whitespace() [v2,65/65] gas: suppress use of ISSPACE() / ISBLANK()

Checks

Context	Check	Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm	fail	Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64	fail	Patch failed to apply

Commit Message

Jan Beulich Jan. 27, 2025, 4:29 p.m. UTC

  Convert open-coded checks as well as ISSPACE() uses. At the same time
use is_end_of_stmt() instead of kind-of-open-coded checks in adjacent
code.
---
v2: New.

Comments

Alexandre Oliva Feb. 7, 2025, 6:55 a.m. UTC | #1

On Jan 27, 2025, Jan Beulich <jbeulich@suse.com> wrote:

> Convert open-coded checks as well as ISSPACE() uses. At the same time
> use is_end_of_stmt() instead of kind-of-open-coded checks in adjacent
> code.

LGTM, thanks

diff mbox series

Patch

--- a/gas/config/tc-mn10300.c
+++ b/gas/config/tc-mn10300.c
@@ -1241,7 +1241,7 @@  md_assemble (char *str)
   int match;
 
   /* Get the opcode.  */
-  for (s = str; *s != '\0' && !ISSPACE (*s); s++)
+  for (s = str; !is_end_of_stmt (*s) && !is_whitespace (*s); s++)
     ;
   if (*s != '\0')
     *s++ = '\0';
@@ -1255,7 +1255,7 @@  md_assemble (char *str)
     }
 
   str = s;
-  while (ISSPACE (*str))
+  while (is_whitespace (*str))
     ++str;
 
   input_line_pointer = str;
@@ -1304,7 +1304,7 @@  md_assemble (char *str)
 	      next_opindex = 0;
 	    }
 
-	  while (*str == ' ' || *str == ',')
+	  while (is_whitespace (*str) || *str == ',')
 	    ++str;
 
 	  if (operand->flags & MN10300_OPERAND_RELAX)
@@ -1764,7 +1764,7 @@  md_assemble (char *str)
 	  str = input_line_pointer;
 	  input_line_pointer = hold;
 
-	  while (*str == ' ' || *str == ',')
+	  while (is_whitespace (*str) || *str == ',')
 	    ++str;
 	}
 
@@ -1815,10 +1815,10 @@  md_assemble (char *str)
       break;
     }
 
-  while (ISSPACE (*str))
+  while (is_whitespace (*str))
     ++str;
 
-  if (*str != '\0')
+  if (!is_end_of_stmt (*str))
     as_bad (_("junk at end of line: `%s'"), str);
 
   input_line_pointer = str;