From patchwork Fri Sep 22 07:52:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 76565 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E31153856251 for ; Fri, 22 Sep 2023 07:52:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E31153856251 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695369157; bh=hqBjlZGX7O0SAYd8yjA83Z9iEwYFFRf8gST6pyqTPpk=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=JdYc7uSftVeNS6STXRWuCfofpn0MvEcNV95TKJb/oDebNXSNc9k9vql1i/bv/ileA Qh3LVrOnrMt0/ihL4li3/L7SZmwbSROFRFcujL4HuzCmLguvT3XMJ+PPYQTjkPdCym YERDfcklvRbjoXGluMXKZ2MwG4xzl2YKWDSJkK2w= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by sourceware.org (Postfix) with ESMTPS id 3744E3858CD1 for ; Fri, 22 Sep 2023 07:52:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3744E3858CD1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bc0Tq+22IDZPUGUZi2a1PKGlC9QW6bM1LOCBlGVyupv68onVBaFLE5LnmJw28OXrIACDwoQZ0vEWcG1tcccxufcZ/n7/Wsbu8dnE1CxKd03h0/xRWSEPkw0sKZ+VQcoiAFnrkU8YtXdDuFcEO8ztpI9X47e/JnWHtRHJQuK+Ufq1tlnhrnDwW0RusiLviMSmgcj8EfoYGS8WGurwMpaWIofyDxmhM2QJvggi4prFdofvbQ3PjeLvHx+TIz86FJnGqDAXYhIA/lqKM3hUcA35LIH1OiR4H/x/BFgqqT4vYUym0rabTmliK5q0zRUjdTbLJ/XkPo0w8wRmIcIIdH1flQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hqBjlZGX7O0SAYd8yjA83Z9iEwYFFRf8gST6pyqTPpk=; b=T/SFAzAEbXvJ67uYm4f8T/5XxAjWPZVVvhqRtJxRt3cx8bC4vtw9BAX35JZTqY1NTQ0fTflFv+6ME11oS9DTrRPuEEmdxTb1+lNVD1aJx6ja49tWo+XWqFmVAp5OTLdEu7AKej6Q8eqIU3nxP4/Du42a3L4pIQWkvtK1VYqUzTR9Dq05EY60PcncSS73I4xcHJhugeY0cZJXFOUjnGXpeE0IPUSjQ2Aks9ygPKyBuj83WkgEuIo9nl2za3+m6PK1r2/2PgjvicMayv6GNXmZGQ1tylYIRCKO5VflRrrLezzQg0NhmySFFCUNjvX5N2Tt17yKx8jdjQaOrGaPCAmnvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8919.eurprd04.prod.outlook.com (2603:10a6:10:2e2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Fri, 22 Sep 2023 07:52:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%6]) with mapi id 15.20.6813.017; Fri, 22 Sep 2023 07:52:04 +0000 Message-ID: Date: Fri, 22 Sep 2023 09:52:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 1/2] x86-64: fix suffix-less PUSH of symbol address Content-Language: en-US To: Binutils Cc: "H.J. Lu" , bouanto@zoho.com References: In-Reply-To: X-ClientProxiedBy: FR2P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8919:EE_ X-MS-Office365-Filtering-Correlation-Id: d1d473a0-123d-41ef-38f7-08dbbb40d020 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nwncojU6tyNtyKbwbULgEaka2vRXRyGv9vCTddNqfJ7TbMyF31PU+FTjC2XdpCgCWE2xhr4rVGimgsZCvm021O1gr26EpdAe0BSDuW6LcHH8w5zKcAdwA7YGFJYxaiA0UDBY6i+J1on3D0cl4yxH1Rn4uBoT7FkdCZ5wOhvNjEnFxiMhIrXditVLzPDHFgTxDLyejK3dF/r2/+DbYQSM206pIsuprECrx0AoeyBr4BwCdFYWLXBeoiImYZI+utUdMwiMLqNKPLp6vQvAPZDpAVJQPdPHd3nwsx/IEIve4B9Oe7K3nikBlEcw5mhwm5KgonbB1s7VNhwwfPSfXs/gB/GD0eMXlmPTxxK4zryLD0pniVhtm2LHaJL7jNnnL3cXH2euEePwd/KwN01iQXDjdXB0BBeZ6NsMjziC9DkfudIUH3ik73tdugIVBADeW0e5LDxsEQZB6AdlieZ7lvZY/Oe8ShTjmjKhhEU8eucLdiqnSZ59PY7v0SBKlOIDmuPKgp/hADd1YTESnVrSTXGeZHSKfzNMWdDnNlBb+KdeN+cMIt3GBxIc1iAiZy5RDAjYdkZg8zC4gIZoipmM7bovTXCaPpx1ikJmKllFwKmUCHQNpf5pZp44qgU4yIZrL7XKcM1du0GKinmfG0YrQgT5Eg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199024)(1800799009)(186009)(38100700002)(478600001)(8676002)(41300700001)(4326008)(8936002)(5660300002)(6916009)(66899024)(66476007)(316002)(66946007)(66556008)(26005)(31686004)(2906002)(2616005)(86362001)(31696002)(36756003)(6506007)(6486002)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?2n/S/n66ojSFNsSL6yQPELoL53yD?= =?utf-8?q?7seVMLGs/b7th/GUhdzTY6aoVj06okKY8nIjr8nHPBZK4Ta1ZIyGPt36Y7NBhNNvd?= =?utf-8?q?l5J8yIume+u/sqJD4uZqy2HBf/zhXDY2Hiaol3dg6nzY71kXG1J0yUutv5hCBlYQI?= =?utf-8?q?W8GOHscRMXWLG5JDooPfKyg5mY8Aq+OMdGa8yTd4/Rx4Ih4tffQ3haktNsOyMqheD?= =?utf-8?q?vrFkQ9lXps/q/TcSU9MxtxeuBBjNGobREdvkV97EyhrXEGQ/LpRMhgN5sdMIfkjve?= =?utf-8?q?6eFRxyIJD5CQPSBUv1hmgHo5Zi+CzlovEfOF0qOPgNUOXQa/6N7XQ1CCcfmMO8ck5?= =?utf-8?q?B+qIVq5S2xirjdSJf8x000uIOxe4HjSCETZbSIYxsmnCKDf1YHGa/2j7w7R1YC02H?= =?utf-8?q?5XfQGHNJknyDyUP1om5snf6ZqDTc2ul4sMAlREyfLXGVkIYsT8SjgSExjUREGe8x0?= =?utf-8?q?PXKCEMVA3ryjGNB9bEUDwqlPQ0NC9drD0uVKeMbpUrBdhbm/7xSUS17Yu0DCqIu3p?= =?utf-8?q?N6Mv7p8RWLSoVHebCKboC5JvsWfh66dgQs68Wsu5OvqAgnBHd6H4aVlp0NGZ0aJnm?= =?utf-8?q?Uj9AstxjltiJifzPHhp9cQsiF8yxPctSj20rBMk+ruH3CV7nEHOViNVD0UuwTiVzU?= =?utf-8?q?q4ETFd9q6K4fdB2bB1kG+ceXf2nqZl5bwpXE8YJ3OPEW5y868noTPzOfIkGHL5/wE?= =?utf-8?q?nILzTXENHPwp5iM1tUKtvGEjb0twFvLKflteE5SlrMS6Uj5AfVQTjfWMDZrvEW7HQ?= =?utf-8?q?o6xEgva9XDLNqo3C6F8ldwIHVwUEwOJ+RLkHcCWiQw+3QTV5Nrs0xqYPkUfD7yFR7?= =?utf-8?q?YN7u81hqxG1UpfwX33NN8msxmO1cghJgY1ABJ1GleW2ihI1o9BVuTIdhbF/NxVpZJ?= =?utf-8?q?ObuBn68V8XGDaic561vgQ+E8ep80EMay8BlAOa2LR8YEEYDqts2Bmed0lTOLZ3xQ/?= =?utf-8?q?etbQfHqlp9x8YDJUJCIUEaL+5MgTn7jYW0KwlDnIQG9nLZimMwShQjX+aNlZC3oUI?= =?utf-8?q?k35eHlDdCBwm7VlMTGqi+LoSj41Bj8xMJbBvSNJIKpdUKGyS2M8wDA5Uj3nyz3Pqh?= =?utf-8?q?apj43/ZLRrAMPskLsxO4Eet357P6eR7fM+Brim328ZUMc9HcfKGR2NO9kWcPfoox4?= =?utf-8?q?DZE/q/NrjTV3JYGlZ9Vbu4NRei3mIl+Es450AjCWMJiPxSPsXj/y48hZncBhLsgGL?= =?utf-8?q?NrqK2I3i8whSr44eFVc8SNvrRhAlHrwgku+IyTvcbJ3k3zU9ZYM/nIjriz1jeTi85?= =?utf-8?q?CSc2S9pyv0P2aZEQxv+pB2fCZkVu/P9+YSm8OPAXl6VktCYeN6f6WG3LTURl3DBPw?= =?utf-8?q?LYq8iYuWV9s5WhjKcDBEzWGUA3vwkkYi4oZC0Vqg5NtRoDSx+jlObK1Z83eZfssFl?= =?utf-8?q?DFDzpaUeegVDTKq/DGNCxRwlQjHOiLFPOxq4qbx3/T3WLYNxhbVKVUuA2TTyd93Sn?= =?utf-8?q?IMBCM56aMOXLpZ5jP7KtorN+ploJbKo9SduLybbzx0H5GSC95h7KSpRGsKSzH1PZT?= =?utf-8?q?W1nX/srOCni4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1d473a0-123d-41ef-38f7-08dbbb40d020 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 07:52:04.8427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A4hak4Tj3md/E5H5wTptYRH47zpeD5wEOrc45V/KQJ/xe+nP793c+pRU2eARvNOyhRaM8hR7TXoO3oy9ktqunw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8919 X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Sender: "Binutils" PR gas/30856 In 5cc007751cdb ("x86: further adjust extend-to-32bit-address conditions") I neglected the case of PUSH, which is the only insn allowing (proper) symbol addresses to be used as immediates (not displacements, like CALL/JMP) in the absence of any register operands. Since it defaults to 64-bit operand size, guessing an L suffix is wrong there. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -6214,7 +6214,12 @@ optimize_imm (void) } else if ((flag_code == CODE_16BIT) ^ (i.prefix[DATA_PREFIX] != 0)) guess_suffix = WORD_MNEM_SUFFIX; - else if (flag_code != CODE_64BIT || !(i.prefix[REX_PREFIX] & REX_W)) + else if (flag_code != CODE_64BIT + || (!(i.prefix[REX_PREFIX] & REX_W) + /* A more generic (but also more involved) way of dealing + with the special case(s) would be to go look for + DefaultSize attributes on any of the templates. */ + && current_templates->start->mnem_off != MN_push)) guess_suffix = LONG_MNEM_SUFFIX; for (op = i.operands; --op >= 0;) --- a/gas/testsuite/gas/i386/immed64.d +++ b/gas/testsuite/gas/i386/immed64.d @@ -24,6 +24,12 @@ Disassembly of section \.text: [ ]*[0-9a-fA-F]+:[ ]+48 b8 04 00 00 00 00 00 00 00[ ]+movabsq? +\$0x4,%rax [ ]*[0-9a-fA-F]+:[ ]+48 b8 08 00 00 00 00 00 00 00[ ]+movabsq? +\$0x8,%rax [ ]*[0-9a-fA-F]+:[ ]+48 b8 00 00 00 00 00 00 00 00[ ]+movabsq? +\$0x0,%rax +[ ]*[0-9a-fA-F]+:[ ]+6a 04[ ]+pushq? +\$0x4 +[ ]*[0-9a-fA-F]+:[ ]+68 08 00 00 00[ ]+pushq? +\$0x8 +[ ]*[0-9a-fA-F]+:[ ]+66 6a 04[ ]+pushw +\$0x4 +[ ]*[0-9a-fA-F]+:[ ]+66 68 08 00[ ]+pushw +\$0x8 +[ ]*[0-9a-fA-F]+:[ ]+6a 04[ ]+pushq? +\$0x4 +[ ]*[0-9a-fA-F]+:[ ]+68 08 00 00 00[ ]+pushq? +\$0x8 [ ]*[0-9a-fA-F]+:[ ]+04 04[ ]+addb? +\$0x4,%al [ ]*[0-9a-fA-F]+:[ ]+04 08[ ]+addb? +\$0x8,%al [ ]*[0-9a-fA-F]+:[ ]+04 00[ ]+addb? +\$0x0,%al --- a/gas/testsuite/gas/i386/immed64.s +++ b/gas/testsuite/gas/i386/immed64.s @@ -19,6 +19,12 @@ _start: movabsq $early, %rax movabsq $late, %rax movabsq $xtrn, %rax + pushq $early + pushq $late + pushw $early + pushw $late + push $early + push $late addb $early, %al addb $late, %al addb $xtrn, %al