| Message ID | b8d583cc-7932-4c63-b96c-c60c7fae55b4@suse.com |
|---|---|
| State | New |
| Headers |
Return-Path: <binutils-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 85AE24BA2E0E for <patchwork@sourceware.org>; Fri, 24 Jul 2026 10:16:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85AE24BA2E0E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=XIwKV7YN X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 252CD4BA799C for <binutils@sourceware.org>; Fri, 24 Jul 2026 10:14:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 252CD4BA799C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 252CD4BA799C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784888071; cv=none; b=cijUHqTNz2SukEikATbU/rKNvR2uZtjUb/aU+FHKAy0C73Y4SWyFx9P7vPfuoyyzsE5enBlwfiYeVObPCDZ/3G08SIDQ7nm4CM0s64hcdwgD++UFbfbpLvzatotpux6707LxcpnzIl6Ompw2V0M1B3/rTHNIw6qw1e7OFluia/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784888071; c=relaxed/simple; bh=uVej0CDDMRWG5QQI+h39t+wqGo+CCIc3Flutd8+PwiM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=Lvdng1/d/mUM4ZyLCWTAUEaSEmkJcHZXlddYQyqz97VClbYcr9E/CWdQs8cawALqwdoHPD+TdzYgwdWKv84Iv1k7H8K0u+XvByUJLjJ8gqaLVzqRaslumK3cJ9uBxL7u4hM9TVf5BqVqFLq3hWvGTCP1UnNh4tCsZmnEnMfYfOg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=XIwKV7YN DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 252CD4BA799C Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso2014215e9.0 for <binutils@sourceware.org>; Fri, 24 Jul 2026 03:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784888070; x=1785492870; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=UG1+sCX0xXHoaE34Sr3udFV3p+dqyZ5/gduKF4SOodg=; b=XIwKV7YNnu4zsyZr/gzraVZBZQRiXPwjMt3zTWjAX8WV3+vnoT6UoCG6Csp/sab8WZ DXgSfAsbraRyuIahpNdMWLsqhoDG75pubqp5U0JQq2JKsAgixbfJ5QRD6HMUW6Z61Ygi +Q++SpivIdprT73YVItO5siLQdF6uGx1PfXq4/quXIeaz5UyWAAD/ZQg5xjxJMYbO0XW 8pV/BA5R5diw2/VKKWdnL5h8e+JHGPLk2Z8RbfJLF15XkP6g6RlBjFDU9QoLttlrhgLL lur3CHcge9u69Ig5oBzH8/FO1XtrM8+Z+OugVS7IWGDHnSgeojJ8FDBLVekZGC4K5Lxs DXqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784888070; x=1785492870; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=UG1+sCX0xXHoaE34Sr3udFV3p+dqyZ5/gduKF4SOodg=; b=TOIYUkiANON4Jl1tovsrfyFq8/AjsH132NJ2WiF8ZLqasxSDicG6SgwNe4PD4ilmmR MeiIc1YoGFHR0DSZr1a95d61OGT5+CUVHd70xJpkyHXa3Yr4cLqjPJ3GV2Z1hPyPI01J vB4efTY5yhvpvX0wSEWdpmRUDEITv9nd8W22h0rysqxVjahZ6WO7Nq8uWYCYy92wM8rQ 0ALLqw7eMalgqd97R6B6KdDdl/bfUKpS951t+FMZTccboTmaEoV0LOdEeS8lHjhizkv3 9LHwEsZfD16pcx4qMpMdOSKep3FwEyChIiCWVbvyjnuVLlpxRqhk6jyJjHng+uOG9ETO pJjg== X-Gm-Message-State: AOJu0Yxe4A2wbjbaTWtg298lRfMSrwOFwMLaKeGQbXA7nLU9jhjSZ0zg GWnWy1V9FIRz7L148I2icLuj3BfgKEYlFS/nDtv0WiPEkOPdubttPkxQJYJuhqmHPfSXQ8pweov ylsITtg== X-Gm-Gg: AR+sD10sXZettUL//pAKXlmMy/x5jBZeCV1UEpqg/X45IM4I7MIZnpe+ticii2Y544r 9JGEGi/svR9ck13+OCLRVxKt0/Gg6MXKxTo5iLlhG88lDkXjXSX5AvDTTlVdm10Didnn4gs7j+I kiU2APmAhSNMUzulqEUwdvluhi1GDwoJC5UyqjUYGkj3CW9tV2sJx8ZbMPIDOoEyv+FuY7RagMQ QOqlR5kllKfZBhg096QTD1kQdP2wu7M/OTTbxuys1cVyXIJtEtCrnuB5OVskN6EpA2oVB9gDt4m EDsbauMKgeinn8tTTe2q/lpESURv1z7eu94J9GQsKJyudt7USRZDlYYh7t6Cl/BDoaxmz1SZTOL kFeNa8O3DTebwoVIUloD/pdPnOg2VZmPjLpxtm+6Wik9x+TbHyThWaGvt/Tf3Oz/ZUrj3wc7+yN af7xyoOSstsls5GETHJofQlXX+JOtjtZD9PoDFH7IZIu4A3YY3xz6y8xtP33W+usZi2g== X-Received: by 2002:a05:600c:628f:b0:495:4730:281d with SMTP id 5b1f17b1804b1-49573cf0d50mr71058395e9.35.1784888069978; Fri, 24 Jul 2026 03:14:29 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957bd9e980sm38718435e9.0.2026.07.24.03.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 03:14:29 -0700 (PDT) Message-ID: <b8d583cc-7932-4c63-b96c-c60c7fae55b4@suse.com> Date: Fri, 24 Jul 2026 12:14:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/4] x86: correct operand_types[] used in build_vex_prefix() From: Jan Beulich <jbeulich@suse.com> To: Binutils <binutils@sourceware.org> Cc: "H.J. Lu" <hjl.tools@gmail.com> References: <4bce97ee-c8d1-44f8-8c61-4ec3a5b91b4f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <4bce97ee-c8d1-44f8-8c61-4ec3a5b91b4f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3015.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org |
| Series |
x86: operand types handling in gas
|
|
Checks
| Context | Check | Description |
|---|---|---|
| linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 | success | Build passed |
| linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 | success | Test passed |
| linaro-tcwg-bot/tcwg_binutils_build--master-arm | success | Build passed |
| linaro-tcwg-bot/tcwg_binutils_check--master-arm | success | Test passed |
Commit Message
Jan Beulich
July 24, 2026, 10:14 a.m. UTC
While benign at the moment, using t's ->operand_types[] isn't really correct: Closer to the top of the function we may have installed t[1] for use by the insn. Hence we should also use its .operand_types[], which now are in i.tm_types[].
--- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -4402,8 +4402,8 @@ build_vex_prefix (const insn_template *t operand. */ vector_length = 0; for (op = t->operands; op--;) - if (t->operand_types[op].bitfield.xmmword - && t->operand_types[op].bitfield.ymmword + if (i.tm_types[op].bitfield.xmmword + && i.tm_types[op].bitfield.ymmword && i.types[op].bitfield.ymmword) { vector_length = 1;