From patchwork Fri Nov 22 12:40:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 101742 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2E0553857B98 for ; Fri, 22 Nov 2024 12:45:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E0553857B98 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=QZsv2x2s X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 9A873385773A for ; Fri, 22 Nov 2024 12:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A873385773A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A873385773A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732279205; cv=none; b=eaCSWaDkuGfY3qw/AruaNo+UQb1ENC81dLVeeSmhOre33qHPU0F1bkSbIkeu1XcRf1c7ASj+AMnFKydQrnkmpi0J5igPeoWYxcxGF9nfCuxRebpyt8j62gEtQNJ0mh3CFZM4iXg7qPERNwc3kJElVb5aGBWLpNd5tsu0C0WlirQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732279205; c=relaxed/simple; bh=hAz+RGJUUth2m8pJ/Bpsu9uXXlOU3xOlg5YCATK633o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=COayowt7eb1mlafPl+ODzIK49po7Pb924e7d46nE4cLhE/k1/o9KcqvhOYD9/OumeWGONJqtGxRkcEDaAWFKrzjS+bpY8f+A9wYqGts8PCdsvrlW2g4XzoLTATWVcjRSsldw/OBRMQ0ylzfMbUgutH3VoX6SlC23IwI8QP6i2tQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A873385773A Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5cec9609303so2349671a12.1 for ; Fri, 22 Nov 2024 04:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732279204; x=1732884004; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WchuXyW+dqwPRnIJvYMuXOQlrWUAFghgShW9SVjaAJ8=; b=QZsv2x2s3/g9IAwm2u5fXE3Ca33QmJCbTRNFVjmd062N0F0cRckN+agF1fgMgv+ycQ euBMPAW9nBVKsEp/0GsTBQH4Oqf017OsoaLR38vc6ZFS0qxI9SAol9yG5MloTbaC+DVY WxHnMNbNd+Lnwh7vqq3KEJ2JhgczHAdmTulJ0cE3weEtGli/jlUtdfy4+y6xKytpq73o 8AD0hjhMpgfSNfhCVwejsasQjA4inzKjrSVcurVm/0V1q91FXByt5dSsofHNN9hVtiQ9 jTsaRt39OSi+z75kE4qTXtK56gq1Eeshfo1BHtPaI419hflXnhJCXbeIUsZ88Xy/h/IO z5Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732279204; x=1732884004; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WchuXyW+dqwPRnIJvYMuXOQlrWUAFghgShW9SVjaAJ8=; b=Tb2ttvWVOP7ITwRBHpBDpQtr0Bf0uRBISWNRe51VokIv+/W78j2L6UeuE4zGjorTPx I3uiLA8EJ5GNZPSOB9Zz6jBWN58A7SKLBPDF4vPoT0shsg/On29wbQlDKl0a83/pfZxW r96YAWRDxHYqcHCrNqLgw3LMd29p9jXSDM1TOLTQPpjthc7Pi440HOy5bv0ZmVUuwvIA GW2vetlkbA8MQCku8dcB+NHzRCDkZ9rBggSJoxjeOv3+pswdZ3eCpVLDQ0Ew/IYFmhv0 eYrPJ0APYtoYkpmnvQxjPcVC6Y2SrwC8AhLQM9Q1Ml/Cn+x09/hoLKKcO3aJ71cfb1pl KqBg== X-Gm-Message-State: AOJu0Yw7/n+XzTiMsVjW8U+FDKqw2QzurXoNLONuq0Os1Hx1WuGxsNYS vbCoF17sngLWocd7B4HmCE837i5GmkycVUWrxduoJ4p6OTCPD2W4rtBTKFK4Nl06BLU3XIf/xF8 = X-Gm-Gg: ASbGncsPWAJ+tftoE+QZkRuAieIcHoOLoSogCKIz1QOXZaHdJ87yRXlcJl3ijo80RZA C9XfiUxOsr1yUB189SI7BytNASAGfT39tSOMJXp0Kd6VjLCyDerzSNqYBqeeQac6WR58VkQ7Hfh 5bmFeyQ4h/z/OvdSROwoqBY6wIKiEdxgs8P61DtMKldN98/lz9phmsD3nET09nx/jdDh+KBlrlY AdeeYBdm8tfsLNd6hQSXGlg21iKCC0Rwg05ZsUNoaFv6Ws6tba/IVLqrgbIuJ+ljJMCGDDOoz7x DLuLPmhg9xRMZALgVvm+m+TT5aU/OMPoJUk= X-Google-Smtp-Source: AGHT+IEHrQyRPXI2rYEMNCDcAIRJAhuebKgZP5fpE6xHrH8wUCgaNMBtT5pQs317xx5qJKA836rpXQ== X-Received: by 2002:a17:906:cc9:b0:a9e:c460:ef4e with SMTP id a640c23a62f3a-aa5099f9c00mr246234266b.32.1732279204045; Fri, 22 Nov 2024 04:40:04 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa50b5b990dsm94216066b.201.2024.11.22.04.40.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 04:40:03 -0800 (PST) Message-ID: Date: Fri, 22 Nov 2024 13:40:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/5] gas: streamline expr_build_dot() From: Jan Beulich To: Binutils References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org There's no point involving symbol_clone_if_forward_ref(), just for it to replace dot_symbol by one obtained from symbol_temp_new_now(). For the abs-section case also produce a slightly more "complete" (as in: all potentially relevant fields filled) expression by going through expr_build_uconstant(). Move the function next to current_location(), for it to be easier to see the (dis)similarities. Correct the function's comment while there. --- a/gas/expr.c +++ b/gas/expr.c @@ -193,17 +193,6 @@ expr_build_uconstant (offsetT value) e.X_extrabit = 0; return make_expr_symbol (&e); } - -/* Build an expression for the current location ('.'). */ - -symbolS * -expr_build_dot (void) -{ - expressionS e; - - current_location (&e); - return symbol_clone_if_forward_ref (make_expr_symbol (&e)); -} /* Build any floating-point literal here. Also build any bignum literal here. */ @@ -754,6 +743,24 @@ current_location (expressionS *expressio } } +/* Make a symbol for the current location ('.'). */ + +symbolS * +expr_build_dot (void) +{ + if (now_seg != absolute_section) + { + symbolS *symbolP = symbol_temp_new_now (); + +#ifdef tc_new_dot_label + tc_new_dot_label (symbolP); +#endif + return symbolP; + } + + return expr_build_uconstant (abs_section_offset); +} + #ifndef md_register_arithmetic # define md_register_arithmetic 1 #endif