diff mbox series

[committed,v2,5/6] i386/Haiku/GAS/testsuite: Suppress SVR4 comment character test

Message ID alpine.DEB.2.21.2604072231330.29980@angie.orcam.me.uk
State New
Headers
Series None |

Commit Message

Maciej W. Rozycki May 9, 2026, 2:42 p.m. UTC 
  Exclude the SVR4 comment character test on Haiku targets, as `/' is not 
a comment character there (cf. gas/config/te-haiku.h), so as to prevent 
a regression caused by enabling ELF tests with Haiku targets:

i486-haiku  +FAIL: SVR4 comment char escape handling
---
On Sun, 5 Apr 2026, Jan Beulich wrote:

> On 03.04.2026 15:16, Maciej W. Rozycki wrote:
> > Exclude the SVR4 comment character test on Haiku targets, as `/' is not 
> > a comment character there (cf. gas/config/te-haiku.h), so as to prevent 
> > a regression caused by enabling ELF tests with Haiku targets:
> > 
> > i486-haiku  +FAIL: SVR4 comment char escape handling
> > ---
> >  gas/testsuite/gas/i386/svr4.d |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- binutils-gdb.orig/gas/testsuite/gas/i386/svr4.d
> > +++ binutils-gdb/gas/testsuite/gas/i386/svr4.d
> > @@ -1,4 +1,5 @@
> >  #objdump: -dtw
> > +#notarget: *-*-haiku*
> >  #name: SVR4 comment char escape handling
> >  
> >  .*: +file format .*
> 
> I don't mind moving the exclusions here, but then please all of them.
> Right now there's an "if" around the test in i386.exp. A patch with
> all exclusions in a single place (not matter which of the two variants)
> is pre-approved.

 Umm, I missed this peculiarity.  Using #notarget has the advantage of the 
test scoring an UNSUPPORTED result rather than disappearing from the view.  
However I can see virtually no such usage across i386.exp tests, with the 
only outlier being quoted2.d.  So I chose to follow the common pattern.  I 
have updated figures in the 6/6 commit description accordingly.

 I have applied this change now, thank you for your review.

  Maciej
---
 gas/testsuite/gas/i386/i386.exp |    1 +
 1 file changed, 1 insertion(+)

binutils-i386-gas-test-haiku.diff
diff mbox series

Patch

Index: binutils-gdb/gas/testsuite/gas/i386/i386.exp
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/i386/i386.exp
+++ binutils-gdb/gas/testsuite/gas/i386/i386.exp
@@ -899,6 +899,7 @@  if {[is_elf_format] || [istarget "*-*-vx
     if {![istarget "*-*-dragonfly*"]
 	&& ![istarget "*-*-gnu*"]
 	&& ![istarget "*-*-freebsd*"]
+	&& ![istarget "*-*-haiku*"]
 	&& ![istarget "*-*-linux*"]
 	&& ![istarget "*-*-netbsd*"]} then {
 	run_dump_test "svr4"