diff mbox series

[5/6] i386/Haiku/GAS/testsuite: Suppress SVR4 comment character test

Message ID alpine.DEB.2.21.2604031331130.29980@angie.orcam.me.uk
State New
Headers
Series Haiku/testsuite: Enable ELF tests |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed

Commit Message

Maciej W. Rozycki April 3, 2026, 1:16 p.m. UTC 
  Exclude the SVR4 comment character test on Haiku targets, as `/' is not 
a comment character there (cf. gas/config/te-haiku.h), so as to prevent 
a regression caused by enabling ELF tests with Haiku targets:

i486-haiku  +FAIL: SVR4 comment char escape handling
---
 gas/testsuite/gas/i386/svr4.d |    1 +
 1 file changed, 1 insertion(+)

binutils-i386-gas-test-haiku.diff

Comments

Jan Beulich April 5, 2026, 6:44 a.m. UTC | #1 
On 03.04.2026 15:16, Maciej W. Rozycki wrote:
> Exclude the SVR4 comment character test on Haiku targets, as `/' is not 
> a comment character there (cf. gas/config/te-haiku.h), so as to prevent 
> a regression caused by enabling ELF tests with Haiku targets:
> 
> i486-haiku  +FAIL: SVR4 comment char escape handling
> ---
>  gas/testsuite/gas/i386/svr4.d |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- binutils-gdb.orig/gas/testsuite/gas/i386/svr4.d
> +++ binutils-gdb/gas/testsuite/gas/i386/svr4.d
> @@ -1,4 +1,5 @@
>  #objdump: -dtw
> +#notarget: *-*-haiku*
>  #name: SVR4 comment char escape handling
>  
>  .*: +file format .*

I don't mind moving the exclusions here, but then please all of them.
Right now there's an "if" around the test in i386.exp. A patch with
all exclusions in a single place (not matter which of the two variants)
is pre-approved.

Jan
diff mbox series

Patch

Index: binutils-gdb/gas/testsuite/gas/i386/svr4.d
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/i386/svr4.d
+++ binutils-gdb/gas/testsuite/gas/i386/svr4.d
@@ -1,4 +1,5 @@ 
 #objdump: -dtw
+#notarget: *-*-haiku*
 #name: SVR4 comment char escape handling
 
 .*: +file format .*