diff mbox series

[4/6] Aarch64/Haiku/binutils/testsuite: Suppress PEI test

Message ID alpine.DEB.2.21.2604031325370.29980@angie.orcam.me.uk
State New
Headers
Series Haiku/testsuite: Enable ELF tests |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed

Commit Message

Maciej W. Rozycki April 3, 2026, 1:16 p.m. UTC 
  There's no PEI BFD target included with the Haiku target configuration, 
so exclude the EFI test, preventing a regression caused by enabling ELF 
tests with Haiku targets:

aarch64-haiku  +FAIL: Check if efi app format is recognized
---
 binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d |    2 ++
 1 file changed, 2 insertions(+)

binutils-aarch64-binutils-test-pei-targets.diff

Comments

Jan Beulich April 5, 2026, 6:41 a.m. UTC | #1 
On 03.04.2026 15:16, Maciej W. Rozycki wrote:
> There's no PEI BFD target included with the Haiku target configuration, 

Would you mind adding "by default", as people could always enable it as
secondary target?

> so exclude the EFI test, preventing a regression caused by enabling ELF 
> tests with Haiku targets:
> 
> aarch64-haiku  +FAIL: Check if efi app format is recognized
> ---
>  binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- binutils-gdb.orig/binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d
> +++ binutils-gdb/binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d
> @@ -3,6 +3,8 @@
>  #PROG: objcopy
>  #objcopy: -j .text -j .sdata -j .data -j .dynamic -j .dynsym -j .rel -j .rela -j .rel.* -j .rela.* -j .rel* -j .rela* -j .reloc --output-target=efi-app-aarch64
>  #objdump: -h -f
> +# No `pei-aarch64-little' target support for Haiku.
> +#notarget: *-*-haiku*

I understand you're only after the one target, yet it looks like if already
we're excluding targets here, we might as well add a more complete exclusion
list (as per bfd/config.bfd)?

Jan
diff mbox series

Patch

Index: binutils-gdb/binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d
===================================================================
--- binutils-gdb.orig/binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d
+++ binutils-gdb/binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d
@@ -3,6 +3,8 @@ 
 #PROG: objcopy
 #objcopy: -j .text -j .sdata -j .data -j .dynamic -j .dynsym -j .rel -j .rela -j .rel.* -j .rela.* -j .rel* -j .rela* -j .reloc --output-target=efi-app-aarch64
 #objdump: -h -f
+# No `pei-aarch64-little' target support for Haiku.
+#notarget: *-*-haiku*
 #name: Check if efi app format is recognized
 
 .*:     file format pei-aarch64-little