From patchwork Sat Jul 4 10:55:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 138475 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48E874BA9012 for ; Sat, 4 Jul 2026 10:56:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48E874BA9012 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=RHd++jwC X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 0D5164BA79B7 for ; Sat, 4 Jul 2026 10:55:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D5164BA79B7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D5164BA79B7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783162544; cv=none; b=HkW4gw8d19QA9w5bczK/x0ciEgXLgVFhRUD7oKP3Ov54Nnmdid3VOtpTsViVvwHyR4L+yY1i/7rWAP/70U4lMKkyqKRoVzRC8E/NMhwBKzY/4vSL2jyPQaNQBjC59H5gNxlHrdatqcai7Vse2a0/+Fda38bYOthbN1JAREp6kEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783162544; c=relaxed/simple; bh=TvVHgmG256YFLw4l3qSjScKPUvNs5xY/P6gtDBaWfFs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=mBE/JZaAwd66uLbeWmyNtInMtKueue+uOhqskzMbUvLbAoUYyfbZIdfZ7pcJCULOBuoHI2YJPKCSYmVR3ZgD2fPULfGbvIEvdLrVLzX6ahIupN7KSisp/5TeYomRN3qRkulLkQJrjcjYg+kV9b7h0nAFTDBxCCqyrsWjXPtZNLg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=RHd++jwC DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D5164BA79B7 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-c85b73ffb52so667651a12.3 for ; Sat, 04 Jul 2026 03:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783162543; x=1783767343; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=sOpwp8ViUC9XBNU2+hM0fNIbvk3gesRNnwrreMjhi7g=; b=RHd++jwC8p5WwEr3SagC/W63d8Ah7VUnV3W99NKZJ51t5xckauCQERHxQUt5NsElBK Q70Rfw4SYYzgO+d6Mfjo8o+0FsaWLXRA3cIhBGa4xVGkpm+hl6rA0SuEWZrytdY1vkGc Lq556LR4MuxVcYWGjbZkQM21NyCVtwK6fYJVVfv+DBCNWaHajQ3ZIChhZP8+xPNfbNCM 3Vt8qRLEGnNdKmVCPrqaeKirxnO8o4LR0EKd0d6mbQaxcxI7LhraSNGBFJ7m6ak8kCuz dKb7jGpRpBP+OuGLeLI+mA9q8w5RCJXDUdXIdZW3ApjgrEHpPGp7ahi05BBW5xs2YCLP vZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783162543; x=1783767343; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sOpwp8ViUC9XBNU2+hM0fNIbvk3gesRNnwrreMjhi7g=; b=Q51mbOTF3ZQyyHpMYaBQKPRoCfiru9xr/S7rtxTatn7hztCpky1vuZMu+i3dYRgpQJ S2zZd0a3zeh8JSmuPC0TwolbSCwVxpRoIrQ0WkvuEKKx8IjhDbDwuDdFdUFzqDhOsH+q Q28Y4QpeF6DnNb2ZD90TcBKcoAmdQCM6dQL1lcpBof8RO38nV2XcyZ7HONREZD2ukpUK YLTPqGQ+rGkncN2VGlCNgBp+NF1YCympMeL42AAMiGe23QIY52Iab/mwC36vCiRnBcC3 gA9ErL/FHEJzsx7fbrFq1G9RQ+qIeRNScI0lfQK2beInP2lFhkguiFUn/Ln27fu9xv20 qx2A== X-Gm-Message-State: AOJu0YxdNfjvqbrfhem40XNx5JWsJDhN0oJlWR3J5ZmomOf1k+3WSByl XbDAST8TP4SOTkVvwar2ODL5T+63P9ywFvtVfAnEHNdZBmtAX1T6Hrf/8+G7Hg== X-Gm-Gg: AfdE7cnK2gWkBAysdiYBLaRxPF1cIr+z8wcObUN1Q52aW7vGPV79383dECi4t0aiiBp 1SAqNyuFn4zxw64bbHtKhR/2wI1KDCqZ74QoYHanMFuUyayuzSGEfmSuRHg+Vzx2TwGUH1Gwxm5 h4ZRhlFg4qfR90UN79fh4CxnQ8Kl8lGIUpSnaWB7iW0hbL6Sf+0ZQo0j+QIGYv5pv87nLiMqMBz rz3TBG0JlYP+IDD8HINDUt6H/pLNUWRLr63mj5W2O/WaMM8k0xP+GdW2lhk0Cm/Br1uBReTFQUp GQpC4+BboeSQQ+0Di2cwp7IDYWn/gM4Tezqd1cdfZuxdEf8VEtzoe2ACe2Vfe0kmOpKVMMBNNrv TDVPI8pH6iYo7XhKj9n/OmCR94bzxfU6WX0YNGia/I+TqbX0RM4i5bT/EPNbuWpE7bgilBvgEHb xQw+g/wOcZDyRkmSninwYHgXzAidCIiFkikGvMUVfFYhb61i17+5T7Kg== X-Received: by 2002:a05:6a21:7107:b0:3bf:bcfa:82cf with SMTP id adf61e73a8af0-3c03e1f3edemr3461223637.15.1783162542677; Sat, 04 Jul 2026 03:55:42 -0700 (PDT) Received: from squeak.grove.modra.org (58-96-106-158.ip4.superloop.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f3d92c44bsm9374607eec.19.2026.07.04.03.55.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 03:55:42 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 1F24E11419E3; Sat, 04 Jul 2026 20:25:39 +0930 (ACST) Date: Sat, 4 Jul 2026 20:25:39 +0930 From: Alan Modra To: binutils@sourceware.org Subject: pr34322: assertion failure in get_or_create_member_type Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org I thought about warning "DW_TAG_member without struct/union parent" here but decided that doesn't help much as the warning is disconnected from output. As it is the --map-global-vars code silently ignores unexpected attributes that might be found in fuzzed files. I'm fine with that too. PR 34322 * dwarf.c (get_or_create_member_type): Return NULL on NULL parent. (insert_element_in_list): Ignore DW_TAG_member without struct or union parent. diff --git a/binutils/dwarf.c b/binutils/dwarf.c index f915495f6b3..829bcb761f7 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -2919,7 +2919,8 @@ display_member_type (const member_type mt) static member_type * get_or_create_member_type (member_parent *parent, uint64_t die_offset) { - assert (parent != NULL); + if (parent == NULL) + return NULL; if (parent->member_tail == NULL || parent->member_tail->die_offset != die_offset) { @@ -3371,6 +3372,8 @@ insert_element_in_list (enum dwarf_tag dw_tag, mt = get_or_create_member_type (union_type_list.tail, die_offset); else mt = get_or_create_member_type (struct_type_list.tail, die_offset); + if (mt == NULL) + break; if (dw_attr == DW_AT_name) {