diff mbox series

[1/3] libctf: Remove undefined functions from ver. map

Message ID a4924ddefb57e18acab76ab54aa0e73671d335a6.1709355051.git.nvinson234@gmail.com
State New
Headers
Series Fix ld.lld-17 libctf version script symbol not defined errors |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Testing passed

Commit Message

Nicholas Vinson March 2, 2024, 4:59 a.m. UTC 
  Starting with ld.lld-17, ld.lld is invoked with the option
--no-undefined-version enabled by default. Furthermore, The functions
ctf_label_set() and ctf_label_get() are not defined. Their inclusion in
libctf/libctf.ver causes ld.lld-17 to fail emitting the following error
messages:

ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_set' failed: symbol not defined
ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_get' failed: symbol not defined

This patch fixes the issue by removing the symbol names from
libctf/libctf.ver.

Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
---
 libctf/libctf.ver | 3 ---
 1 file changed, 3 deletions(-)

Comments

Nick Alcock April 17, 2024, 5:58 p.m. UTC | #1 
On 2 Mar 2024, Nicholas Vinson uttered the following:

> Starting with ld.lld-17, ld.lld is invoked with the option
> --no-undefined-version enabled by default. Furthermore, The functions
> ctf_label_set() and ctf_label_get() are not defined. Their inclusion in
> libctf/libctf.ver causes ld.lld-17 to fail emitting the following error
> messages:
>
> ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_set' failed: symbol not defined
> ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_get' failed: symbol not defined
>
> This patch fixes the issue by removing the symbol names from
> libctf/libctf.ver.

I'm throwing this into my latest series. The other stuff is biting me
too, so I clearly have to do *something* about it. Just doing the
version-script excision kludgery unconditionally does seem easiest. I'll
credit you...
diff mbox series

Patch

diff --git a/libctf/libctf.ver b/libctf/libctf.ver
index c59847d012b..a685c4e3b9f 100644
--- a/libctf/libctf.ver
+++ b/libctf/libctf.ver
@@ -80,9 +80,6 @@  LIBCTF_1.0 {
 	ctf_enum_name;
 	ctf_enum_value;
 
-	ctf_label_set;
-	ctf_label_get;
-
 	ctf_label_topmost;
 	ctf_label_info;