Remove dead code in bfdwin.c

Message ID ZhSf7pCXb41IxtBe@squeak.grove.modra.org
State New
Headers
Series Remove dead code in bfdwin.c |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm warning Patch is already merged
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 warning Patch is already merged

Commit Message

Alan Modra April 9, 2024, 1:54 a.m. UTC
  All of bfdwin.c is wrapped in USE_MMAP.  There isn't any point in
HAVE_MMAP tests inside USE_MMAP.

	* bfdwin.c (bfd_free_window, bfd_get_file_window): Delete
	HAVE_MMAP conditionals.
  

Patch

diff --git a/bfd/bfdwin.c b/bfd/bfdwin.c
index 73e44635bcb..0ef7b1418b9 100644
--- a/bfd/bfdwin.c
+++ b/bfd/bfdwin.c
@@ -118,20 +118,14 @@  bfd_free_window (bfd_window *windowp)
 
   if (i->mapped)
     {
-#ifdef HAVE_MMAP
       munmap (i->data, i->size);
       goto no_free;
-#else
-      abort ();
-#endif
     }
 #ifdef HAVE_MPROTECT
   mprotect (i->data, i->size, PROT_READ | PROT_WRITE);
 #endif
   free (i->data);
-#ifdef HAVE_MMAP
  no_free:
-#endif
   i->data = 0;
   /* There should be no more references to i at this point.  */
   free (i);
@@ -174,7 +168,6 @@  bfd_get_file_window (bfd *abfd,
 	return false;
       i->data = NULL;
     }
-#ifdef HAVE_MMAP
   if (ok_to_map
       && (i->data == NULL || i->mapped == 1)
       && (abfd->flags & BFD_IN_MEMORY) == 0)
@@ -249,9 +242,6 @@  bfd_get_file_window (bfd *abfd,
       else
 	fprintf (stderr, _("not mapping: env var not set\n"));
     }
-#else
-  ok_to_map = 0;
-#endif
 
 #ifdef HAVE_MPROTECT
   if (!writable)