From patchwork Tue Dec 5 07:49:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 81351 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8DA7A386189D for ; Tue, 5 Dec 2023 07:49:28 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id 54DA338582AE for ; Tue, 5 Dec 2023 07:49:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54DA338582AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54DA338582AE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701762554; cv=none; b=faIq0DNEE1PGn3A3VRDfel99GPVz8rYOQ53fjuBwYLKaBZFdJWsYQYC0WmClss+6XJx/V1kJM/+FR23kXFkCxH+ayxKMIYPALSfhbmLWC2BdvlrxlPMRjyEueDAZuhVcHDEBHCWxuzr/i4LpS5wmWAUSYo28E+cxB0dWK8cXhmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701762554; c=relaxed/simple; bh=H70aflAkc90FxzNN6VLMv2cfqsTN9Fwg3tZOHR+Zlqc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=qEIZR8+WD6G9XPCV7pL18odEySXuz8wal6/S96Z8AD5x374AfxC2RvkcJFMbMFrcfykgb5KsBd4yX55NlM3I7FaFN2E1opWc3/S5HQGg+FdQ3o1A8c2GA6OJTuerz3f3PVUfHmtVTfnzBSfPpE+t89ObiHzeq5ffUvsz6YNPWvY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-58d7d58ab7fso3256447eaf.2 for ; Mon, 04 Dec 2023 23:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701762552; x=1702367352; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=EOFLVLhAwvqil/+g/QVJldx2EZxQb2RY4DQKqkIVxI4=; b=dkRjI7QMziyVavZ0KTc0R1LMp8D72fgOcC2sWlxQTLZrn7IuNEf8/HFKrMTb315lAN nYAd6g0Om3aicOpLHM7uBBVaD6SWfV+j2geesulQ8ZUIyqqJzfWpTwKxbt1/GiCQP6P5 adMiEneVaWMy1bQTlnadUWdDAHxtbAvbeBGq9/52Gol/jeKhNyF6ZUxZ4l+rFsFsWsfr JzDHuWBVivIod2uoUMtK42zOxaWCKM2V124vvr6D7I1qcYo+L+Wnwcm4hj5tUgIk2iHV PMnEBCLy34KJaOP5fxEk0uT27AK32qBkTHFLD3IhumjSqKY5h3okZwmRoXXIIcxkOPHy eUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701762552; x=1702367352; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EOFLVLhAwvqil/+g/QVJldx2EZxQb2RY4DQKqkIVxI4=; b=D71CfkSDNRZpn4q3ut+CSR8lxRmi2cKkmdrChl2eQQKhghXQheDytPphjsCtLuL8TH 79Ovd3JGDbqo7wptHFsWib20l946xQ2rPt9iOkaPAIuXbhPdlOcW9crWYazdLBmpaVE2 Pjmz4T4Y63VOKPcD5RzBaGDiYmUvgUTCqJgbhF4yhrIt+lIPrk2UhihN4R26O2UTSe1h 8zWxLvxEsYNWlkSezuCEIWfG1XPnASMmhEFwVE2RYAxvu/Dh1ydBqVb9gExypNJVRLCp 4aurc+82CyZwGWu85SCIFZYGqOIajKQtL+svjdusOUeJ9Qjid9DRPEenIwBPLR+Th8Ml 90xw== X-Gm-Message-State: AOJu0YzubQoPLq5Wwsz8OOjsZndUddjvfvPK3OClDy2jVMHSEZzDCI35 3RDTGUPeiqMrkakqj6UgRn3YKMi7d5w= X-Google-Smtp-Source: AGHT+IE38SjIQjBwOO5teOCJmv9T6ywX4UF9zfhz6nVP3vK7Ax5uuu9ZKOVyc39FUT8oTVTI/drDFg== X-Received: by 2002:a05:6358:716:b0:170:87d:f307 with SMTP id e22-20020a056358071600b00170087df307mr5606707rwj.19.1701762551867; Mon, 04 Dec 2023 23:49:11 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id c3-20020a63d143000000b005b18c53d73csm8698891pgj.16.2023.12.04.23.49.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 23:49:11 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 6E6C51142980; Tue, 5 Dec 2023 18:19:08 +1030 (ACDT) Date: Tue, 5 Dec 2023 18:19:08 +1030 From: Alan Modra To: binutils@sourceware.org Subject: memory leak in display_debug_addr Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org * dwarf.c (display_debug_addr): Free dummy debug_addr_info entry. Don't return without freeing debug_addr_info on error paths. diff --git a/binutils/dwarf.c b/binutils/dwarf.c index 47eadfd1c67..15046909bd0 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -7864,9 +7864,9 @@ display_debug_addr (struct dwarf_section *section, if (header_size != 8 && header_size != 16) { - warn (_("Corrupt %s section: expecting header size of 8 or 16, but found %zd instead\n"), + warn (_("Corrupt %s section: expecting header size of 8 or 16, but found %zd instead"), section->name, header_size); - return 0; + break; } SAFE_BYTE_GET_AND_INC (length, curr_header, 4, entry); @@ -7876,8 +7876,8 @@ display_debug_addr (struct dwarf_section *section, || length < (size_t) (entry - curr_header)) { warn (_("Corrupt %s section: unit_length field of %#" PRIx64 - " is invalid\n"), section->name, length); - return 0; + " is invalid"), section->name, length); + break; } end = curr_header + length; SAFE_BYTE_GET_AND_INC (version, curr_header, 2, entry); @@ -7899,7 +7899,7 @@ display_debug_addr (struct dwarf_section *section, { warn (_("Corrupt %s section: address size (%x) is wrong"), section->name, address_size); - return 0; + break; } while ((size_t) (end - entry) >= address_size) @@ -7914,8 +7914,9 @@ display_debug_addr (struct dwarf_section *section, } printf ("\n"); + free (debug_addr_info[count]); free (debug_addr_info); - return 1; + return i == count; } /* Display the .debug_str_offsets and .debug_str_offsets.dwo sections. */