ecoff: check result of stat

Message ID Z8YkqpGs7c9cRA5D@squeak.grove.modra.org
State New
Headers
Series ecoff: check result of stat |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply

Commit Message

Alan Modra March 3, 2025, 9:52 p.m. UTC
  * ecoff.c (_bfd_ecoff_write_armap): Don't use statbuf.st_mtime
	if stat call returns non-zero.  Use ARMAP_TIME_OFFSET rather
	than its expansion.
  

Patch

diff --git a/bfd/ecoff.c b/bfd/ecoff.c
index 5f9fa43b88f..a77107b38a7 100644
--- a/bfd/ecoff.c
+++ b/bfd/ecoff.c
@@ -3132,9 +3132,9 @@  _bfd_ecoff_write_armap (bfd *abfd,
      complain that the index is out of date.  Actually, the Ultrix
      linker just checks the archive name; the GNU linker may check the
      date.  */
-  stat (bfd_get_filename (abfd), &statbuf);
-  _bfd_ar_spacepad (hdr.ar_date, sizeof (hdr.ar_date), "%ld",
-		    (long) (statbuf.st_mtime + 60));
+  if (stat (bfd_get_filename (abfd), &statbuf) == 0)
+    _bfd_ar_spacepad (hdr.ar_date, sizeof (hdr.ar_date), "%ld",
+		      (long) (statbuf.st_mtime + ARMAP_TIME_OFFSET));
 
   /* The DECstation uses zeroes for the uid, gid and mode of the
      armap.  */