diff mbox series

PR32599, objcopy -I ihex: invalid operation

Message ID Z5W7tHLOUiF-SdBc@squeak.grove.modra.org
State New
Headers
Series PR32599, objcopy -I ihex: invalid operation |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply

Commit Message

Alan Modra Jan. 26, 2025, 4:36 a.m. UTC 
  Restores ihex get_symtab_upper_bound to what it was prior to commit
394a3f4f8d.  This will enable objcopy of other no-sym formats too.

	PR 32599
	* libbfd-in.h (_bfd_nosymbols_get_symtab_upper_bound): Define
	as _bfd_long_bfd_0.
	* libbfd.h: Regenerate.

Comments

Matthias Klose Jan. 27, 2025, 1:13 p.m. UTC | #1 
On 26.01.25 05:36, Alan Modra wrote:
> Restores ihex get_symtab_upper_bound to what it was prior to commit
> 394a3f4f8d.  This will enable objcopy of other no-sym formats too.
> 
> 	PR 32599
> 	* libbfd-in.h (_bfd_nosymbols_get_symtab_upper_bound): Define
> 	as _bfd_long_bfd_0.
> 	* libbfd.h: Regenerate.

that's a regression, please could you apply this to the 2.44 branch as well?

thanks, Matthias
diff mbox series

Patch

diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h
index 2c0d33142c6..b2f70fbfdac 100644
--- a/bfd/libbfd-in.h
+++ b/bfd/libbfd-in.h
@@ -415,7 +415,7 @@  extern bool _bfd_vms_lib_ia64_mkarchive
 /* Routines to use for BFD_JUMP_TABLE_SYMBOLS where there is no symbol
    support.  Use BFD_JUMP_TABLE_SYMBOLS (_bfd_nosymbols).  */
 
-#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_n1_error
+#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_0
 extern long _bfd_nosymbols_canonicalize_symtab
   (bfd *, asymbol **) ATTRIBUTE_HIDDEN;
 #define _bfd_nosymbols_make_empty_symbol _bfd_generic_make_empty_symbol
diff --git a/bfd/libbfd.h b/bfd/libbfd.h
index 41da1e9a312..86f220380a8 100644
--- a/bfd/libbfd.h
+++ b/bfd/libbfd.h
@@ -421,7 +421,7 @@  extern bool _bfd_vms_lib_ia64_mkarchive
 /* Routines to use for BFD_JUMP_TABLE_SYMBOLS where there is no symbol
    support.  Use BFD_JUMP_TABLE_SYMBOLS (_bfd_nosymbols).  */
 
-#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_n1_error
+#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_0
 extern long _bfd_nosymbols_canonicalize_symtab
   (bfd *, asymbol **) ATTRIBUTE_HIDDEN;
 #define _bfd_nosymbols_make_empty_symbol _bfd_generic_make_empty_symbol