Fix known minor objdump leak

Message ID Z4egfG8ridcGz_SU@squeak.grove.modra.org
State New
Headers
Series Fix known minor objdump leak |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply

Commit Message

Alan Modra Jan. 15, 2025, 11:48 a.m. UTC
  * objdump.c (main): Free disassembler_options.
  

Patch

diff --git a/binutils/objdump.c b/binutils/objdump.c
index 80044dea580..ebe586e0e3a 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -6001,12 +6001,14 @@  main (int argc, char **argv)
 	  {
 	    char *options;
 	    if (disassembler_options)
-	      /* Ignore potential memory leak for now.  */
 	      options = concat (disassembler_options, ",",
 				optarg, (const char *) NULL);
 	    else
-	      options = optarg;
+	      options = xstrdup (optarg);
+	    free (disassembler_options);
 	    disassembler_options = remove_whitespace_and_extra_commas (options);
+	    if (!disassembler_options)
+	      free (options);
 	  }
 	  break;
 	case 'j':