_bfd_write_ar_hdr

Message ID Z3j09qtx6Dookxl8@squeak.grove.modra.org
State New
Headers
Series _bfd_write_ar_hdr |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply

Commit Message

Alan Modra Jan. 4, 2025, 8:44 a.m. UTC
  This has been broken since commit 8f95b6e44955 in 2010, and apparently
nobody has noticed.  How we write archive headers depends on the
archive, not the contents.

	* libbfd-in.h (_bfd_write_ar_hdr): Correct.
	* libbfd.h: Regenerate.
  

Patch

diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h
index 17ee10a9277..2c0d33142c6 100644
--- a/bfd/libbfd-in.h
+++ b/bfd/libbfd-in.h
@@ -248,7 +248,7 @@  extern int bfd_generic_stat_arch_elt
 #define _bfd_read_ar_hdr(abfd) \
 	BFD_SEND (abfd, _bfd_read_ar_hdr_fn, (abfd))
 #define _bfd_write_ar_hdr(archive, abfd)	 \
-	BFD_SEND (abfd, _bfd_write_ar_hdr_fn, (archive, abfd))
+	BFD_SEND (archive, _bfd_write_ar_hdr_fn, (archive, abfd))
 
 /* Generic routines to use for BFD_JUMP_TABLE_GENERIC.  Use
    BFD_JUMP_TABLE_GENERIC (_bfd_generic).  */
diff --git a/bfd/libbfd.h b/bfd/libbfd.h
index f86cc23db45..41da1e9a312 100644
--- a/bfd/libbfd.h
+++ b/bfd/libbfd.h
@@ -254,7 +254,7 @@  extern int bfd_generic_stat_arch_elt
 #define _bfd_read_ar_hdr(abfd) \
 	BFD_SEND (abfd, _bfd_read_ar_hdr_fn, (abfd))
 #define _bfd_write_ar_hdr(archive, abfd)	 \
-	BFD_SEND (abfd, _bfd_write_ar_hdr_fn, (archive, abfd))
+	BFD_SEND (archive, _bfd_write_ar_hdr_fn, (archive, abfd))
 
 /* Generic routines to use for BFD_JUMP_TABLE_GENERIC.  Use
    BFD_JUMP_TABLE_GENERIC (_bfd_generic).  */