diff mbox series

Excessive gas .irpt count

Message ID Z39kGw-NY9CaAVy0@squeak.grove.modra.org
State New
Headers
Series Excessive gas .irpt count |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply

Commit Message

Alan Modra Jan. 9, 2025, 5:52 a.m. UTC 
  There is a test in do_repeat to error on "negative" repeat counts.
Just at what value a ssize_t is negative of course depends on the
host.  Change the excessive repeat count to a fixed value, 0x80000000,
ie. what would be seen as negative on a 32-bit host.
diff mbox series

Patch

diff --git a/gas/read.c b/gas/read.c
index 6d0d4b5e31a..5df1f3da588 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -3144,9 +3144,9 @@  do_repeat (size_t count, const char *start, const char *end,
   sb one;
   sb many;
 
-  if (((ssize_t) count) < 0)
+  if (count > 0x7fffffff)
     {
-      as_bad (_("negative count for %s - ignored"), start);
+      as_bad (_("excessive count %zu for %s - ignored"), count, start);
       count = 0;
     }
 
diff --git a/gas/testsuite/gas/macros/end.l b/gas/testsuite/gas/macros/end.l
index ff5d45213db..9e765cca062 100644
--- a/gas/testsuite/gas/macros/end.l
+++ b/gas/testsuite/gas/macros/end.l
@@ -1,4 +1,4 @@ 
 .*: Assembler messages:
 .*:1: Warning: \.endm .* \.macro
 .*:2: Warning: \.endr .* (\.rept|\.irpc?).*(\.rept|\.irpc?).*(\.rept|\.irpc?)
-.*:3: Error: negative count for REPT - ignored
+.*:3: Error: .* for REPT - ignored