mach-o segment section count assertion

Message ID Z2AH3pFrN9dC8JJx@squeak.grove.modra.org
State New
Headers
Series mach-o segment section count assertion |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply

Commit Message

Alan Modra Dec. 16, 2024, 10:58 a.m. UTC
  Add an assertion that verifies we have filled the mdata->sections
array in bfd_mach_o_flatten_sections.
  

Patch

diff --git a/bfd/mach-o.c b/bfd/mach-o.c
index 9ec5cabc021..8d5ca9b09a6 100644
--- a/bfd/mach-o.c
+++ b/bfd/mach-o.c
@@ -5076,7 +5076,7 @@  bfd_mach_o_flatten_sections (bfd *abfd)
 {
   bfd_mach_o_data_struct *mdata = bfd_mach_o_get_data (abfd);
   bfd_mach_o_load_command *cmd;
-  long csect = 0;
+  unsigned long csect;
   size_t amt;
 
   /* Count total number of sections.  */
@@ -5120,6 +5120,7 @@  bfd_mach_o_flatten_sections (bfd *abfd)
 	    mdata->sections[csect++] = sec;
 	}
     }
+  BFD_ASSERT (mdata->nsects == csect);
   return true;
 }