diff mbox series

[v2,2/3] aarch64: Add AArch64 support to libiberty

Message ID VI2PR83MB07189DFC70AC0AF24EF83B60F8272@VI2PR83MB0718.EURPRD83.prod.outlook.com
State New
Headers
Series aarch64: Relocation fixes and LTO |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

Evgeny Karpov Nov. 18, 2024, 11:15 a.m. UTC 
  The patch adds aarch64 architecture to the list of supported COFF
headers.

libiberty/ChangeLog:

	* simple-object-coff.c: Add AArch64.
---
 libiberty/simple-object-coff.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Richard Earnshaw Dec. 6, 2024, 5:37 p.m. UTC | #1 
On 18/11/2024 11:15, Evgeny Karpov wrote:
> The patch adds aarch64 architecture to the list of supported COFF
> headers.
> 
> libiberty/ChangeLog:
> 
> 	* simple-object-coff.c: Add AArch64.
> ---
>  libiberty/simple-object-coff.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libiberty/simple-object-coff.c b/libiberty/simple-object-coff.c
> index e748205972f..fd3c310db51 100644
> --- a/libiberty/simple-object-coff.c
> +++ b/libiberty/simple-object-coff.c
> @@ -219,7 +219,9 @@ static const struct coff_magic_struct coff_magic[] =
>    /* i386.  */
>    { 0x14c, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL },
>    /* x86_64.  */
> -  { 0x8664, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL }
> +  { 0x8664, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL },
> +  /* AArch64.  */
> +  { 0xaa64, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL }
>  };
>  
>  /* See if we have a COFF file.  */

This should just be merged from the gcc version of the same change. There's no need for an additional approval here.

R.
Evgeny Karpov Dec. 6, 2024, 5:53 p.m. UTC | #2 
Friday, December 6, 2024
Richard Earnshaw (lists) <Richard.Earnshaw@arm.com> wrote:

>> libiberty/simple-object-coff.c | 4 +++-
> This should just be merged from the gcc version of the same change. There's no need for an additional approval here.

Right, it was mentioned in this update.
https://sourceware.org/pipermail/binutils/2024-December/137997.html

Regards,
Evgeny
diff mbox series

Patch

diff --git a/libiberty/simple-object-coff.c b/libiberty/simple-object-coff.c
index e748205972f..fd3c310db51 100644
--- a/libiberty/simple-object-coff.c
+++ b/libiberty/simple-object-coff.c
@@ -219,7 +219,9 @@  static const struct coff_magic_struct coff_magic[] =
   /* i386.  */
   { 0x14c, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL },
   /* x86_64.  */
-  { 0x8664, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL }
+  { 0x8664, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL },
+  /* AArch64.  */
+  { 0xaa64, 0, F_EXEC | IMAGE_FILE_SYSTEM | IMAGE_FILE_DLL }
 };
 
 /* See if we have a COFF file.  */