From patchwork Thu Aug 27 00:12:55 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 142269 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C6E94BA79AA for ; Thu, 27 Aug 2026 00:14:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C6E94BA79AA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=lSHTNLIz X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id BE8C14BA2E24 for ; Thu, 27 Aug 2026 00:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE8C14BA2E24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE8C14BA2E24 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1787789614; cv=pass; b=u+oM/5pPv688QEgUzEt68ZKRAIsIdoYUeKPuR0i4TJnZbAHbtHrZyo3VQoq+EmiNFlNfsSUlIhq+8EfS2LHr6mT7aJkRpKJaYDa5/6aekaSvdWYaItlcz1b63k87XWgLsRsKKJCi3gN+vFIv5LPuyPRHCN0PoZSz3cTUsyXSbac= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1787789614; c=relaxed/simple; bh=74eqAFzvnHpKhAgs7ca59eLDNHHjQUYV2SHfXTgZxzM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=BvtOXqcs2NwOCF6rzWZpVpxl0v6ppMui+vEfI0Hkuz/hexWrZpbtuZKuHslZZ5+UBu8VWeExoazVzQD+ty60vCdd6r9yoOeVs0hb5AVnyfZUpa81VBxkVAxhXqAorJ7094k23d0fpsQsQ+CSXipPrB3FeTP1GXtfdU9H4fvVD3E= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=lSHTNLIz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE8C14BA2E24 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-84830c774a0so1959213b3a.1 for ; Wed, 26 Aug 2026 17:13:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787789614; cv=none; d=google.com; s=arc-20260327; b=ElZ1v6a/OANYjvH2K198AVI/K3GVCPP9bnm14PAv2tQLiaDmizUGwMXvuDG+QYT0fh vYdG2mz/WZZS6efQvJ2gmUoLOv7KUyUn5ZNsRBiFnXjn3ebX51/WoBfW3vLe3jN7PCwf RcNQ2SzAwMSZLRxp9xe09t4vCn2yAV7SRqa/Wzi6U3Gs4m3u3amnpTxBBFjDWq797D/B 1I+BI96Pis/yA9W3Ft/cEL+EEm5oZNDhE2rUYHuZenfNrUCPNyMmfyxe9dUBBhAEmunV q04hkwkw61CJEh7uoXY1oyJGF5F6PTCDSl7wAp9KkZViO9PGMrKXqN0EQtrt1i0CDVVA 5Etw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=TuDsKGAFURUXiOyPanUXcM1rHTc5jmrP7dsnjmwco0U=; fh=Q47HalnpTgORlLRVXtkSKh9GsN3n6x4i6rvKHWwZ86A=; b=Yk1TaLTViQOqULKmzcEiuquEM5kJU2NK9Zhj/XiXC6Klc+Y/J535Gr7W8tlw1YeH/B XYwdOclkcHyVksPFDuGX6yWOrhNQfFamDuKhyisuwamVLi7+gJKI32exUzDXOsmxkuuJ 2NngBD7syY/3FRjQhJc5Asj0PImeSsXHIEvxEwfB7Bti8BOQ4AslMm6mxOJEq5fMs+Ef qOKgCdQqXSRONAlaxLqkb3MVe3BzkhMauYvolLIADRZRzn5lZNH4AvhJix+DVgXRLNfe DWA1s6FugmLWYEhajka2OJaj0nlD2e5fFtHhMovvIFWj5mmKyg5d45ooEkfpeJI30TDZ 64HA==; darn=sourceware.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787789614; x=1788394414; darn=sourceware.org; h=content-type:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TuDsKGAFURUXiOyPanUXcM1rHTc5jmrP7dsnjmwco0U=; b=lSHTNLIzh7hFpr7h2XZ4jrWgGoemAZA5TG26PxWtbhazt45ouRoezbMmrUVubReNBm hP6HMSu0H+mdb/iFAgfe73ns8lWsV5QKgweiknqcUZN9IXye1biNVs2jSqjuzjZyPgVQ HAmgVjAdCRsI4e6cD21YqNP35lcJwArcU2Cuw4eCR7dLJSwC2Taf4UNHh4otLlM4W/4c wEXCTGMkq9xybFiSaV1C7reaiAPRUFTGko0TKpjx4q1yA7lH5wW1F3qMsj7uC1dlRGmJ kecUsRc8MCVJjqclrWcnpAWm56uwA06aX1ZvLyhdDP9Bmz8NxSGidDoiX7rMrrFt2UY3 t4pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787789614; x=1788394414; h=content-type:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TuDsKGAFURUXiOyPanUXcM1rHTc5jmrP7dsnjmwco0U=; b=T/L+11MRZpOGkOCVeqPVElZ3WPMWcQSias812hgsGOTmXRw4GrKJdqedqAX2tIp1WG wpJagJLX98a++h0fAZCGSzfeKq9YHr97QJ7gTNBpcj52qc8jnCpJ/3ABrCDQE0eC9GJi tuM8iTzYKnQAU28hZKBSkzNtkpLxu2AEjF9SLMx/6/XHeqiviDBtJppclQa17BImnzxd XbpbuYwwYcwNIW54+Fo1eDCSTLOe2rVPke05v4CKeQu8ItHV0aTIsEvK2Ia2IBI2+2FE TdReutG4FHROrtDdkyTl2YnpDWyfJwsUPf+TGXF4s3MVrJIMu338+XvFAHeGlvrVeeN6 FJXw== X-Gm-Message-State: AFuF++mYvkzbUMprUn4QmNys5WKd2Ki+zjYNVfnurA0KQu2mKfn1q/nY 86TaHLyYMz12p1WeZYXtoOgVgYE8bBjVRtVsAS1T5ZowXEhAcsPHxB67nb2xZuZtXrJy+AY+eaq zj0RQI9XwwT0ImnvOBkPpwKDS/JGZ7yt9cjZdg+w= X-Gm-Gg: AR+sD11ihJD8vXeJc2HJo87AcnzwSFK9rYDk5ux6NMZ6HMYKcyZuyZXOijfZYTjtf5o 8/HLJ8q75KcxSqu2G/IPGMKu2e+pUlqLONQqYP7b7vgD/c690Tq6D/w9iMw9ZwWpYC/y8pWU5r0 zVZPOO/VSoQPD8KBO5+WoR2Xc6NL0MPFywFYfX7PujmpRBT/7S8bercfXdv7o20UrGwUZHulm5n BSImWd2zthxqz62JOrNrFO2ARgDPOslVPteShuzPhazRbxPMQmCDUoX978coX5ae+cjO5PZ72gh axLm6DG8eO+tqjnHCia56RRlnVNNycdbdkmtsXG+GliLEgI+EWejaw== X-Received: by 2002:a05:6a20:c916:b0:3c8:d3a4:7b40 with SMTP id adf61e73a8af0-3cf7576da18mr23261697637.2.1787789613209; Wed, 26 Aug 2026 17:13:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Thu, 27 Aug 2026 08:12:55 +0800 X-Gm-Features: AcwNN1UGJZCF3IvXmaatqammql2RKma4MEJaxsIWhZV8JQ91BAW5WtehmgTmNj4 Message-ID: Subject: [v2 PATCH] elf: Verify that there is only one default version To: Binutils , Nick Clifton , Alan Modra , "Maciej W. Rozycki" , Jan Beulich X-Spam-Status: No, score=-3008.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org On Wed, Aug 26, 2026 at 11:35 AM H.J. Lu wrote: > > When assigning the symbol version, verify that there is only one default > version. > Here is the v2 patch to provide info of where multiple default versions are defined: ld -shared -o pr34550.so pr34550a.o pr34550b.o --version-script pr34550.t /usr/local/bin/ld: pr34550.so: multiple default versions of `fmod': `GLIBC_2.0' in pr34550a.o and `GLIBC_2.43' in pr34550b.o. /usr/local/bin/ld: failed to set dynamic section sizes: bad value From 43096b92b19323dbfbfe5ee41986c54032b96b92 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 26 Aug 2026 11:29:39 +0800 Subject: [PATCH v2] elf: Verify that there is only one default version When assigning the symbol version, verify that there is only one default version. bfd/ PR ld/34550 * elflink.c (_bfd_elf_link_assign_sym_version): Verify that there is only one default version. ld/ PR ld/34550 * testsuite/ld-elf/pr34550.d: New test. * testsuite/ld-elf/pr34550.t: Likewise. * testsuite/ld-elf/pr34550a.s: Likewise. * testsuite/ld-elf/pr34550b.s: Likewise. Signed-off-by: H.J. Lu --- bfd/elflink.c | 52 +++++++++++++++++++++++++++++++++- ld/testsuite/ld-elf/pr34550.d | 6 ++++ ld/testsuite/ld-elf/pr34550.t | 13 +++++++++ ld/testsuite/ld-elf/pr34550a.s | 5 ++++ ld/testsuite/ld-elf/pr34550b.s | 6 ++++ 5 files changed, 81 insertions(+), 1 deletion(-) create mode 100644 ld/testsuite/ld-elf/pr34550.d create mode 100644 ld/testsuite/ld-elf/pr34550.t create mode 100644 ld/testsuite/ld-elf/pr34550a.s create mode 100644 ld/testsuite/ld-elf/pr34550b.s diff --git a/bfd/elflink.c b/bfd/elflink.c index 09eaacc8497..e7348901b8c 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -2697,10 +2697,14 @@ _bfd_elf_link_assign_sym_version (struct elf_link_hash_entry *h, void *data) if (p != NULL && h->verinfo.vertree == NULL) { struct bfd_elf_version_tree *t; + bool default_version = false; ++p; if (*p == ELF_VER_CHR) - ++p; + { + default_version = true; + ++p; + } /* If there is no version string, we can just return out. */ if (*p == '\0') @@ -2714,6 +2718,52 @@ _bfd_elf_link_assign_sym_version (struct elf_link_hash_entry *h, void *data) if (hide) obed->elf_backend_hide_symbol (info, h, true); + else if (default_version) + { + /* Get the unversioned symbol for the default version. */ + struct elf_link_hash_entry *h_u; + size_t size = p - h->root.root.string - 1; + char *unversioned_name = bfd_malloc (size); + if (unversioned_name == NULL) + { + sinfo->failed = true; + return false; + } + memcpy (unversioned_name, h->root.root.string, size - 1); + unversioned_name[size - 1] = 0; + h_u = elf_link_hash_lookup (elf_hash_table (info), + unversioned_name, false, + false, false); + + /* There must be an unversioned symbol. */ + if (h_u == NULL) + abort (); + + while (h_u->root.type == bfd_link_hash_indirect + || h_u->root.type == bfd_link_hash_warning) + h_u = (struct elf_link_hash_entry *) h_u->root.u.i.link; + + /* Verify that there is only one default version. */ + if (h_u->versioned != versioned_hidden + && h_u->verinfo.vertree != h->verinfo.vertree) + { + /* xgettext:c-format */ + info->callbacks->einfo + (_("%X%P: %pB: multiple default versions of `%s': " + "`%s' in %pB and `%s' in %pB.\n"), + info->output_bfd, unversioned_name, + h_u->verinfo.vertree->name, + h_u->root.u.def.section->owner, + h->verinfo.vertree->name, + h->root.u.def.section->owner); + bfd_set_error (bfd_error_bad_value); + sinfo->failed = true; + free (unversioned_name); + return false; + } + + free (unversioned_name); + } /* If we are building an application, we need to create a version node for this version. */ diff --git a/ld/testsuite/ld-elf/pr34550.d b/ld/testsuite/ld-elf/pr34550.d new file mode 100644 index 00000000000..260c6cab1ee --- /dev/null +++ b/ld/testsuite/ld-elf/pr34550.d @@ -0,0 +1,6 @@ +#source: pr34550a.s +#source: pr34550b.s +#target: [check_shared_lib_support] +#as: +#ld: -shared --version-script=pr34550.t +#error: multiple default versions of `fmod': `GLIBC_2.0' in tmpdir/pr34550a.o and `GLIBC_2.43' in tmpdir/pr34550b.o. diff --git a/ld/testsuite/ld-elf/pr34550.t b/ld/testsuite/ld-elf/pr34550.t new file mode 100644 index 00000000000..37dff255cdc --- /dev/null +++ b/ld/testsuite/ld-elf/pr34550.t @@ -0,0 +1,13 @@ +GLIBC_2.0 { + global: + fmod; + local: + *; +}; + +GLIBC_2.43 { + global: + fmod; + local: + *; +} GLIBC_2.0; diff --git a/ld/testsuite/ld-elf/pr34550a.s b/ld/testsuite/ld-elf/pr34550a.s new file mode 100644 index 00000000000..fea245035b9 --- /dev/null +++ b/ld/testsuite/ld-elf/pr34550a.s @@ -0,0 +1,5 @@ + .text + .type fmod,%function + .globl fmod +fmod: + .dc.a 0 diff --git a/ld/testsuite/ld-elf/pr34550b.s b/ld/testsuite/ld-elf/pr34550b.s new file mode 100644 index 00000000000..babe762f882 --- /dev/null +++ b/ld/testsuite/ld-elf/pr34550b.s @@ -0,0 +1,6 @@ + .text + .type fmod_new,%function + .globl fmod_new +fmod_new: + .dc.a 0 + .symver fmod_new, fmod@@GLIBC_2.43 -- 2.55.0