From patchwork Wed Aug 5 08:50:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 140634 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E0464BAE7E4 for ; Wed, 5 Aug 2026 08:51:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E0464BAE7E4 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=KmIcaXB+ X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 552744BA9002 for ; Wed, 5 Aug 2026 08:50:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 552744BA9002 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 552744BA9002 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785919858; cv=pass; b=d5L6cFfX4HrEVCLKyWEdVmR0Jb63l7v8aX6nD41ob/6BvF/RtwXNJZQYIF3w7RRvIIyWd9HAKj+9WqgS2XF7hCwyP7BxPssSwrKK8fbAOI/o25R3AacnaqWUSctHjznyj2TR97hExrTiO+E/vmEt0aFoHVxvG0vAFQIttcBHBmg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785919858; c=relaxed/simple; bh=5FFu0itWM7oWjKGjTqqPtIujPxV2rZHypFUZYBSRAB8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=sZyTS7OP9FAvauk7GX6Uf4JNyS2hRGzIvnrZjCsUl0joS+lWKnaw36JIZakYSYehsVVX6dIalM/yPWNv8XIADZp1ajIfhaND0nGqbGrt7CvXj9SNlcThVhgAwl1nv4yTVprkHjmpYU3ztM4S9MqxVYMlud6A+gFSS+DpNmz9ROc= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=KmIcaXB+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 552744BA9002 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-8453427d3f4so905066b3a.3 for ; Wed, 05 Aug 2026 01:50:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1785919857; cv=none; d=google.com; s=arc-20260327; b=QuSJYXpeYJXuhJG8EjO+rf7CKrMSnrn8MsJAUIaBtHPczBHFK5jCi8NeggbWOpb/v5 XB/5+c7l3C3rdIObduy9j5w/lLp/vyFTpbIqckRear9x9y7MkjreLq0WEPkhCW5yDKw+ 20IxogjY0XRt/LOCfIFVBPE1YdeSujPj4Cm9g1I2yaWAfWBMYPvTCNgJ/s/h4j3GEWHS E6EVY/SBPaY1RkKo40l4NFeqiOZThnpxNjEVLssFsXFYMM3MvpIusr81nSdSyUBN7k2R tuFpJrdWRZfSZSB+10Y5FByAQ5V+8WSbzKl2rWzPnvz2rY+YHNFGueHnbf8i70BckZ3D Og1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=to:subject:message-id:date:from:mime-version:dkim-signature; bh=yEHplROVuTdlF3ZykgFHL5Q8Hi3Wk6FdMRD+KpWSGmc=; fh=H3mac1f0D6P7JW/Yg7SD7PbUw+2WnOX2bbPfSsxifvQ=; b=AJ33WxBftz3zSeexGqtK2L83etV611rgPgJjY8VdZY0YkywQfLRh95i2IjG+8R3dag Fp7jhh9Ma9puB/UwlUcWm0IwI6FYVKEWBh65G200Du1OFEb3V+tjUuxiWJF9//IAG04M E6MQZKotxtUUSyH3H0yq2G2rFzfDJOALi/MTuXhtj1i7aaOAH+E3tczL8bvezVaFq+SF Md5qbeezE3nX1MhuHlss7/hljBxJboAA3mjSWIymTaplbo1WY8MdgJiJF5NhTMLwjh4t AJshPP7E+bl5i6Bv66u/aEbmH41AQ+GyqfOSblUKarG8Xtcoxy6ckT2KVOb9TtP7Gg47 9Mvg==; darn=sourceware.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785919857; x=1786524657; darn=sourceware.org; h=content-type:to:subject:message-id:date:from:mime-version:from:to :cc:subject:date:message-id:reply-to:content-type; bh=yEHplROVuTdlF3ZykgFHL5Q8Hi3Wk6FdMRD+KpWSGmc=; b=KmIcaXB+6JDXnXs6NCK8K6di1MlPsOYgvG3AgJoFN32zVqS1DIVMMHf+srCjQW/RqT r4TKMovxNYNLfvzm4SaYq0DiTosRFH9bk0jST70O0X6EVZtl3px5PZ2iCOa+i1UTkaQ8 cGx4clZMOGuPSdjnqqdL+Jl13rGebTwm7+PX9Yjr9ZacoU8Oy6cxk1Hf6OyOfKRG3kXI fhY1kOz6YgYTNDAKzOf9fFtqQvkoNYI6uMpSdWAmwouBG1Y/CU/VurfiZrUQuGlkRrT/ mnFY0ONjtd+6eA8yQ0Rd8zv5HBlOMxn8BVVDaSQ1jR57gvCzmcsk3ZL/+ebSIyTBiEXH sRdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785919857; x=1786524657; h=content-type:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yEHplROVuTdlF3ZykgFHL5Q8Hi3Wk6FdMRD+KpWSGmc=; b=H8ZQoaCOlZ8QK8i9zBoPETqMBFxfD83ONx/VN0ZFGpTCr1kCRe/edql/35nzQnJ6QM nY7zXGEf8rSas6f0hkdkWNSdO1H9VIULPh9K73wHJ8EGGZRjSPMlY/1aIWXxpQ1HiOvt Q2cmmmISQOjEwYokwOLH8f6Umts5hDmPOkldTrTfqIxupK3J5JGGEH/Z+dMzau9yzp4A m0xLVugoA7a9g1vhb1yTGSuraourhz9ZPHTI519Nmuykwz8FDozdkuE0wE+YAg1xLNsu dskxL9VINTHI7jhfric9e3o3sHNo1j2Y/p/i3i3kFjDkkyIiae3MlUiSirXB6gPQjye7 y3JA== X-Gm-Message-State: AOJu0YzcjSTP7oKxiuTI5ZlOvcG8sFDeanR4bFtMp7B4DEoOs3pR521Q JPI5UcP0TxCy2SJCfI+St91KeqAU76OO6p781g+v6GSGnxpDVrHfJ7PfpgeMsyL7HlAVEeB6iWD RPDH2r2vsKF2tqVdLOVdEIoEImrVNpRNgO1W9XPE= X-Gm-Gg: AR+sD11x12PUOhDSKwXrAhOZ7VMVFWz7cN/sDdSzfdPsoefnuDdKHgoyyWHqptSt6nL Xn9CCtJUucAaTTCcUUMMpwPuDR4+df5k9pCBNX5wcO7SIzm3tVVIQMUKwTdz42J934MUTtpg9QA Q7FJ9o6MEovXOHRRFbloD4yeJnXvDB8JJgsoR7twJqeCPMzL2blZBVpu+OEL3hdpwkEV5jBOmI1 3TsUXFdIn4PaYxKTGDYt77jq68pSX5pYnHh0/Q03VI4q+9EfhgHKd2BTD4sPSPiiguMwW1pNons h2G6oUuXlNJdfinj7T3+gXfo+/CDQv+/ir0aoONaPRlN7g== X-Received: by 2002:a05:6a00:2eaa:b0:842:2a81:4c63 with SMTP id d2e1a72fcca58-84f2e00910amr5142317b3a.25.1785919856830; Wed, 05 Aug 2026 01:50:56 -0700 (PDT) MIME-Version: 1.0 From: "H.J. Lu" Date: Wed, 5 Aug 2026 16:50:18 +0800 X-Gm-Features: AUfX_mxRPfHtBWewxQlQMbBGtcaOiyE56x1iBr-U93XEjYWjioAKG-PS0iYhcMk Message-ID: Subject: [PATCH] ld: Check bfd_gc_sections return To: Binutils , Nick Clifton , Alan Modra , Jan Beulich , "Maciej W. Rozycki" X-Spam-Status: No, score=-3008.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org bfd_gc_sections may return false on invalid input: ld: pr34448-bug_18.o: bad reloc symbol index (0xf2000005 >= 0x13) for offset 0x4 in section `.text.get_tls[get_tls]' and set the BFD error to bfd_error_bad_value. Check bfd_gc_sections return and report the fatal error if the BFD error is bfd_error_bad_value. PR ld/34448 * ldlang.c (lang_gc_sections): Check bfd_gc_sections return and report the fatal error if the BFD error is bfd_error_bad_value. From 02ba2ff2dd6c58cb657cdbab4c33339b40ce1689 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 5 Aug 2026 16:43:05 +0800 Subject: [PATCH] ld: Check bfd_gc_sections return bfd_gc_sections may return false on invalid input: ld: pr34448-bug_18.o: bad reloc symbol index (0xf2000005 >= 0x13) for offset 0x4 in section `.text.get_tls[get_tls]' and set the BFD error to bfd_error_bad_value. Check bfd_gc_sections return and report the fatal error if the BFD error is bfd_error_bad_value. PR ld/34448 * ldlang.c (lang_gc_sections): Check bfd_gc_sections return and report the fatal error if the BFD error is bfd_error_bad_value. Signed-off-by: H.J. Lu --- ld/ldlang.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ld/ldlang.c b/ld/ldlang.c index 886c49a1861..f8e9d2496a4 100644 --- a/ld/ldlang.c +++ b/ld/ldlang.c @@ -8165,8 +8165,10 @@ lang_gc_sections (void) } } - if (link_info.gc_sections) - bfd_gc_sections (link_info.output_bfd, &link_info); + if (link_info.gc_sections + && !bfd_gc_sections (link_info.output_bfd, &link_info) + && bfd_get_error () == bfd_error_bad_value) + fatal (_("%P: --gc-sections failed: %E\n")); } /* Worker for lang_find_relro_sections_1. */ -- 2.55.0