diff mbox series

gas: terminate buffer SB in do_repeat()

Message ID 9c36492a-a0f5-4a00-9ee5-fc4ce49a3a46@suse.com
State New
Headers
Series gas: terminate buffer SB in do_repeat() |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Test passed

Commit Message

Jan Beulich June 18, 2024, 11:18 a.m. UTC 
  PR gas/31903

While elsewhere having realized that "one" doesn't point to a nul-
terminated string, it somehow didn't occur to me that the pre-existing
strstr() could have been wrong, and hence I blindly added a new use of
the function. Add the (already prior to 1e3c814459d8 ["gas: extend \+
support to .rept"]) missing call to sb_terminate(), leveraging that to
simplify the other two places where the lack of nul termination was
previously worked around.
diff mbox series

Patch

--- a/gas/read.c
+++ b/gas/read.c
@@ -3103,6 +3103,8 @@  do_repeat (size_t count, const char *sta
       return;
     }
 
+  sb_terminate (&one);
+
   if (expander != NULL && !*expander && strstr (one.ptr, "\\+") != NULL)
     {
       /* The 3 here and below are arbitrary, added in an attempt to limit
@@ -3116,8 +3118,7 @@  do_repeat (size_t count, const char *sta
 
 	  sb_build (&processed, one.len + 3);
 
-	  for (ptr = one.ptr;
-	       (bs = memchr (ptr, '\\', one.ptr + one.len - ptr)) != NULL; )
+	  for (ptr = one.ptr; (bs = strchr (ptr, '\\')) != NULL; )
 	    {
 	      sb_add_buffer (&processed, ptr, bs - ptr);
 	      switch (bs[1])
@@ -3148,7 +3149,7 @@  do_repeat (size_t count, const char *sta
 		}
 	    }
 
-	  sb_add_buffer (&processed, ptr, one.ptr + one.len - ptr);
+	  sb_add_string (&processed, ptr);
 
 	  sb_add_sb (&many, &processed);
 	  sb_kill (&processed);